From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: find_fh_dentry returned a DISCONNECTED directory Date: Fri, 14 Feb 2014 09:11:35 -0800 Message-ID: <87r475sjp4.fsf@xmission.com> References: <20140213212701.GB21982@fieldses.org> <8738jm1ss3.fsf@xmission.com> <20140214033030.GC21982@fieldses.org> <87ob2az5fc.fsf@xmission.com> <20140214144640.GE21982@fieldses.org> <877g8x1ypc.fsf@xmission.com> <20140214161412.GH21982@fieldses.org> <52FE4681.40901@fb.com> Mime-Version: 1.0 Content-Type: text/plain Cc: "J. Bruce Fields" , To: Josef Bacik Return-path: Received: from out03.mta.xmission.com ([166.70.13.233]:60989 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbaBNRL7 (ORCPT ); Fri, 14 Feb 2014 12:11:59 -0500 In-Reply-To: <52FE4681.40901@fb.com> (Josef Bacik's message of "Fri, 14 Feb 2014 11:38:25 -0500") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Josef Bacik writes: > Ok using d_make_root makes us leak inodes on umount (I don't know why, > I'm not drunk enough yet.) I haven't tried it yet but I'm almost 100% > positive if I just clear out DISCONNECTED we will BUG_ON() in > d_splice_alias() when we go to walk into the subvol we've mounted with > the default subvol option. So what I think I need to do is use use > d_materialise_unique in our lookup function instead of > d_splice_alias() and keep using d_obtain_alias() in get_default_root() > and just clear DISOCONNECTED on success. Does this sound crazy to > anybody else? Thanks, That sounds exactly right. Eric