From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: greearb@candelatech.com, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: properly return err from start()
Date: Thu, 30 Jan 2014 10:10:59 +0200 [thread overview]
Message-ID: <87r47pyjn0.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1390976791-9223-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Wed, 29 Jan 2014 07:26:31 +0100")
Michal Kazior <michal.kazior@tieto.com> writes:
> If recovery failed ath10k returned 0 (success) and
> mac80211 continued to call other driver callbacks.
> This caused null dereference.
>
> This is how the failure looked like:
>
> ath10k: ctl_resp never came in (-110)
> ath10k: failed to connect to HTC: -110
> ath10k: could not init core (-110)
> BUG: unable to handle kernel NULL pointer dereference at (null)
[...]
> Reported-By: Ben Greear <greearb@candelatech.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Thanks, applied.
> Thanks for reporting, Ben!
Indeed, thanks Ben. Please keep the reports coming :)
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <greearb@candelatech.com>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: properly return err from start()
Date: Thu, 30 Jan 2014 10:10:59 +0200 [thread overview]
Message-ID: <87r47pyjn0.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1390976791-9223-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Wed, 29 Jan 2014 07:26:31 +0100")
Michal Kazior <michal.kazior@tieto.com> writes:
> If recovery failed ath10k returned 0 (success) and
> mac80211 continued to call other driver callbacks.
> This caused null dereference.
>
> This is how the failure looked like:
>
> ath10k: ctl_resp never came in (-110)
> ath10k: failed to connect to HTC: -110
> ath10k: could not init core (-110)
> BUG: unable to handle kernel NULL pointer dereference at (null)
[...]
> Reported-By: Ben Greear <greearb@candelatech.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Thanks, applied.
> Thanks for reporting, Ben!
Indeed, thanks Ben. Please keep the reports coming :)
--
Kalle Valo
next prev parent reply other threads:[~2014-01-30 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 21:43 ath10k crash on firmware crash Ben Greear
2014-01-29 6:26 ` [PATCH] ath10k: properly return err from start() Michal Kazior
2014-01-29 6:26 ` Michal Kazior
2014-01-30 8:10 ` Kalle Valo [this message]
2014-01-30 8:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r47pyjn0.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.