From: Kevin Hilman <khilman@linaro.org>
To: Chao Xu <caesarxuchao@gmail.com>
Cc: linux-omap@vger.kernel.org, santosh.shilimkar@ti.com,
linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, tony@atomide.com, balbi@ti.com,
nm@ti.com
Subject: Re: [RFC/RFT/PATCH V3] gpio: omap: refresh patch "be more aggressive with pm_runtime" against v3.12-rc5
Date: Mon, 09 Dec 2013 08:03:21 -0800 [thread overview]
Message-ID: <87r49m8112.fsf@linaro.org> (raw)
In-Reply-To: <1386477638-6331-1-git-send-email-caesarxuchao@gmail.com> (Chao Xu's message of "Sat, 7 Dec 2013 22:40:38 -0600")
Chao Xu <caesarxuchao@gmail.com> writes:
> From: Felipe Balbi <balbi@ti.com>
>
> try to keep gpio block suspended as much as possible.
> Tested with pandaboard and a sysfs exported gpio.
>
> Signed-off-by: Felipe Balbi <balbi at ti.com>
>
> [caesarxuchao@gmail.com : Refreshed against v3.12-rc5, and added
> revision check to enable aggressive pm_runtime on OMAP4-only. Because
> am33xx_gpio_sysc.idlemodes seems to be wrongly marked as
> SIDLE_SMART_WKUP, which might cause missed interrupts with this patch.
> Tested on Pandaboard rev A2.]
> Signed-off-by: Chao Xu <caesarxuchao@gmail.com>
I have several problems with this patch.
First, the changelog is missing a lot of information. In particular, nowhere
is it described what problem is this patch addressing and how this
patch addresses that problem.
Second, I don't see any mention of off-mode, and I suspect there are
issues with off-mode here that are not being addressed.
Also, I *really* don't like any approach that is targetted at a single
SoC.
Kevin
next prev parent reply other threads:[~2013-12-09 16:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 22:46 [PATCH V2] gpio: omap: refresh patch "be more aggressive with pm_runtime" against v3.12-rc5 Chao Xu
2013-11-26 22:46 ` Chao Xu
2013-11-26 23:07 ` Felipe Balbi
2013-11-26 23:07 ` Felipe Balbi
2013-11-29 10:05 ` Linus Walleij
2013-11-29 17:04 ` Santosh Shilimkar
2013-11-29 17:04 ` Santosh Shilimkar
2013-12-02 23:00 ` Chao Xu
2013-12-02 23:00 ` Chao Xu
2013-12-08 4:40 ` [RFC/RFT/PATCH V3] " Chao Xu
2013-12-09 10:15 ` Linus Walleij
2013-12-09 16:03 ` Kevin Hilman [this message]
2013-12-12 18:19 ` Linus Walleij
2013-12-12 18:28 ` Felipe Balbi
2013-12-12 18:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r49m8112.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=balbi@ti.com \
--cc=caesarxuchao@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.