From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: Pad drm_mode_get_connector to 64-bit boundary Date: Wed, 16 Oct 2013 13:54:37 +0300 Message-ID: <87r4bl5vv6.fsf@intel.com> References: <1381913342-17634-1-git-send-email-chris@chris-wilson.co.uk> <87txgh5xpe.fsf@intel.com> <20131016102402.GM29463@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20131016102402.GM29463@nuc-i3427.alporthouse.com> Sender: stable-owner@vger.kernel.org To: Chris Wilson Cc: dri-devel@lists.freedesktop.org, Dave Airlie , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Wed, 16 Oct 2013, Chris Wilson wrote: > On Wed, Oct 16, 2013 at 01:14:53PM +0300, Jani Nikula wrote: >> > --- a/include/uapi/drm/drm_mode.h >> > +++ b/include/uapi/drm/drm_mode.h >> > @@ -223,6 +223,8 @@ struct drm_mode_get_connector { >> > __u32 connection; >> > __u32 mm_width, mm_height; /**< HxW in millimeters */ >> > __u32 subpixel; >> > + >> > + __u32 pad; >> >> Would a small comment here be in order? > > We haven't explained padding in the past. It has been taken for granted > that the pad members are there to make compat problems disappear. Okay, sorry for the noise. J. -- Jani Nikula, Intel Open Source Technology Center