Re: [PATCH] drm/i915: Add breadcrumbs for why the backlight is being set

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 14 Oct 2013, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Mon, Oct 14, 2013 at 10:42:37AM +0300, Jani Nikula wrote:
>> On Sun, 13 Oct 2013, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
>> > index 2acf5cae20e4..564da613b278 100644
>> > --- a/drivers/gpu/drm/i915/intel_opregion.c
>> > +++ b/drivers/gpu/drm/i915/intel_opregion.c
>> > @@ -405,6 +405,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
>> >  	if (bclp > 255)
>> >  		return ASLC_BACKLIGHT_FAILED;
>> >  
>> > +	DRM_DEBUG_KMS("updating opregion backlight %d/255\n", bclp);
>> 
>> Just a few lines earliner we have:
>> 
>> 	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
>
> Right, I wasn't sure about changing that to suite my purposes - I
> guessed that it was intentionally a different debug level pre-validation
> for a reason and so added a new message at the debug level as the
> messages within the modesetting and backlight operation.

Please just change that to suit your needs instead of adding a new one.

Jani.


> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre

-- 
Jani Nikula, Intel Open Source Technology Center