From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMHP4-0005l7-9F for qemu-devel@nongnu.org; Wed, 18 Sep 2013 09:02:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMHOz-0004Aj-2R for qemu-devel@nongnu.org; Wed, 18 Sep 2013 09:02:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMHOy-0004AT-R6 for qemu-devel@nongnu.org; Wed, 18 Sep 2013 09:02:41 -0400 From: Juan Quintela In-Reply-To: <1f3a31a10f23b1dfafc4e178d6a4b0f07e384700.1376359935.git.yamahata@private.email.ne.jp> (Isaku Yamahata's message of "Tue, 13 Aug 2013 11:12:43 +0900") References: <1f3a31a10f23b1dfafc4e178d6a4b0f07e384700.1376359935.git.yamahata@private.email.ne.jp> Date: Wed, 18 Sep 2013 15:02:24 +0200 Message-ID: <87r4cmuvtr.fsf@elfo.elfo> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] rdma: clean up of qemu_rdma_cleanup() Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: owasserm@redhat.com, mrhines@us.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com Isaku Yamahata wrote: > - It can't be determined by RDMAContext::cm_id != NULL if the connection > is established or not. > - RDMAContext::cm_id is leaked and not destroyed because it is set to NULL > too early. > - RDMAContext::qp is created by rdma_create_qp() so that it should be destroyed > by rdma_destroy_qp(). not ibv_destroy_qp() > > Cc: Michael R. Hines > Signed-off-by: Isaku Yamahata Reviewed-by: Juan Quintela