All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Rockai <prockai@redhat.com>
To: lvm-devel@redhat.com
Subject: duplicate pv names
Date: Wed, 03 Apr 2013 11:32:06 +0200	[thread overview]
Message-ID: <87r4isklih.fsf@mornfall.net> (raw)
In-Reply-To: <20130402212408.GA1923@redhat.com> (David Teigland's message of "Tue, 2 Apr 2013 17:24:08 -0400")

Hi,

David Teigland <teigland@redhat.com> writes:
> My current patch set it having a problem with the test vgimportclone.sh,
> which has me questioning the desired pvs output with duplicate pv names.

I ran into similar problems with a different set of patches, that remove
pv_read. What I'll probably need to do is adding a list of devices to
PVs, so we can check whether something on the command line matches any
of the "duplicate" PVs.

I see you make quite heavy use of pv_read in your new version of
process_each_pv. You can have a look at:

(git clone) http://repos.mornfall.net/lvm2/mornfall.git

branch "merged" or for more limited view of the pv_read removal patches,
branch "lvmcache". (git checkout origin/merged).

It would be good if we could get rid of pv_read, as the code for
handling nomda PVs is wrong anyway, and we always need to scan. I think
the only remaining issue with the non-pv_read version is the duplicate
handling as outlined above.

Petr

-- 
id' Ash = Ash; id' Dust = Dust; id' _ = undefined



  reply	other threads:[~2013-04-03  9:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-02 21:24 duplicate pv names David Teigland
2013-04-03  9:32 ` Petr Rockai [this message]
2013-04-03 15:22   ` David Teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4isklih.fsf@mornfall.net \
    --to=prockai@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.