From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 1/2] driver: serial-omap: move max uart count into generic header file. Date: Mon, 18 Mar 2013 11:45:26 -0700 Message-ID: <87r4jcim2h.fsf@linaro.org> References: <1363604206-11264-1-git-send-email-sourav.poddar@ti.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1363604206-11264-1-git-send-email-sourav.poddar@ti.com> (Sourav Poddar's message of "Mon, 18 Mar 2013 16:26:46 +0530") Sender: linux-kernel-owner@vger.kernel.org To: Sourav Poddar Cc: gregkh@linuxfoundation.org, tony@atomide.com, rmk+kernel@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, b-cousson@ti.com, Santosh Shilimkar , Felipe Balbi , Rajendra nayak List-Id: linux-omap@vger.kernel.org Sourav Poddar writes: > OMAP_MAX_HSUART_PORTS is moved to omap_serial header file. Why? You started to explain it in the cover letter, but a full description belongs here for the permanent git history. Kevin > Cc: Santosh Shilimkar > Cc: Felipe Balbi > Cc: Rajendra nayak > Signed-off-by: Sourav Poddar > --- > drivers/tty/serial/omap-serial.c | 2 -- > include/linux/platform_data/serial-omap.h | 1 + > 2 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c > index 5722eaf..4c2ba9f 100644 > --- a/drivers/tty/serial/omap-serial.c > +++ b/drivers/tty/serial/omap-serial.c > @@ -43,8 +43,6 @@ > #include > #include > > -#define OMAP_MAX_HSUART_PORTS 6 > - > #define UART_BUILD_REVISION(x, y) (((x) << 8) | (y)) > > #define OMAP_UART_REV_42 0x0402 > diff --git a/include/linux/platform_data/serial-omap.h b/include/linux/platform_data/serial-omap.h > index ff9b0aa..92c48c2 100644 > --- a/include/linux/platform_data/serial-omap.h > +++ b/include/linux/platform_data/serial-omap.h > @@ -29,6 +29,7 @@ > * is used as console uart. > */ > #define OMAP_SERIAL_NAME "ttyO" > +#define OMAP_MAX_HSUART_PORTS 6 > > struct omap_uart_port_info { > bool dma_enabled; /* To specify DMA Mode */ From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@linaro.org (Kevin Hilman) Date: Mon, 18 Mar 2013 11:45:26 -0700 Subject: [PATCH 1/2] driver: serial-omap: move max uart count into generic header file. In-Reply-To: <1363604206-11264-1-git-send-email-sourav.poddar@ti.com> (Sourav Poddar's message of "Mon, 18 Mar 2013 16:26:46 +0530") References: <1363604206-11264-1-git-send-email-sourav.poddar@ti.com> Message-ID: <87r4jcim2h.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Sourav Poddar writes: > OMAP_MAX_HSUART_PORTS is moved to omap_serial header file. Why? You started to explain it in the cover letter, but a full description belongs here for the permanent git history. Kevin > Cc: Santosh Shilimkar > Cc: Felipe Balbi > Cc: Rajendra nayak > Signed-off-by: Sourav Poddar > --- > drivers/tty/serial/omap-serial.c | 2 -- > include/linux/platform_data/serial-omap.h | 1 + > 2 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c > index 5722eaf..4c2ba9f 100644 > --- a/drivers/tty/serial/omap-serial.c > +++ b/drivers/tty/serial/omap-serial.c > @@ -43,8 +43,6 @@ > #include > #include > > -#define OMAP_MAX_HSUART_PORTS 6 > - > #define UART_BUILD_REVISION(x, y) (((x) << 8) | (y)) > > #define OMAP_UART_REV_42 0x0402 > diff --git a/include/linux/platform_data/serial-omap.h b/include/linux/platform_data/serial-omap.h > index ff9b0aa..92c48c2 100644 > --- a/include/linux/platform_data/serial-omap.h > +++ b/include/linux/platform_data/serial-omap.h > @@ -29,6 +29,7 @@ > * is used as console uart. > */ > #define OMAP_SERIAL_NAME "ttyO" > +#define OMAP_MAX_HSUART_PORTS 6 > > struct omap_uart_port_info { > bool dma_enabled; /* To specify DMA Mode */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754447Ab3CRSpc (ORCPT ); Mon, 18 Mar 2013 14:45:32 -0400 Received: from mail-pb0-f49.google.com ([209.85.160.49]:60238 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752420Ab3CRSpa (ORCPT ); Mon, 18 Mar 2013 14:45:30 -0400 From: Kevin Hilman To: Sourav Poddar Cc: , , , , , , , , Santosh Shilimkar , Felipe Balbi , Rajendra nayak Subject: Re: [PATCH 1/2] driver: serial-omap: move max uart count into generic header file. References: <1363604206-11264-1-git-send-email-sourav.poddar@ti.com> Date: Mon, 18 Mar 2013 11:45:26 -0700 In-Reply-To: <1363604206-11264-1-git-send-email-sourav.poddar@ti.com> (Sourav Poddar's message of "Mon, 18 Mar 2013 16:26:46 +0530") Message-ID: <87r4jcim2h.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sourav Poddar writes: > OMAP_MAX_HSUART_PORTS is moved to omap_serial header file. Why? You started to explain it in the cover letter, but a full description belongs here for the permanent git history. Kevin > Cc: Santosh Shilimkar > Cc: Felipe Balbi > Cc: Rajendra nayak > Signed-off-by: Sourav Poddar > --- > drivers/tty/serial/omap-serial.c | 2 -- > include/linux/platform_data/serial-omap.h | 1 + > 2 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c > index 5722eaf..4c2ba9f 100644 > --- a/drivers/tty/serial/omap-serial.c > +++ b/drivers/tty/serial/omap-serial.c > @@ -43,8 +43,6 @@ > #include > #include > > -#define OMAP_MAX_HSUART_PORTS 6 > - > #define UART_BUILD_REVISION(x, y) (((x) << 8) | (y)) > > #define OMAP_UART_REV_42 0x0402 > diff --git a/include/linux/platform_data/serial-omap.h b/include/linux/platform_data/serial-omap.h > index ff9b0aa..92c48c2 100644 > --- a/include/linux/platform_data/serial-omap.h > +++ b/include/linux/platform_data/serial-omap.h > @@ -29,6 +29,7 @@ > * is used as console uart. > */ > #define OMAP_SERIAL_NAME "ttyO" > +#define OMAP_MAX_HSUART_PORTS 6 > > struct omap_uart_port_info { > bool dma_enabled; /* To specify DMA Mode */