From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ted Zlatanov Subject: Re: [PATCH] git-send-email: add ~/.authinfo parsing Date: Mon, 04 Feb 2013 16:41:43 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87r4kvsqnc.fsf@lifelogs.com> References: <2f93ce7b6b5d3f6c6d1b99958330601a5560d4ba.1359486391.git.mina86@mina86.com> <7vvcafojf4.fsf@alter.siamese.dyndns.org> <20130130074306.GA17868@sigill.intra.peff.net> <878v74vwst.fsf@lifelogs.com> <20130204201040.GA13272@sigill.intra.peff.net> <87a9rju8l7.fsf@lifelogs.com> <20130204205911.GA13186@sigill.intra.peff.net> <8738xbu6qj.fsf@lifelogs.com> <20130204212203.GC13186@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain Cc: Michal Nazarewicz , Junio C Hamano , git@vger.kernel.org, Krzysztof Mazur To: Jeff King X-From: git-owner@vger.kernel.org Mon Feb 04 22:42:07 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U2Tni-0000v4-VC for gcvg-git-2@plane.gmane.org; Mon, 04 Feb 2013 22:42:07 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755186Ab3BDVlo (ORCPT ); Mon, 4 Feb 2013 16:41:44 -0500 Received: from z.lifelogs.com ([173.255.230.239]:37276 "EHLO z.lifelogs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754448Ab3BDVlo (ORCPT ); Mon, 4 Feb 2013 16:41:44 -0500 Received: from heechee (c-65-96-148-157.hsd1.ma.comcast.net [65.96.148.157]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: tzz) by z.lifelogs.com (Postfix) with ESMTPSA id B8135DE0CA; Mon, 4 Feb 2013 21:41:43 +0000 (UTC) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" In-Reply-To: <20130204212203.GC13186@sigill.intra.peff.net> (Jeff King's message of "Mon, 4 Feb 2013 16:22:03 -0500") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Mon, 4 Feb 2013 16:22:03 -0500 Jeff King wrote: >> Currently, we map both the "port" and "protocol" netrc tokens to the >> credential helper protocol's "protocol". So this will have undefined >> results. To do what you specify could be pretty simple: we could do a >> preliminary scan of the tokens, looking for "host X port Y" where Y is >> an integer, and rewriting the host to be "X:Y". That would be clean and >> simple, unless the user breaks it with "host x:23 port 22". Let me know >> if you agree and I'll do. JK> Yeah, I think that is simple and obvious. If the user is saying "host JK> x:23 port 22", that is nonsensical. OK; added. Ted