From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: akpm@linux-foundation.org, bfields@fieldses.org,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Ravishankar N <ravi.n1@samsung.com>,
Amit Sahrawat <a.sahrawat@samsung.com>
Subject: Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails
Date: Mon, 15 Oct 2012 16:57:12 +0900 [thread overview]
Message-ID: <87r4p0417r.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <CAKYAXd-zV+SH4-CqYCxK1Ph34+5CKPKrbG9_rnH1c9rD_wcsng@mail.gmail.com> (Namjae Jeon's message of "Mon, 15 Oct 2012 16:28:30 +0900")
Namjae Jeon <linkinjeon@gmail.com> writes:
>> OK, I think I got where is wrong. If it is the subdir of rootdir,
>> fat_dget() should get the inode of root?
> That is correct. Whenever fat_dget() is called for sub-directories
> which is in root folder, we assign root inode as parent inode.
>>
>> So, I guess if parent_logstart == 0, it is BUG().
> Would you explain more why you think it is BUG() ?
Because root dentry is never expired until umount. So, fat_dget()
shouldn't never fail to get inode for subdir of rootdir. Otherwise,
"stale_rw" will not be working in the case even if there is cache.
I.e. I think we don't need to check parent_logstart == 0.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2012-10-15 7:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 8:32 [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails Namjae Jeon
2012-10-13 9:27 ` OGAWA Hirofumi
2012-10-13 14:03 ` Namjae Jeon
2012-10-13 14:35 ` OGAWA Hirofumi
2012-10-13 15:14 ` Namjae Jeon
2012-10-13 16:50 ` OGAWA Hirofumi
2012-10-15 7:28 ` Namjae Jeon
2012-10-15 7:57 ` OGAWA Hirofumi [this message]
2012-10-15 13:20 ` Namjae Jeon
2012-10-23 7:34 ` Namjae Jeon
2012-10-23 7:53 ` OGAWA Hirofumi
2012-10-23 11:38 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4p0417r.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=ravi.n1@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.