From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swb6r-00010P-2i for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:45:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Swb6l-00034m-0C for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:45:16 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:36981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swb6k-00034Y-Se for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:45:10 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 1 Aug 2012 11:45:09 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 8290FC90571 for ; Wed, 1 Aug 2012 11:38:47 -0400 (EDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q71FbRsf037320 for ; Wed, 1 Aug 2012 11:37:27 -0400 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q71FbGE3020895 for ; Wed, 1 Aug 2012 09:37:16 -0600 From: Anthony Liguori In-Reply-To: <50194975.1060306@reactos.org> References: <1341611595-9847-1-git-send-email-hpoussin@reactos.org> <1341611595-9847-2-git-send-email-hpoussin@reactos.org> <5019365C.2060906@us.ibm.com> <50194975.1060306@reactos.org> Date: Wed, 01 Aug 2012 10:37:11 -0500 Message-ID: <87r4rq39p4.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] pc: remove DEBUG_BIOS define and QEMU exit I/O ports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Herv=C3=A9?= Poussineau Cc: qemu-devel@nongnu.org Herv=C3=A9 Poussineau writes: > Anthony Liguori a =C3=A9crit : >> On 07/06/2012 04:53 PM, Herv=C3=A9 Poussineau wrote: >>> Debug output ports (enabled by DEBUG_BIOS define) can be replaced by: >>> -chardev stdio,id=3Ddebugcon,mux=3Don >>> -device isa-debugcon,iobase=3D0x402,chardev=3Ddebugcon >>> -device isa-debugcon,iobase=3D0x403,chardev=3Ddebugcon >>> -device isa-debugcon,iobase=3D0x500,chardev=3Ddebugcon >>> -device isa-debugcon,iobase=3D0x503,chardev=3Ddebugcon >>> >>> QEMU exit (which can be guest triggered) can be replaced by: >>> -device isa-debugexit,iobase=3D0x501 >>> -device isa-debugexit,iobase=3D0x501,access-size=3D2 >>> -device isa-debugexit,iobase=3D0x502,access-size=3D2 >>> >>> Signed-off-by: Herv=C3=A9 Poussineau >>> --- >>> >>> Anthony, this patch is a follow-up of a patch I sent in March 2012: >>> http://lists.gnu.org/archive/html/qemu-devel/2012-03/msg00031.html >>> >>> Will you accept this approach, where your regression suite will require >>> a new parameter "-device isa-debugexit,iobase=3D0x501" ? >>> > > [...] > >>> >>> @@ -602,18 +577,8 @@ static void *bochs_bios_init(void) >>> uint64_t *numa_fw_cfg; >>> int i, j; >>> >>> - register_ioport_write(0x400, 1, 2, bochs_bios_write, NULL); >>> - register_ioport_write(0x401, 1, 2, bochs_bios_write, NULL); >>> - register_ioport_write(0x402, 1, 1, bochs_bios_write, NULL); >>> - register_ioport_write(0x403, 1, 1, bochs_bios_write, NULL); >>> register_ioport_write(0x8900, 1, 1, bochs_bios_write, NULL); >>> >>> - register_ioport_write(0x501, 1, 1, bochs_bios_write, NULL); >>> - register_ioport_write(0x501, 1, 2, bochs_bios_write, NULL); >>> - register_ioport_write(0x502, 1, 2, bochs_bios_write, NULL); >>> - register_ioport_write(0x500, 1, 1, bochs_bios_write, NULL); >>> - register_ioport_write(0x503, 1, 1, bochs_bios_write, NULL); >>> - >>> fw_cfg =3D fw_cfg_init(BIOS_CFG_IOPORT, BIOS_CFG_IOPORT + 1, 0, 0= ); >>> >>> fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1); >>=20 >> Removing this from the default PC breaks compatibility. I don't mind=20 >> having a way to disable it but it needs to be there by default. >>=20 >> Among other things, my test suite depends on these ports. >>=20 > > OK for keeping them on compat PC machines. > However, for current ones (1.2 or later), I don't want to have them by=20 > default as it is an QEMU exit which is guest triggerable. > Will you accept this approach, where your regression suite will require > a new parameter "-device isa-debugexit,iobase=3D0x501" ? Yes although I'd prefer the iobase not be required to be explicitly specified. Regards, Anthony Liguori > > Regards, > > Herv=C3=A9