From: Rusty Russell <rusty@rustcorp.com.au>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] Guard check in module loader against integer overflow
Date: Wed, 23 May 2012 21:41:54 +0930 [thread overview]
Message-ID: <87r4ubxfjp.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120522145613.32115.21217.stgit@warthog.procyon.org.uk>
On Tue, 22 May 2012 15:56:13 +0100, David Howells <dhowells@redhat.com> wrote:
> The check:
>
> if (len < hdr->e_shoff + hdr->e_shnum * sizeof(Elf_Shdr))
>
> may not work if there's an overflow in the right-hand side of the condition.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Thanks; though the sanity checks are merely against accidents, not
malice, it's worth fixing.
Applied,
Rusty.
prev parent reply other threads:[~2012-05-23 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 14:56 [PATCH] Guard check in module loader against integer overflow David Howells
2012-05-23 12:11 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4ubxfjp.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.