From: Kevin Hilman <khilman@ti.com>
To: Steve Sakoman <sakoman@gmail.com>
Cc: Dave Hylands <dhylands@gmail.com>, linux-omap@vger.kernel.org
Subject: Re: Regressions for older OMAP3503 silicon
Date: Wed, 05 Oct 2011 16:28:26 -0700 [thread overview]
Message-ID: <87r52rnhlx.fsf@ti.com> (raw)
In-Reply-To: <CAGDS+nng341_xQMAmQcu9J0avk0p1bbYC2vs53qTAc-DguoKZg@mail.gmail.com> (Steve Sakoman's message of "Wed, 5 Oct 2011 12:48:49 -0700")
Steve Sakoman <sakoman@gmail.com> writes:
> On Wed, Oct 5, 2011 at 11:10 AM, Kevin Hilman <khilman@ti.com> wrote:
>
>> The need to comment this out suggests that omap3_has_io_wakeup() is
>> returning true for this SoC but should not.
>>
>> Looking at mach-omap2/io.c, that feature flag is not set on the 3505 and
>> 3517, but is set on the 3503:
>>
>> if (!cpu_is_omap3505() && !cpu_is_omap3517())
>> omap_features |= OMAP3_HAS_IO_WAKEUP;
>>
>> Adding a case for the 3503 here should fix this problem.
>>
>> Maybe check other checks for cpu_is_omap3505() and see if those should
>> also be checking for the 3503.
>
> I only see this error on ES2.1 3503 based Overo COMs.
>
> So I am wondering if there might be an errata in this area for early
> 3503 processors?
The IO daisy chain feature was added in later revisions (for 34xx, it
only exists for >= ES3.1.) Sounds like enabling that feature flag
should have some revision checks added.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-10-05 23:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 7:14 Regressions for older OMAP3503 silicon Dave Hylands
2011-10-05 16:26 ` Tony Lindgren
2011-10-05 18:01 ` Paul Walmsley
2011-10-05 18:19 ` Steve Sakoman
2011-10-05 18:59 ` Tony Lindgren
2011-10-06 6:29 ` Dave Hylands
2011-10-05 18:09 ` Paul Walmsley
2011-10-06 6:24 ` Dave Hylands
2011-10-06 16:14 ` Paul Walmsley
2011-10-06 14:23 ` Steve Sakoman
2011-10-05 18:10 ` Kevin Hilman
2011-10-05 18:35 ` Paul Walmsley
2011-10-05 19:48 ` Steve Sakoman
2011-10-05 21:20 ` Paul Walmsley
2011-10-05 23:28 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r52rnhlx.fsf@ti.com \
--to=khilman@ti.com \
--cc=dhylands@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=sakoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.