From: Kevin Hilman <khilman@ti.com>
To: Vishwanath BS <vishwanath.bs@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
mohanv@ti.com
Subject: Re: [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence
Date: Tue, 04 Oct 2011 13:47:48 -0700 [thread overview]
Message-ID: <87r52s8owb.fsf@ti.com> (raw)
In-Reply-To: <1317750724-32553-2-git-send-email-vishwanath.bs@ti.com> (Vishwanath BS's message of "Tue, 4 Oct 2011 23:22:01 +0530")
Hi Vishwa,
Vishwanath BS <vishwanath.bs@ti.com> writes:
> As per OMAP3630 TRM Section 3.5.7.2.2, the right sequence for enabling IO Daisy
> chain is "The I/O wake-up scheme is enabled by triggering the I/O daisy chain
> control (Wu clock) by programming a dedicated register
> (PRCM.PM_WKEN_WKUP[16] EN_IO_CHAIN) in the PRCM module.Software must wait for
> the I/O daisy chain to complete before it transitions the PER domain to a
> nonfunctional state. This is done by polling a dedicated status bit in the PRCM
> module (PRCM.PM_WKST_WKUP[16] ST_IO_CHAIN). This status bit must be cleared by
> software when the bit is read to 1".
>
> The original code was polling on a wrong register which is fixed in this patch.
> Also omap3_enable_io_chain is made non static as it's going to be used in
> subsequent patches.
>
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
A fix for this was posted[1] by Mohan V (added to Cc) back in June. It
recieved a few minor comments but an updated version was never posted.
Maybe you can ping Mohan or update that version fixing the comments
mentioned in that thread.
Thanks,
Kevin
[1] http://marc.info/?l=linux-omap&w=2&r=1&s=%27Mohan+V%27&q=b
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence
Date: Tue, 04 Oct 2011 13:47:48 -0700 [thread overview]
Message-ID: <87r52s8owb.fsf@ti.com> (raw)
In-Reply-To: <1317750724-32553-2-git-send-email-vishwanath.bs@ti.com> (Vishwanath BS's message of "Tue, 4 Oct 2011 23:22:01 +0530")
Hi Vishwa,
Vishwanath BS <vishwanath.bs@ti.com> writes:
> As per OMAP3630 TRM Section 3.5.7.2.2, the right sequence for enabling IO Daisy
> chain is "The I/O wake-up scheme is enabled by triggering the I/O daisy chain
> control (Wu clock) by programming a dedicated register
> (PRCM.PM_WKEN_WKUP[16] EN_IO_CHAIN) in the PRCM module.Software must wait for
> the I/O daisy chain to complete before it transitions the PER domain to a
> nonfunctional state. This is done by polling a dedicated status bit in the PRCM
> module (PRCM.PM_WKST_WKUP[16] ST_IO_CHAIN). This status bit must be cleared by
> software when the bit is read to 1".
>
> The original code was polling on a wrong register which is fixed in this patch.
> Also omap3_enable_io_chain is made non static as it's going to be used in
> subsequent patches.
>
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
A fix for this was posted[1] by Mohan V (added to Cc) back in June. It
recieved a few minor comments but an updated version was never posted.
Maybe you can ping Mohan or update that version fixing the comments
mentioned in that thread.
Thanks,
Kevin
[1] http://marc.info/?l=linux-omap&w=2&r=1&s=%27Mohan+V%27&q=b
next prev parent reply other threads:[~2011-10-04 20:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 17:52 [PATCH 0/4] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux Vishwanath BS
2011-10-04 17:52 ` Vishwanath BS
2011-10-04 17:52 ` [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence Vishwanath BS
2011-10-04 17:52 ` Vishwanath BS
2011-10-04 18:54 ` Tony Lindgren
2011-10-04 18:54 ` Tony Lindgren
2011-10-04 20:47 ` Kevin Hilman [this message]
2011-10-04 20:47 ` Kevin Hilman
2011-10-05 4:19 ` Vishwanath Sripathy
2011-10-05 4:19 ` Vishwanath Sripathy
2011-10-07 8:19 ` Paul Walmsley
2011-10-07 8:19 ` Paul Walmsley
2011-10-07 10:04 ` Vishwanath Sripathy
2011-10-07 10:04 ` Vishwanath Sripathy
2011-10-04 17:52 ` [PATCH 2/4] ARM: OMAP4 PM: Add IO Daisychain support Vishwanath BS
2011-10-04 17:52 ` Vishwanath BS
2011-10-07 8:13 ` Paul Walmsley
2011-10-07 8:13 ` Paul Walmsley
2011-10-07 10:03 ` Vishwanath Sripathy
2011-10-07 10:03 ` Vishwanath Sripathy
2011-10-04 17:52 ` [PATCH 3/4] ARM: OMAP3 PM: Enable IO Wake up Vishwanath BS
2011-10-04 17:52 ` Vishwanath BS
2011-10-04 17:52 ` [PATCH 4/4] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux Vishwanath BS
2011-10-04 17:52 ` Vishwanath BS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r52s8owb.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mohanv@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.