From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 2/7] OMAP: PM: omap_device: add few quick access functions Date: Wed, 31 Aug 2011 15:23:24 -0700 Message-ID: <87r5418bkz.fsf@ti.com> References: <1314026347-21623-1-git-send-email-b-cousson@ti.com> <1314026347-21623-3-git-send-email-b-cousson@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog107.obsmtp.com ([74.125.149.197]:40035 "EHLO na3sys009aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756714Ab1HaWX2 (ORCPT ); Wed, 31 Aug 2011 18:23:28 -0400 Received: by mail-yw0-f43.google.com with SMTP id 3so1343509ywm.16 for ; Wed, 31 Aug 2011 15:23:27 -0700 (PDT) In-Reply-To: <1314026347-21623-3-git-send-email-b-cousson@ti.com> (Benoit Cousson's message of "Mon, 22 Aug 2011 17:19:02 +0200") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Benoit Cousson Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, paul@pwsan.com, Nishanth Menon Benoit Cousson writes: > From: Nishanth Menon > > Provide a quick set of access functions: > a) Convert omap_device to platform_device - This is the flip of > to_omap_device for equivalent usage > b) Convert omap_device to device pointer - This is useful for > most devices that need to go through standard linux functions that > take device pointer. > c) Convert hwmod to device pointer - This wrapper provides ability for > drivers to convert directly from hwmod name back to device pointer > without having to handle this on a driver by driver basis > > Signed-off-by: Nishanth Menon > [b-cousson@ti.com: Adapt it to the new pdev pointer inside od] > Signed-off-by: Benoit Cousson > --- > arch/arm/plat-omap/include/plat/omap_device.h | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-omap/include/plat/omap_device.h b/arch/arm/plat-omap/include/plat/omap_device.h > index bdc2804..903f329 100644 > --- a/arch/arm/plat-omap/include/plat/omap_device.h > +++ b/arch/arm/plat-omap/include/plat/omap_device.h > @@ -152,6 +152,21 @@ static inline struct omap_device *to_omap_device(struct platform_device *pdev) > return pdev ? pdev->archdata.od : NULL; > } > > +/* Convert omap_device to platform device pointer */ > +#define omap_device_get_pdev(x) ((x)->pdev) > +/* Convert omap_device to device pointer */ > +#define omap_device_get_dev(x) (&omap_device_get_pdev(x)->dev) I don't see these used elsewhere, and I don't think they're needed... > +/* Convert omap_hwmod name to device pointer */ > +static inline struct device *omap_hwmod_name_get_dev(const char *oh_name) > +{ > + struct omap_device *od; > + od = omap_hwmod_name_get_odev(oh_name); > + if (IS_ERR_OR_NULL(od)) > + return ERR_PTR(od ? PTR_ERR(od) : -ENODEV); > + return omap_device_get_dev(od); > +} > + After comments on patch 1 are addressed, the pdev = omap_hwmod_name_get_pdev(oh_name) return &pdev->dev; Kevin > static inline > void omap_device_disable_idle_on_suspend(struct platform_device *pdev) > { From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Wed, 31 Aug 2011 15:23:24 -0700 Subject: [PATCH 2/7] OMAP: PM: omap_device: add few quick access functions In-Reply-To: <1314026347-21623-3-git-send-email-b-cousson@ti.com> (Benoit Cousson's message of "Mon, 22 Aug 2011 17:19:02 +0200") References: <1314026347-21623-1-git-send-email-b-cousson@ti.com> <1314026347-21623-3-git-send-email-b-cousson@ti.com> Message-ID: <87r5418bkz.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Benoit Cousson writes: > From: Nishanth Menon > > Provide a quick set of access functions: > a) Convert omap_device to platform_device - This is the flip of > to_omap_device for equivalent usage > b) Convert omap_device to device pointer - This is useful for > most devices that need to go through standard linux functions that > take device pointer. > c) Convert hwmod to device pointer - This wrapper provides ability for > drivers to convert directly from hwmod name back to device pointer > without having to handle this on a driver by driver basis > > Signed-off-by: Nishanth Menon > [b-cousson at ti.com: Adapt it to the new pdev pointer inside od] > Signed-off-by: Benoit Cousson > --- > arch/arm/plat-omap/include/plat/omap_device.h | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-omap/include/plat/omap_device.h b/arch/arm/plat-omap/include/plat/omap_device.h > index bdc2804..903f329 100644 > --- a/arch/arm/plat-omap/include/plat/omap_device.h > +++ b/arch/arm/plat-omap/include/plat/omap_device.h > @@ -152,6 +152,21 @@ static inline struct omap_device *to_omap_device(struct platform_device *pdev) > return pdev ? pdev->archdata.od : NULL; > } > > +/* Convert omap_device to platform device pointer */ > +#define omap_device_get_pdev(x) ((x)->pdev) > +/* Convert omap_device to device pointer */ > +#define omap_device_get_dev(x) (&omap_device_get_pdev(x)->dev) I don't see these used elsewhere, and I don't think they're needed... > +/* Convert omap_hwmod name to device pointer */ > +static inline struct device *omap_hwmod_name_get_dev(const char *oh_name) > +{ > + struct omap_device *od; > + od = omap_hwmod_name_get_odev(oh_name); > + if (IS_ERR_OR_NULL(od)) > + return ERR_PTR(od ? PTR_ERR(od) : -ENODEV); > + return omap_device_get_dev(od); > +} > + After comments on patch 1 are addressed, the pdev = omap_hwmod_name_get_pdev(oh_name) return &pdev->dev; Kevin > static inline > void omap_device_disable_idle_on_suspend(struct platform_device *pdev) > {