From: "Bjørn Mork" <bjorn@mork.no>
To: Brian Haley <brian.haley@hp.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Disable router anycast address for /127 prefixes
Date: Sat, 02 Jul 2011 11:38:19 +0200 [thread overview]
Message-ID: <87r569rpis.fsf@nemi.mork.no> (raw)
In-Reply-To: <4E0E1B85.1080906@hp.com> (Brian Haley's message of "Fri, 01 Jul 2011 15:09:57 -0400")
Brian Haley <brian.haley@hp.com> writes:
> On 07/01/2011 02:26 PM, Bjørn Mork wrote:
>> Brian Haley <brian.haley@hp.com> writes:
>>
>>> I'm not sure you'd need this part as there shouldn't be a /127 in the list to remove.
>>
>> I don't understand exactly what you mean here....
>
> If you never add an anycast address when the prefix length is 127, the address
> wouldn't be there when you went to remove it. In other words, the call to
> __ipv6_dev_ac_dec() would return -ENOENT, which is ignored anyways.
Doh! Of course. Sorry for being that slow...
And thanks for taking the time to feed it to me with a small enough
spoon :-)
> It's not a common codepath so the two lines of code wouldn't hurt anything
> I guess...
Personally I prefer "symmetric" coding because it leaves fewer questions
unanswered (necessary for the slow among us, as demonstrated above).
But I think that's for those actually maintaining this code to decide.
I can post an updated patch if required, or feel free to apply only the
first hunk.
Bjørn
next prev parent reply other threads:[~2011-07-02 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 17:47 IPv6 /127 address Stephen Hemminger
2011-07-01 11:22 ` [PATCH] Disable router anycast address for /127 prefixes Bjørn Mork
2011-07-01 14:45 ` Brian Haley
2011-07-01 18:26 ` Bjørn Mork
2011-07-01 19:09 ` Brian Haley
2011-07-02 9:38 ` Bjørn Mork [this message]
2011-07-06 9:04 ` [PATCH v2] " Bjørn Mork
2011-07-07 11:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r569rpis.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=brian.haley@hp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.