From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 04/10] omap: Make a subset of dmtimer functions into inline functions Date: Tue, 29 Mar 2011 11:01:23 -0700 Message-ID: <87r59px0uk.fsf@ti.com> References: <20110328221501.4046.41079.stgit@baageli.muru.com> <20110328222137.4046.32363.stgit@baageli.muru.com> <87y63xx1b9.fsf@ti.com> <20110329175839.GN4016@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:39221 "EHLO na3sys009aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753920Ab1C2SB0 (ORCPT ); Tue, 29 Mar 2011 14:01:26 -0400 Received: by mail-iy0-f174.google.com with SMTP id 14so384630iyb.19 for ; Tue, 29 Mar 2011 11:01:25 -0700 (PDT) In-Reply-To: <20110329175839.GN4016@atomide.com> (Tony Lindgren's message of "Tue, 29 Mar 2011 10:58:39 -0700") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Tony Lindgren writes: > * Kevin Hilman [110329 10:48]: >> >> The reset code is an example of something that will not be able to be >> shared between a system timer driver and a real device driver. In the >> real driver, the reset (as well as smart-idle, autoidle, wakeup >> capability, etc.) will all be handled by the hwmod. >> >> With a hwmod conversion, the system timer will have to have >> duplicate/alternate compared to the real timer. > > Well the hwmod is already there also for system timer, so that should > not be a problem. See the init_one function in the next patch in the > series. OK, I see that now. Guess I should get through the whole series before responding. So Tarun's series should convert then convert the reset to using the equivalent hwmod functions. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Tue, 29 Mar 2011 11:01:23 -0700 Subject: [PATCH 04/10] omap: Make a subset of dmtimer functions into inline functions In-Reply-To: <20110329175839.GN4016@atomide.com> (Tony Lindgren's message of "Tue, 29 Mar 2011 10:58:39 -0700") References: <20110328221501.4046.41079.stgit@baageli.muru.com> <20110328222137.4046.32363.stgit@baageli.muru.com> <87y63xx1b9.fsf@ti.com> <20110329175839.GN4016@atomide.com> Message-ID: <87r59px0uk.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Tony Lindgren writes: > * Kevin Hilman [110329 10:48]: >> >> The reset code is an example of something that will not be able to be >> shared between a system timer driver and a real device driver. In the >> real driver, the reset (as well as smart-idle, autoidle, wakeup >> capability, etc.) will all be handled by the hwmod. >> >> With a hwmod conversion, the system timer will have to have >> duplicate/alternate compared to the real timer. > > Well the hwmod is already there also for system timer, so that should > not be a problem. See the init_one function in the next patch in the > series. OK, I see that now. Guess I should get through the whole series before responding. So Tarun's series should convert then convert the reset to using the equivalent hwmod functions. Kevin