From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 12/17] omap4: pm-debug: Add wakeup timer and debug counters Date: Thu, 03 Mar 2011 09:05:51 -0800 Message-ID: <87r5aoqgls.fsf@ti.com> References: <1298112158-28469-1-git-send-email-santosh.shilimkar@ti.com> <1298112158-28469-13-git-send-email-santosh.shilimkar@ti.com> <87hbbl2l1y.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog105.obsmtp.com ([74.125.149.75]:35338 "EHLO na3sys009aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758221Ab1CCRFz (ORCPT ); Thu, 3 Mar 2011 12:05:55 -0500 Received: by mail-qw0-f44.google.com with SMTP id 6so1298273qwh.17 for ; Thu, 03 Mar 2011 09:05:54 -0800 (PST) In-Reply-To: (Santosh Shilimkar's message of "Thu, 3 Mar 2011 22:04:27 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Santosh Shilimkar writes: >> -----Original Message----- >> From: Kevin Hilman [mailto:khilman@ti.com] >> Sent: Thursday, March 03, 2011 4:21 AM >> To: Santosh Shilimkar >> Cc: linux-omap@vger.kernel.org; linux-arm-kernel@lists.infradead.org >> Subject: Re: [PATCH 12/17] omap4: pm-debug: Add wakeup timer and >> debug counters >> >> Santosh Shilimkar writes: >> >> > This patch adds configurable wakeup timer support in suspend. Also >> > for statistics pm counter support is added. >> > >> > Signed-off-by: Santosh Shilimkar >> > Reviewed-by: Kevin Hilman >> > --- >> > arch/arm/mach-omap2/omap4-mpuss-lowpower.c | 8 ++++++++ >> > arch/arm/mach-omap2/pm-debug.c | 6 ++++-- >> > arch/arm/mach-omap2/pm44xx.c | 5 +++++ >> > 3 files changed, 17 insertions(+), 2 deletions(-) >> > >> > diff --git a/arch/arm/mach-omap2/omap4-mpuss-lowpower.c >> b/arch/arm/mach-omap2/omap4-mpuss-lowpower.c >> > index ab2e101..5e0141e 100644 >> > --- a/arch/arm/mach-omap2/omap4-mpuss-lowpower.c >> > +++ b/arch/arm/mach-omap2/omap4-mpuss-lowpower.c >> > @@ -287,6 +287,10 @@ int omap4_enter_lowpower(unsigned int cpu, >> unsigned int power_state) >> > if (cpu) >> > goto cpu_prepare; >> > >> > +#ifdef CONFIG_PM_DEBUG >> > + pwrdm_pre_transition(); >> > +#endif >> >> Why the #ifdef? >> > Because these stats updates are quite expensive > in low power code and for the production kernel > you don't need this extra penalty. OK, then please fix this in the powerdomain code (or header.) c.f. "#ifdefs are ugly" section of Documentation/SubmittingPatches Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Thu, 03 Mar 2011 09:05:51 -0800 Subject: [PATCH 12/17] omap4: pm-debug: Add wakeup timer and debug counters In-Reply-To: (Santosh Shilimkar's message of "Thu, 3 Mar 2011 22:04:27 +0530") References: <1298112158-28469-1-git-send-email-santosh.shilimkar@ti.com> <1298112158-28469-13-git-send-email-santosh.shilimkar@ti.com> <87hbbl2l1y.fsf@ti.com> Message-ID: <87r5aoqgls.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Santosh Shilimkar writes: >> -----Original Message----- >> From: Kevin Hilman [mailto:khilman at ti.com] >> Sent: Thursday, March 03, 2011 4:21 AM >> To: Santosh Shilimkar >> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org >> Subject: Re: [PATCH 12/17] omap4: pm-debug: Add wakeup timer and >> debug counters >> >> Santosh Shilimkar writes: >> >> > This patch adds configurable wakeup timer support in suspend. Also >> > for statistics pm counter support is added. >> > >> > Signed-off-by: Santosh Shilimkar >> > Reviewed-by: Kevin Hilman >> > --- >> > arch/arm/mach-omap2/omap4-mpuss-lowpower.c | 8 ++++++++ >> > arch/arm/mach-omap2/pm-debug.c | 6 ++++-- >> > arch/arm/mach-omap2/pm44xx.c | 5 +++++ >> > 3 files changed, 17 insertions(+), 2 deletions(-) >> > >> > diff --git a/arch/arm/mach-omap2/omap4-mpuss-lowpower.c >> b/arch/arm/mach-omap2/omap4-mpuss-lowpower.c >> > index ab2e101..5e0141e 100644 >> > --- a/arch/arm/mach-omap2/omap4-mpuss-lowpower.c >> > +++ b/arch/arm/mach-omap2/omap4-mpuss-lowpower.c >> > @@ -287,6 +287,10 @@ int omap4_enter_lowpower(unsigned int cpu, >> unsigned int power_state) >> > if (cpu) >> > goto cpu_prepare; >> > >> > +#ifdef CONFIG_PM_DEBUG >> > + pwrdm_pre_transition(); >> > +#endif >> >> Why the #ifdef? >> > Because these stats updates are quite expensive > in low power code and for the production kernel > you don't need this extra penalty. OK, then please fix this in the powerdomain code (or header.) c.f. "#ifdefs are ugly" section of Documentation/SubmittingPatches Kevin