All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] C/R: Basic support for network namespaces and devices (v2)
Date: Sat, 23 Jan 2010 07:19:29 -0800	[thread overview]
Message-ID: <87r5pghmri.fsf@caffeine.danplanet.com> (raw)
In-Reply-To: <20100123.012537.99190542.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> (David Miller's message of "Sat\, 23 Jan 2010 01\:25\:37 -0800 \(PST\)")

DM> This is gross.  You can't do things this way.

Okay, fair enough.

DM> This misdesign is also why you find a need to get at the RTNL link
DM> ops too.  You have no infrastructure for doing what you need to do
DM> generically, so instead you are forced to directly call into
DM> drivers and export RTNL internals needlessly.

Stepping back, RTNL itself seems like the proper generic interface.
Would you agree?  At first, it seemed overkill to pack the information
into message buffers just to have the rest of RTNL unpack them, which
is why I mis-did what I did.  I think you've make it clear that that
overhead is worth the reuse.  Would that be more palatable?

Thanks!

-- 
Dan Smith
IBM Linux Technology Center
email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org

      parent reply	other threads:[~2010-01-23 15:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 21:09 C/R: Network namespace and device support (v2) Dan Smith
2010-01-22 21:09 ` [PATCH 1/3] Expose rtnl_link_ops_get() Dan Smith
2010-01-22 21:09 ` [PATCH 2/3] Add a veth_get_peer() and veth_set_peer() functions Dan Smith
2010-01-22 21:09 ` [PATCH 3/3] C/R: Basic support for network namespaces and devices (v2) Dan Smith
2010-01-23  9:25   ` David Miller
     [not found]     ` <20100123.012537.99190542.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-01-23 15:19       ` Dan Smith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r5pghmri.fsf@caffeine.danplanet.com \
    --to=danms-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.