From: Kevin Hilman <khilman@deeprootsystems.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org,
Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Subject: Re: [PATCH] OMAP3: PM: introduce a new powerdomain walk helper
Date: Mon, 05 Oct 2009 09:46:52 -0700 [thread overview]
Message-ID: <87r5th23gj.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4AC9D5F1.8080400@gmail.com> (Artem Bityutskiy's message of "Mon\, 05 Oct 2009 14\:18\:09 +0300")
Artem Bityutskiy <dedekind1@gmail.com> writes:
> On 10/01/2009 10:01 AM, Artem Bityutskiy wrote:
>> From: Artem Bityutskiy<Artem.Bityutskiy@nokia.com>
>>
>> The 'pwrdm_for_each()' function walks powerdomains with a spinlock
>> locked, so the the callbacks cannot do anything which may sleep.
>> This patch introduces a 'pwrdm_for_each_nolock()' helper which does
>> the same, but without the spinlock locked. This fixes the following
>> lockdep warning:
>>
>> [ 0.000000] WARNING: at kernel/lockdep.c:2460 lockdep_trace_alloc+0xac/0xec()
>> [ 0.000000] Modules linked in:
>> (unwind_backtrace+0x0/0xdc) from [<c0045464>] (warn_slowpath_common+0x48/0x60)
>> (warn_slowpath_common+0x48/0x60) from [<c0067dd4>] (lockdep_trace_alloc+0xac/0xec)
>> (lockdep_trace_alloc+0xac/0xec) from [<c009da14>] (kmem_cache_alloc+0x1c/0xd0)
>> (kmem_cache_alloc+0x1c/0xd0) from [<c00b21d8>] (d_alloc+0x1c/0x1a4)
>> (d_alloc+0x1c/0x1a4) from [<c00a887c>] (__lookup_hash+0xd8/0x118)
>> (__lookup_hash+0xd8/0x118) from [<c00a9f20>] (lookup_one_len+0x84/0x94)
>> (lookup_one_len+0x84/0x94) from [<c010d12c>] (debugfs_create_file+0x8c/0x20c)
>> (debugfs_create_file+0x8c/0x20c) from [<c010d320>] (debugfs_create_dir+0x1c/0x20)
>> (debugfs_create_dir+0x1c/0x20) from [<c000e8cc>] (pwrdms_setup+0x60/0x90)
>> (pwrdms_setup+0x60/0x90) from [<c002e010>] (pwrdm_for_each+0x30/0x80)
>> (pwrdm_for_each+0x30/0x80) from [<c000e79c>] (pm_dbg_init+0x7c/0x14c)
>> (pm_dbg_init+0x7c/0x14c) from [<c00232b4>] (do_one_initcall+0x5c/0x1b8)
>> (do_one_initcall+0x5c/0x1b8) from [<c00083f8>] (kernel_init+0x90/0x10c)
>> (kernel_init+0x90/0x10c) from [<c00242c4>] (kernel_thread_exit+0x0/0x8)
>>
>> Signed-off-by: Artem Bityutskiy<Artem.Bityutskiy@nokia.com>
>
> I guess this patch was actually for Tony, as this warning is seen on l-o.
> Tony, any plans to pick this up?
Actually, I'll queue this in my PM fixes queue for the -rc series.
Kevin
prev parent reply other threads:[~2009-10-05 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 7:01 [PATCH] OMAP3: PM: introduce a new powerdomain walk helper Artem Bityutskiy
2009-10-05 11:18 ` Artem Bityutskiy
2009-10-05 16:46 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5th23gj.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=dedekind1@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.