From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Smith Subject: Re: [PATCH] Add AF_INET c/r support Date: Wed, 01 Jul 2009 09:11:02 -0700 Message-ID: <87r5x0xu21.fsf@caffeine.danplanet.com> References: <1245697976-29159-1-git-send-email-danms@us.ibm.com> <20090626220906.GF17502@count0.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090626220906.GF17502-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org> (Matt Helsley's message of "Fri\, 26 Jun 2009 15\:09\:06 -0700") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Matt Helsley Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, Alexey Dobriyan List-Id: containers.vger.kernel.org MH> Nano-nit: I think it's easier to read if we call these MH> CKPT_HDR_SOCKET_UNIX and CKPT_HDR_SOCKET_INET. The extra 2 MH> characters are worth that. This also applies to the struct names MH> later in the patch. Okay. The prefixes 'un' and 'in' are used in a lot of other places in the API, but I suppose it's better to spell it out. -- Dan Smith IBM Linux Technology Center email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org