From: Kalle Valo <kalle.valo@nokia.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/2] mac80211: enable IEEE80211_CONF_PS only when associated
Date: Mon, 10 Nov 2008 11:36:06 +0200 [thread overview]
Message-ID: <87r65jzzw9.fsf@nokia.com> (raw)
In-Reply-To: <1226309301.4004.8.camel@johannes.berg> (ext Johannes Berg's message of "Mon\, 10 Nov 2008 10\:28\:21 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Sun, 2008-11-09 at 17:43 +0200, Kalle Valo wrote:
>
>
>> @@ -865,8 +870,14 @@ static void ieee80211_set_disassoc(struct ieee80211_sub_if_data *sdata,
>> sta_info_destroy(sta);
>>
>> local->hw.conf.ht.enabled = false;
>> - ieee80211_hw_config(local, IEEE80211_CONF_CHANGE_HT);
>> + config_changed |= IEEE80211_CONF_CHANGE_HT;
>> +
>> + if (local->hw.conf.flags & IEEE80211_CONF_PS) {
>> + local->hw.conf.flags &= ~IEEE80211_CONF_PS;
>> + config_changed |= IEEE80211_CONF_PS;
>> + }
>
> That latter flag should be CONF_CHANGED_PS.
Oops, I'll fix it. Thanks for finding this.
--
Kalle Valo
next prev parent reply other threads:[~2008-11-10 9:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-09 15:43 [RFC] mac80211 dynamic powersave Kalle Valo
2008-11-09 15:43 ` [RFC 1/2] mac80211: enable IEEE80211_CONF_PS only when associated Kalle Valo
2008-11-10 9:28 ` Johannes Berg
2008-11-10 9:36 ` Kalle Valo [this message]
2008-11-09 15:43 ` [RFC 2/2] mac80211: implement dynamic power save Kalle Valo
2008-11-10 9:36 ` Johannes Berg
2008-11-10 9:49 ` Kalle Valo
2008-11-10 9:53 ` Johannes Berg
2008-11-10 20:14 ` Luis R. Rodriguez
2008-11-11 7:14 ` Kalle Valo
2008-11-11 10:18 ` Vivek Natarajan
2008-11-11 13:09 ` Kalle Valo
2008-11-11 16:40 ` Nick Kossifidis
2008-11-11 4:32 ` [RFC] mac80211 dynamic powersave Vivek Natarajan
2008-11-11 10:38 ` Johannes Berg
2008-11-12 6:17 ` Vivek Natarajan
2008-11-12 17:33 ` Luis R. Rodriguez
[not found] ` <8e92b4100811102018q4a13568l625abf2c59dca253@mail.gmail.com>
2008-11-11 12:29 ` Kalle Valo
2008-11-11 12:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r65jzzw9.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.