All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Fix matchbox build
Date: Mon, 27 Oct 2008 16:15:09 +0100	[thread overview]
Message-ID: <87r662jchu.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20081027155540.61552c7d@surf> (Thomas Petazzoni's message of "Mon\, 27 Oct 2008 15\:55\:40 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 Thomas>  * libmatchbox and matchbox-panel were using a now legacy index()
 Thomas>    function, which is not part of every uClibc build nowadays
 Thomas>    (depending on the configuration). As this function doesn't exist
 Thomas>    anymore in all builds, use strchr() instead, which is the
 Thomas>    recommended replacement for index(). Two patches, one for
 Thomas>    libmatchbox, one for matchbox-panel, are added to fix this problem.

 Thomas>    Closes bug http://bugs.uclibc.org/view.php?id=5484

Thanks! I had a quick look at it as well, but hadn't gotten around to
do it yet.

Don't forget to send to patches upstream.

 Thomas>  * Do not override the CFLAGS and LDFLAGS values, they are already set
 Thomas>    by TARGET_CONFIGURE_OPTS. It caused build failures.

 Thomas>  * Mangle the library paths in the .la file of libmatchbox, after
 Thomas>    installation in the staging dir.

 Thomas> It would probably be nice to switch Matchbox over to the new
 Thomas> Makefile.autotools.in.

Exactly. It seems pretty standard auto*.

Committed.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2008-10-27 15:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-27 14:55 [Buildroot] [PATCH] Fix matchbox build Thomas Petazzoni
2008-10-27 15:15 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r662jchu.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.