Re: [PATCH 00/16] OMAP3: Context save/Restore + OFF mode support

[Kevin Hilman <khilman@deeprootsystems.com>]

"Rajendra Nayak" <rnayak@ti.com> writes:

> This patch set adds context save/restore routines for minimal kernel and OFF mode
> support in idle and suspend. This patch set applies on top of pm-1 branch.
>
> This has context save/restore support implemented for the following modules
> GPMC, UART, GPIO, I2C, PRCM, INTC, SCM, SRAM. 
>
> A sysfs knob to dynamically control OFF mode is provided at 
> /sys/power/enable_off_mode. This is set to 0 (disabled) by default.
>

Hi Rajendra,

This series is in much better shape, and allows me to hit retention or
OFF in idle and suspend.  Thanks!

I will pull this series into pm-1 tomorrow.  There are few minor
things that I will cleanup upon merging.

- common:
  - in several new functions, no space between local variable
    definition and start of code
  - copyright 2007 additions.  Shouldn't these be 2008?

- 6/16: INTC
  - remove the comment MIRs being saved with PRCM since this is no longer true

- 11/16: PER/NEON
  - checkpatch warnings

- 15/16: /sys/power/enable_off_mode
  - your method doesn't quite work, I have an alternative

- 14/16: CORE off
  - checkpatch errors and warnings

Thanks,

Kevin