From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KUN2x-0006pr-5Q for mharc-grub-devel@gnu.org; Sat, 16 Aug 2008 10:46:27 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KUN2v-0006ph-7T for grub-devel@gnu.org; Sat, 16 Aug 2008 10:46:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KUN2t-0006p6-Fb for grub-devel@gnu.org; Sat, 16 Aug 2008 10:46:24 -0400 Received: from [199.232.76.173] (port=40608 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KUN2t-0006p3-AM for grub-devel@gnu.org; Sat, 16 Aug 2008 10:46:23 -0400 Received: from smtp-vbr15.xs4all.nl ([194.109.24.35]:1211) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KUN2s-00063F-OR for grub-devel@gnu.org; Sat, 16 Aug 2008 10:46:23 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr15.xs4all.nl (8.13.8/8.13.8) with ESMTP id m7GEkIdp081858 for ; Sat, 16 Aug 2008 16:46:19 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080811152238.GA23380@thorin> <48A05D25.6040209@nic.fi> <20080811212418.GC6883@thorin> <20080811220723.GA22204@thorin> <20080812132515.GA13942@thorin> <20080812162915.GA8518@thorin> <20080812223815.GA3141@thorin> <20080812234430.GA12880@thorin> <87skt8245g.fsf@xs4all.nl> <20080813195109.GA22009@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Sat, 16 Aug 2008 16:50:17 +0200 In-Reply-To: <20080813195109.GA22009@thorin> (Robert Millan's message of "Wed, 13 Aug 2008 21:51:09 +0200") Message-ID: <87r68p10ba.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Aug 2008 14:46:25 -0000 Robert Millan writes: > On Wed, Aug 13, 2008 at 07:52:59PM +0200, Marco Gerards wrote: >> > #include >> > #include >> > +#include /* For struct grub_mmap_entry, which is also >> > + needed by Multiboot. */ >> >> Isn't it better to split the header file? This seems like a hack. > > The definition is part of the Multiboot spec, so it really needs to be present > in multiboot.h. > > We could also define it separately as grub_mmap_entry in multiboot.h and keep > the grub_machine_mmap_entry definition in pc/init.h. Then other arches could > have their own grub_machine_mmap_entry variant which _does_ differ from > grub_mmap_entry (like coreboot). > > What do you think? This sounds fine to me. >> > Index: loader/i386/pc/multiboot.c >> > =================================================================== >> > --- loader/i386/pc/multiboot.c (revision 1802) >> > +++ loader/i386/pc/multiboot.c (working copy) >> > @@ -78,14 +78,60 @@ >> > grub_free ((void *) mbi->cmdline); >> > grub_free (mbi); >> > } >> > - >> > - >> > + >> >> Hm? :-) > > Some minor janitor work ;-) :-) -- Marco