From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQKik-0007Iu-TE for mharc-grub-devel@gnu.org; Tue, 05 Aug 2008 07:28:54 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQKij-0007G2-3h for grub-devel@gnu.org; Tue, 05 Aug 2008 07:28:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQKih-0007EN-QQ for grub-devel@gnu.org; Tue, 05 Aug 2008 07:28:52 -0400 Received: from [199.232.76.173] (port=54412 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQKih-0007E4-4j for grub-devel@gnu.org; Tue, 05 Aug 2008 07:28:51 -0400 Received: from smtp-vbr9.xs4all.nl ([194.109.24.29]:4374) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQKig-0002K0-BN for grub-devel@gnu.org; Tue, 05 Aug 2008 07:28:50 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr9.xs4all.nl (8.13.8/8.13.8) with ESMTP id m75BSnMd069875 for ; Tue, 5 Aug 2008 13:28:49 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1215137528.26019.58.camel@localhost> <87bq0sibu0.fsf@xs4all.nl> <1216601741.8334.122.camel@localhost> <877ib1khe9.fsf@xs4all.nl> <1217806150.9634.24.camel@localhost> <87iqug33m9.fsf@xs4all.nl> <1217891426.15145.38.camel@localhost> <4897A3DC.4050705@isaac.cedarswampstudios.org> <1217903880.5754.14.camel@localhost> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 05 Aug 2008 13:31:28 +0200 In-Reply-To: <1217903880.5754.14.camel@localhost> (Javier =?iso-8859-1?Q?M?= =?iso-8859-1?Q?art=EDn's?= message of "Tue, 05 Aug 2008 04:38:00 +0200") Message-ID: <87r693em0f.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Drivemap module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 11:28:53 -0000 Hi, Javier Mart=C3=ADn writes: >> Anyway, since "they" are more likely to maintain the code in=20 >> the long run than you, in general, the question is whether=20 >> the code is more likely to become buggy by their hacking on=20 >> it, if it follows project coding style or someone else's=20 >> (your) "safer" coding style. Likely it's safer if using a=20 >> consistent programming style. Although I personally don't=20 >> see that it's very helpful to have a style that makes things=20 >> down to the order of "=3D=3D" arguments be consistent within the=20 >> project; haphazard only slows reading the tiniest bit, and I=20 >> don't think it makes a different what order the arguments are... > =EF=BB=BF > Hmm... I was partially expecting a flamefest to start. Pity ^^ > Well, let's spill a little napalm: the GNU style bracing is extremely > silly!! Why the hell are the "if" and "else" blocks indented differently > in this example? > if (condition) > return 0; > else > { > return -1; > } > Nah, I'm not really bringing that issue, I was just joking, and in fact > I'm reconsidering my objections to the operator=3D=3D arguments order rul= e, > even though I still consider my style safer and more sensible. If > someone else wants to express their opinion on that issue, do it fast > before I completely submit to Master Marco's will :D Please don't be sarcastic, start flame wars or call names. It will not help anyone. -- Marco