From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KOeO6-0000dC-EI for mharc-grub-devel@gnu.org; Thu, 31 Jul 2008 16:04:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOeO5-0000bW-Au for grub-devel@gnu.org; Thu, 31 Jul 2008 16:04:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOeO0-0000VW-IX for grub-devel@gnu.org; Thu, 31 Jul 2008 16:04:36 -0400 Received: from [199.232.76.173] (port=43956 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOeO0-0000VA-93 for grub-devel@gnu.org; Thu, 31 Jul 2008 16:04:32 -0400 Received: from smtp-vbr10.xs4all.nl ([194.109.24.30]:1754) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KOeNz-0007K6-Ro for grub-devel@gnu.org; Thu, 31 Jul 2008 16:04:32 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr10.xs4all.nl (8.13.8/8.13.8) with ESMTP id m6VK4R8c036745 for ; Thu, 31 Jul 2008 22:04:29 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080727212509.GA24358@thorin> <87vdylj202.fsf@xs4all.nl> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 31 Jul 2008 22:06:36 +0200 In-Reply-To: (bean123ch@gmail.com's message of "Fri, 1 Aug 2008 03:20:12 +0800") Message-ID: <87r699izsj.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] buffered file read X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jul 2008 20:04:37 -0000 Bean writes: > On Fri, Aug 1, 2008 at 3:18 AM, Marco Gerards wrote: >> Hi Bean, >> >> Bean writes: >> >>> I have added a buffer length parameter to grub_buffile_open: >>> >>> grub_file_t grub_buffile_open (const char *name, int size); >>> >>> size < 0: Load the whole file. >>> size = 0: Use default buffer size (8192 bytes) >>> size > 0: Custom buffer size = size >>> >>> The upper limit is 1m, if size > 1m, we set it to 1m. >>> >>> 2008-07-28 Bean >>> >>> * conf/common.rmk (pkglib_MODULES): Add bufio.mod. >>> (bufio_mod_SOURCES): New macro. >>> (bufio_mod_CFLAGS): Likewise. >>> (bufio_mod_LDFLAGS): Likewise. >>> >>> * include/grub/bufio.h: New file. >>> >>> * io/bufio.c: Likewise. >>> >>> * video/png.c (grub_video_reader_png): Use grub_buffile_open to open >>> file. >>> >>> * video/jpeg.c (grub_video_reader_jpeg): Likewise. >>> >>> * video/tga.c (grub_video_reader_tga): Likewise. >>> >>> * font/manager.c (add_font): Likewise. >> >> Please mention it when you include . The same >> for when you remove . >> >> Otherwise it seems good for inclusion :-) > > Hi, > > Oh, how the changelog would be like ? Specifically or generally? Generally something like: * fs/foo.c: Include . (baz): New function. .... -- Marco