From: Johannes Weiner <hannes@saeurebad.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: 42c9c06bec x86: ACPI: use ioremap_early() instead of __va()/__pa()
Date: Fri, 18 Jan 2008 17:45:12 +0100 [thread overview]
Message-ID: <87r6gft753.fsf@saeurebad.de> (raw)
Hi Ingo,
with the commit
42c9c06bec2f48002d5b6573c8700461120070a9
x86: ACPI: use ioremap_early() instead of __va()/__pa()
you made __acpi_map_table(), which is non-__init, call early_ioremap()
which is __init on 64bit (init_64.c) but non-__init on 32bit
(ioremap_32.c). This results in section mismatches on 32bit.
The version I have here is v2.6.24-rc8-725-g0f80375.
I had a look into ioremap_32.c and as it seems no __init function should
be called at all in the callpath down from early_ioremap() after the
__init sections are tossed out; but it is decided during runtime with
the check of after_paging_init and so the illegal references still
exist.
What is the solution here? I have not a real clue of the code, but
perhaps we can make early_ioremap REALLY __init only and use something
different from non-init code?
Hannes
reply other threads:[~2008-01-18 16:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r6gft753.fsf@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.