From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1GSw1g-0005hr-MG for mharc-grub-devel@gnu.org; Thu, 28 Sep 2006 09:34:08 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GSw1e-0005hj-S5 for grub-devel@gnu.org; Thu, 28 Sep 2006 09:34:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GSw1c-0005hX-9u for grub-devel@gnu.org; Thu, 28 Sep 2006 09:34:05 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GSw1c-0005hU-59 for grub-devel@gnu.org; Thu, 28 Sep 2006 09:34:04 -0400 Received: from [194.109.24.30] (helo=smtp-vbr10.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GSw6h-0004jM-Nj for grub-devel@gnu.org; Thu, 28 Sep 2006 09:39:20 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr10.xs4all.nl (8.13.8/8.13.8) with ESMTP id k8SDY2wR075723 for ; Thu, 28 Sep 2006 15:34:03 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1159444090.451bb67a38fba@imp6-g19.free.fr> <877izo2ljd.fsf@xs4all.nl> <1159448688.451bc870e9851@imp1-g19.free.fr> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 28 Sep 2006 15:41:56 +0200 In-Reply-To: <1159448688.451bc870e9851@imp1-g19.free.fr> (tgingold@free.fr's message of "Thu, 28 Sep 2006 15:04:48 +0200") Message-ID: <87r6xw1523.fsf@xs4all.nl> User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner Subject: Re: patch for kern/efi/mm.c (big memmap) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2006 13:34:07 -0000 tgingold@free.fr writes: > This is on an ia64 system (Tiger). I just noticed that because of your other patches, neat! :-) >> Cool. Can you please send in this patch in unified diff format (diff >> -up) and provide a changelog entry? And while you on it, most people >> here prefer patches being sent inline so it is easier to read and to >> give feedback on. > Sorry, this is my first patch! Hopefully you didn't see my feedback as evil comments ;-). My reason to tell you all this is to get patches in the form we would like to see them for easy review and quick integration. > Tristan. > > 2006-09-28 Tristan Gingold > > * kern/efi/mm.c (grub_efi_mm_init): MEMORY_MAP_SIZE removed, > dynamically get the size of the memory map. Great. There are a few changes I will make before committing this patch. Please have a look at the commit email to see what was changed and why. I will most likely commit this patch Sunday evening, certainly not before that, sorry. -- Marco