From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Dl849-00053p-DB for mharc-grub-devel@gnu.org; Wed, 22 Jun 2005 12:27:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dl83z-0004zb-Hy for grub-devel@gnu.org; Wed, 22 Jun 2005 12:26:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dl83t-0004w8-Pl for grub-devel@gnu.org; Wed, 22 Jun 2005 12:26:50 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dl83s-0004tq-Lk for grub-devel@gnu.org; Wed, 22 Jun 2005 12:26:48 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dl84w-00075O-Ak for grub-devel@gnu.org; Wed, 22 Jun 2005 12:27:54 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 7571589C1 for ; Wed, 22 Jun 2005 18:24:41 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 09464-08 for ; Wed, 22 Jun 2005 17:28:16 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 1A3DB841A for ; Wed, 22 Jun 2005 18:24:38 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id D7CEDC047 for ; Wed, 22 Jun 2005 18:24:37 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050621231410.GA26213@miracle> <87ekauejnh.fsf@student.han.nl> <200506221730.42997.okuji@enbug.org> From: Marco Gerards Date: Wed, 22 Jun 2005 18:24:51 +0200 In-Reply-To: <200506221730.42997.okuji@enbug.org> (Yoshinori K. Okuji's message of "Wed, 22 Jun 2005 17:30:42 +0200") Message-ID: <87r7eucqb0.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [patch] printf long format X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2005 16:27:00 -0000 "Yoshinori K. Okuji" writes: > On Wednesday 22 June 2005 16:33, Hollis Blanchard wrote: >> You have made this comment a few times now. Please understand: I do >> watch out for this stuff, apparently more carefully than other >> committers. I am removing whitespace from an otherwise blank line. >> >> I am not saying I will never accidentally check in errant whitespace, >> but you can see that this is a correction, not an accident. > > Why does Marco complain about this? Because of the readability of a patch? In > this case, the option --ignore-space-change to diff would help you... Readability. Hollis prefers no whitespace on a line. I do not care about these spaces, but it is too much noise to either add or remove it. With --ignore-space-change you sometimes miss changes that were made on purpose. -- Marco