From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1D0ONe-0004ya-Iv for mharc-grub-devel@gnu.org; Sun, 13 Feb 2005 13:22:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D0ONU-0004tq-K0 for grub-devel@gnu.org; Sun, 13 Feb 2005 13:21:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D0ONK-0004q4-40 for grub-devel@gnu.org; Sun, 13 Feb 2005 13:21:43 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D0ONJ-0004mB-TP for grub-devel@gnu.org; Sun, 13 Feb 2005 13:21:41 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D0Nzn-0006Oe-CH for grub-devel@gnu.org; Sun, 13 Feb 2005 12:57:23 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id A9C4F8CB0 for ; Sun, 13 Feb 2005 18:52:49 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 02573-02 for ; Sun, 13 Feb 2005 18:52:47 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id AF67A8AB8 for ; Sun, 13 Feb 2005 18:52:47 +0100 (CET) Received: from marco.marco-g.com (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 80304C046 for ; Sun, 13 Feb 2005 18:52:47 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050213151851.GA4056@miracle> From: Marco Gerards Date: Sun, 13 Feb 2005 17:53:00 +0000 In-Reply-To: <20050213151851.GA4056@miracle> (Hollis Blanchard's message of "Sun, 13 Feb 2005 09:18:51 -0600") Message-ID: <87r7jktkhv.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [patch] configfile X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Feb 2005 18:21:57 -0000 Hollis Blanchard writes: > 2005-02-13 Hollis Blanchard > > * conf/i386-pc.rmk (pkgdata_MODULES): Add configfile.mod. > * conf/powerpc-ieee1275.rmk (pkgdata_MODULES): Likewise. > * commands/configfile.mod: New file. Could you please add it to grub-emu as well? > While working on setting prefix correctly, I found it useful to have the > `configfile' command like GRUB Legacy. Great! :) > --- /dev/null 2004-12-18 12:15:49.000000000 -0600 > +++ commands/configfile.c 2005-02-13 09:11:41.166390400 -0600 [...] > +static grub_err_t > +grub_cmd_configfile (struct grub_arg_list *state __attribute__ ((unused)), > + int argc, char **args) > + > +{ > + if (argc != 1) > + return grub_error (GRUB_ERR_BAD_ARGUMENT, "file name required"); > + > + grub_cls (); > + grub_normal_execute (args[0], 1); When this is called from normal mode, by running a command this means that another normal mode will be started again. If you run this command a few times, you would see a lot normal modes running when examining the stack, right? This is the main reason I have not implemented this command yet. To me it would seem better to update the data in the already running normal mode. Please correct me if I am wrong. Thanks, Marco