From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BvZhd-0002Gm-0Z for mharc-grub-devel@gnu.org; Fri, 13 Aug 2004 06:54:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BvZhb-0002Gh-Rf for grub-devel@gnu.org; Fri, 13 Aug 2004 06:54:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BvZha-0002GV-AF for grub-devel@gnu.org; Fri, 13 Aug 2004 06:54:27 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BvZha-0002GS-7J for grub-devel@gnu.org; Fri, 13 Aug 2004 06:54:26 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BvZdS-0007sW-QY for grub-devel@gnu.org; Fri, 13 Aug 2004 06:50:11 -0400 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id 4C0E78AF5 for ; Fri, 13 Aug 2004 12:40:42 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 31117-09 for ; Fri, 13 Aug 2004 12:40:40 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 742368A90 for ; Fri, 13 Aug 2004 12:40:40 +0200 (CEST) Received: from marco.marco-g.com (a82-92-27-129.adsl.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id D6C13C053 for ; Fri, 13 Aug 2004 11:40:42 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20040808173040.GA11531@artax.karlin.mff.cuni.cz> <87smaxldbe.fsf@marco.marco-g.com> <20040808181720.GA14939@artax.karlin.mff.cuni.cz> <200408082117.56911.okuji@enbug.org> <20040812222119.GA25312@artax.karlin.mff.cuni.cz> From: Marco Gerards Date: Fri, 13 Aug 2004 12:41:06 +0200 In-Reply-To: <20040812222119.GA25312@artax.karlin.mff.cuni.cz> (Tomas Ebenlendr's message of "Fri, 13 Aug 2004 00:21:19 +0200") Message-ID: <87r7qbmibh.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Subject: Re: bugfix, hostfs X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Aug 2004 10:54:28 -0000 ebik@artax.karlin.mff.cuni.cz (Tomas Ebenlendr) writes: >> This requires some changes in the cache manager, but not difficult. What >> do you think? > > Hmm, leaving this change for anybody who understand disks in grub. > Instead of it I use disk->name :-) . Better use an int. It is easier/cheaper to check and IMHO cleaner. > PS.: I'm changing conf/powerpc-ieee1275.rmk and I didn't test > compilability of my code on ppc. But it should be OS-dependent, but > not architecture dependent. Don't worry about that. This only changes stuff in util/, so no bad things will happen. BTW, I see you have added hostfs.c to fs/, I think util/ is a better place for this. > ########################################################################## > Changelog: > 2004-08-08 Tomas Ebenlendr > > * kern/dl.c (grub_dl_load_file): Fixed bug: When > grub_dl_load_core fails, mod shouldn't be derefered. Just leave "Fixed bug: " away. If Okuji says it is ok to commit, please change the date to the commit date. > + case ENOMEM: r = GRUB_ERR_OUT_OF_MEMORY; break; > + case ENOTDIR: > + case ENOENT: r = GRUB_ERR_FILE_NOT_FOUND; break; > + case ELOOP: r = GRUB_ERR_SYMLINK_LOOP; break; > + case EIO: r = GRUB_ERR_FILE_READ_ERROR; break; > + default: r = GRUB_ERR_BAD_ARGUMENT; break; I think I missed this last time. Better use multiple lines for a case statement. > + file->data = (void *) open(name, O_RDONLY); open ( > + return errno2err(); You missed a space here as well. > + return errno2err(); ... Thanks, Marco