From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Xenomai <xenomai@lists.linux.dev>
Subject: Re: [dovetail][PATCH] clocksource/bcm2835: irq_pipeline: set clockevent IRQ
Date: Wed, 18 Nov 2026 10:08:12 +0100 [thread overview]
Message-ID: <87se0yeccj.fsf@xenomai.org> (raw)
In-Reply-To: <5e3b4c9f-6f1b-4642-a923-6c33188e9cb1@siemens.com> (Jan Kiszka's message of "Tue, 17 Nov 2026 06:06:39 +0100")
Jan Kiszka <jan.kiszka@siemens.com> writes:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The bcm2835 system timer never filled clock_event_device::irq, so
> switching it oob and marking it as IRQ_TICK targeted IRQ 0 instead.
>
> Assisted-by: opencode:Opus-5.5
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> The AI comes with these piecewise, this time while actually reviewing a
> 6.12 branch for the 3rd or 4th time.
>
> drivers/clocksource/bcm2835_timer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/bcm2835_timer.c b/drivers/clocksource/bcm2835_timer.c
> index c3d5739da5ec4..73ae9b678decf 100644
> --- a/drivers/clocksource/bcm2835_timer.c
> +++ b/drivers/clocksource/bcm2835_timer.c
> @@ -125,6 +125,7 @@ static int __init bcm2835_timer_init(struct device_node *node)
> timer->evt.features = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PIPELINE;
> timer->evt.set_next_event = bcm2835_time_set_next_event;
> timer->evt.cpumask = cpumask_of(0);
> + timer->evt.irq = irq;
>
> ret = request_irq(irq, bcm2835_time_interrupt, IRQF_TIMER | IRQF_SHARED,
> node->name, timer);
Merged, thanks.
--
Philippe.
prev parent reply other threads:[~2026-11-18 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 5:06 [dovetail][PATCH] clocksource/bcm2835: irq_pipeline: set clockevent IRQ Jan Kiszka
2026-11-18 9:08 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87se0yeccj.fsf@xenomai.org \
--to=rpm@xenomai.org \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.