All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@suse.de>
To: Dongli Zhang <dongli.zhang@oracle.com>, Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, david@kernel.org, imammedo@redhat.com,
	maciej.szmigiero@oracle.com, mark.kanda@oracle.com,
	bchaney@akamai.com, pierrick.bouvier@oss.qualcomm.com,
	alex@shazbot.org, clg@redhat.com, yi.l.liu@intel.com,
	eric.auger@redhat.com, zhenzhong.duan@intel.com, mst@redhat.com,
	cohuck@redhat.com, pbonzini@redhat.com, armbru@redhat.com,
	eblake@redhat.com
Subject: Re: [PATCH 00/21] migration/cpr: introduce cpr-luo mode to support KHO/LUO
Date: Wed, 18 Nov 2026 15:32:35 -0300	[thread overview]
Message-ID: <87se0yq9bw.fsf@suse.de> (raw)
In-Reply-To: <fa74f48d-dfd2-4336-8ea2-a53d46004e72@oracle.com>

Dongli Zhang <dongli.zhang@oracle.com> writes:

> Hi Fabiano and Peter,
>
> On Tue, Nov 17, 2026 11:25:50AM -0800, Peter Xu wrote:
>> On Tue, Nov 17, 2026 at 04: 01: 45PM -0300, Fabiano Rosas wrote: > Sorry for the
>> delay, we're all swimming in slop these days. The only > feedback I have at the
>> moment is that this feature needs tests. What's > your plan in this regard?
>> 
>> On Tue, Nov 17, 2026 at 04:01:45PM -0300, Fabiano Rosas wrote:
>>> Sorry for the delay, we're all swimming in slop these days. The only
>>> feedback I have at the moment is that this feature needs tests. What's
>>> your plan in this regard? Can this run with nested virtualization? Or
>>> perhaps is there a way to mock the kernel interfaces and ensure QEMU
>>> does the right thing even without them? We don't need much, but the code
>>> definitely needs to be exercised somehow.
>
> Thank you very much for the response and suggestion. I will follow this to make
> the feature more robust.
>
> So far, the only way to test it is through kexec, which not only takes time but
> also isn't friendly to unit testing.
>
> Based on my understanding of LUO/KHO, with the latest mainline Linux kernel,
> once the fds are preserved, there is no way to retrieve them until after kexec.
>
> Therefore, perhaps we could implement the LUO API functions in QEMU through an
> ops interface.
>
> 1. The first idea is to implement an emulator so that the ops interface can
> support both the real API and a test API. The test API would talk to the
> emulator to emulate the preserve/retrieve procedure.
>

Where does that emulator sit exactly? Because the problem of
transfering state will be the same as in 2 below, no? Since QEMU source
needs to exit.

> 2. The second idea is to implement a set of test ops, with QEMU launched by a
> parent process. The source QEMU could preserve fds, and the target QEMU could
> retrieve them through the parent process.
>

Something like migration-test as the parent process sounds easy enough.

> 3. The third idea is to implement something in the kernel to emulate a quick
> switch between outgoing and incoming fds so that we can retrieve them
> immediately after preserving them.
>

Anything in-kernel would have to be part of a larger LUO testing
approach I think. Otherwise we waste effort. I don't suppose the kernel
side has any sort of selftests (or similar) for this?

What can we get from /dev/liveupdate in the host without having to
kexec? On a quick look, I see systemd has a test-luo program, I wonder
if they have a way to test outside of a VM.

One other aspect aside from the normal functioning of the feature is how
does QEMU behave when the host doesn't support LUO or the configuration
is not quite right. Although easy to fix, those issues tend to be
numerous when the support for a kernel feature is first implemented in
QEMU. A test that doesn't access the host at all might miss those.

> Options (1) and (2) seem better. While (2) looks easier to implement for quick
> unit testing, (1) would be better for testing with arbitrary devices and
> configurations in cpr-luo mode.
>

Let's understand a bit better what the options are, but we don't need to
do anything fancy, we can improve the testing as the work evolves.

> Thank you very much!
>
> Dongli Zhang
>
>> 
>> Apologize from my side too on being slow, I'm going to start reading mails
>> on the list this week, but it'll still be slow, together with other things.
>> Just to say, this one is on my review list.  Sorry again.
>> 
>> -- 
>> Peter Xu
>> 


  reply	other threads:[~2026-11-18 18:33 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 23:55 [PATCH 00/21] migration/cpr: introduce cpr-luo mode to support KHO/LUO Dongli Zhang
2026-10-12 23:55 ` [PATCH 01/21] qapi/migration: add cpr-luo migration mode Dongli Zhang
2026-10-14  7:42   ` Markus Armbruster
2026-10-14 15:52     ` Dongli Zhang
2026-10-15  5:06       ` Markus Armbruster
2026-10-15 20:37         ` Dongli Zhang
2026-10-16  5:04           ` Markus Armbruster
2026-10-12 23:55 ` [PATCH 02/21] migration/cpr: move CprFd definition to header file Dongli Zhang
2026-10-12 23:55 ` [PATCH 03/21] scripts/update-linux-headers: Add liveupdate.h Dongli Zhang
2026-10-12 23:56 ` [PATCH 04/21] linux-headers: import liveupdate UAPI header Dongli Zhang
2026-10-13  6:35   ` Cornelia Huck
2026-10-13 21:09     ` Dongli Zhang
2026-10-12 23:56 ` [PATCH 05/21] migration/cpr-luo: require a non-null machine UUID Dongli Zhang
2026-10-12 23:56 ` [PATCH 06/21] migration/cpr-luo: add LUO session management Dongli Zhang
2026-10-12 23:56 ` [PATCH 07/21] migration/cpr-luo: add LUO fd management helpers Dongli Zhang
2026-10-12 23:56 ` [PATCH 08/21] migration/cpr-luo: track LUO fds Dongli Zhang
2026-10-12 23:56 ` [PATCH 09/21] migration/cpr-luo: add LUO fd VMStateDescription Dongli Zhang
2026-10-12 23:56 ` [PATCH 10/21] migration/cpr-luo: add tokens for LUO fds Dongli Zhang
2026-10-12 23:56 ` [PATCH 11/21] migration/cpr: move QEMUFile fd helpers to common code Dongli Zhang
2026-10-12 23:56 ` [PATCH 12/21] migration/cpr-luo: add state fd helpers Dongli Zhang
2026-10-12 23:56 ` [PATCH 13/21] migration/cpr: add more arguments for cpr_walk_fd() Dongli Zhang
2026-10-12 23:56 ` [PATCH 14/21] migration/cpr-luo: add helpers to preserve and retrieve all LUO fds Dongli Zhang
2026-10-12 23:56 ` [PATCH 15/21] migration/cpr-luo: enable cpr-luo mode for source side preservation Dongli Zhang
2026-10-12 23:56 ` [PATCH 16/21] migration/cpr-luo: enable cpr-luo mode for target side retrieval Dongli Zhang
2026-10-12 23:56 ` [PATCH 17/21] migration/cpr-luo: abort session when migration fails Dongli Zhang
2026-10-12 23:56 ` [PATCH 18/21] system/physmem: add cpr-luo blocker Dongli Zhang
2026-10-12 23:56 ` [PATCH 19/21] monitor/qmp: close LUO session when resuming source QEMU Dongli Zhang
2026-10-12 23:56 ` [PATCH 20/21] vfio: block cpr-luo migration Dongli Zhang
2026-10-12 23:56 ` [PATCH 21/21] migration: cpr-luo documentation Dongli Zhang
2026-11-09 10:46 ` [PATCH 00/21] migration/cpr: introduce cpr-luo mode to support KHO/LUO Dongli Zhang
2026-11-17 19:01   ` Fabiano Rosas
2026-11-17 19:25     ` Peter Xu
2026-11-18  2:02       ` Dongli Zhang
2026-11-18 18:32         ` Fabiano Rosas [this message]
2026-11-19 22:47           ` Dongli Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87se0yq9bw.fsf@suse.de \
    --to=farosas@suse.de \
    --cc=alex@shazbot.org \
    --cc=armbru@redhat.com \
    --cc=bchaney@akamai.com \
    --cc=clg@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@kernel.org \
    --cc=dongli.zhang@oracle.com \
    --cc=eblake@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=maciej.szmigiero@oracle.com \
    --cc=mark.kanda@oracle.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yi.l.liu@intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.