From: Takashi Iwai <tiwai@suse.de>
To: phucduc.bui@gmail.com
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
cassiogabrielcontato@gmail.com,
Cezary Rojewski <cezary.rojewski@intel.com>,
Cen Zhang <zzzccc427@gmail.com>,
Yilin Zhang <yilinzhang@moonshot.ai>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcm: Propagate snd_pcm_stop() errors in snd_pcm_drop()
Date: Wed, 16 Sep 2026 14:07:00 +0200 [thread overview]
Message-ID: <87se39jt7f.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260916094014.33609-1-phucduc.bui@gmail.com>
On Wed, 16 Sep 2026 11:40:14 +0200,
phucduc.bui@gmail.com wrote:
>
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> snd_pcm_drop() currently ignores the return value of
> snd_pcm_stop() and returns a pre-initialized zero instead.
>
> Store the return value of snd_pcm_stop() in 'result' so that any
> error is propagated to the caller.
>
> Found by manual code inspection.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-09-16 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 9:40 [PATCH] ALSA: pcm: Propagate snd_pcm_stop() errors in snd_pcm_drop() phucduc.bui
2026-09-16 12:07 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87se39jt7f.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=cezary.rojewski@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=tiwai@suse.com \
--cc=yilinzhang@moonshot.ai \
--cc=zzzccc427@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.