All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: tip-bot2 for Niels Pressel <tip-bot2@linutronix.de>,
	linux-tip-commits@vger.kernel.org,
	Niels Pressel <npressel@ethz.ch>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [tip: core/urgent] entry/rseq: Fix hard lockup on granted time slice extension
Date: Sat, 08 Aug 2026 13:23:42 +0200	[thread overview]
Message-ID: <87se4on9dt.ffs@fw13> (raw)
In-Reply-To: <20260808083635.GR687043@noisy.programming.kicks-ass.net>

On Sat, Aug 08 2026 at 10:36, Peter Zijlstra wrote:
> On Fri, Aug 07, 2026 at 11:15:19PM +0200, Thomas Gleixner wrote:
>> 	rseq = curr->rseq.usrptr;
>> 	scoped_user_rw_access(rseq, efault) {
>> 
>> That's user access which requires interrupts to be enabled.
>
> Well, you can do user access with IRQs disabled just fine, you just get
> more efault.

Sure, but then you need a manual fault handler, which requires that
interrupts are enabled :)

>> So the thing [wm]e f*cked up royally was to invoke
>> hrtimer_rearm_deferred_tif() with interrupts enabled and that needs to
>> be fixed.
>> 
>> Of course all of this can be figured out from the copious amount of
>> comments which got added to explain all of this magic.
>
> Bah, its spread out over too damn many functions is what :/

That and comments are missing at crucial places :(


  reply	other threads:[~2026-08-08 11:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 11:34 [PATCH v2] rseq: fix hard lockup on granted time slice extension Niels Pressel
2026-08-06 12:48 ` [tip: core/urgent] entry/rseq: Fix " tip-bot2 for Niels Pressel
2026-08-07 21:15   ` Thomas Gleixner
2026-08-08  8:36     ` Peter Zijlstra
2026-08-08 11:23       ` Thomas Gleixner [this message]
2026-08-09  7:29     ` Niels Pressel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87se4on9dt.ffs@fw13 \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=npressel@ethz.ch \
    --cc=peterz@infradead.org \
    --cc=tip-bot2@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.