From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77D1728469A; Sat, 1 Aug 2026 13:15:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785590103; cv=none; b=m8EiQIcmoxXmEbHoh2/uBUnWjLHB8xah/YxSHmZz79oB+9Sx/0gvaU25ZlzaqVxXUM01/60RTeeIfuHB2wJq74TAysyGfUdPoQVQq9KqtbRyu3XtAuzXDXypZNwSa3jASnX93EyI8yZ1OeOiiCr4XvfuKU/KfKZMBJbwMd3RFWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785590103; c=relaxed/simple; bh=0pJOC4ZKQX3B19HICjCo8lBR4AZAbyQUwV37Kq9LQow=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=WaSLM+Pqk++VYwjlOvMvpJg4bo5S1/u7+ahDWSblEB/6yPbu9HU0Dvne1xL8E2L4IB2sHsUbUR/J9qkvIm5OQKYxrn9O+GJwVTfbRZYd4EVRgUytGqpwZ0eXkv51rzVbaJ0gQsvYF1fph/uWxAXsTylNhJ3GXVfnkg0bt4e5YCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QDOQnwgC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QDOQnwgC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 063C41F00AC4; Sat, 1 Aug 2026 13:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785590102; bh=Yp+qswBmnkN+OTXKqyXG+COBHiKXWTfYufk/fL2Po+8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=QDOQnwgCUZ7P19KQkzEFwQ2FyaJNeaEiimyG/EsjY5BnEPqgbD6ei6CXvQ1DuwnW6 oJdqPNUFI7K25hXanmg8uiVdF+/11hGgFBNRXSruwtrkL65/Za+EUDRzgrqnVy+/ES Z1Uu6T2GsqXKHBoGlNcA0+6LKJsrYacwQ+s5VrAtb86+hpwh8ZWZgsYIuBbusc00xB wpdFGY3v4+Qg32F61obyXK8UGGzWo+qBHMdbUloLc6OovfJAIOiRH6hhR/hP9F3ZoI M9YmcdXZyrU4i/XCh5UA+HR8na8eaywAo9/DST4F1m97KT0h89F0G8zoLNnD5ThTNv fLW3BE5SOnVcg== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wq9YJ-0000000BGo6-3cWY; Sat, 01 Aug 2026 13:14:59 +0000 Date: Sat, 01 Aug 2026 14:19:11 +0100 Message-ID: <87se4you5s.wl-maz@kernel.org> From: Marc Zyngier To: sashiko-reviews@lists.linux.dev Cc: "Oliver Upton" , kvmarm@lists.linux.dev, kvm@vger.kernel.org Subject: Re: [PATCH 1/6] KVM: arm64: Remove VM-wide VNCR mapping counter In-Reply-To: <20260801130805.8D81B1F00AC4@smtp.kernel.org> References: <20260801124818.366274-1-maz@kernel.org> <20260801124818.366274-2-maz@kernel.org> <20260801130805.8D81B1F00AC4@smtp.kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sashiko-reviews@lists.linux.dev, oupton@kernel.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sat, 01 Aug 2026 14:08:05 +0100, sashiko-bot@kernel.org wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > > Pre-existing issues: > - [High] The fast-path TLBI handler (`kvm_hyp_handle_tlbi_el2`) > fails to invalidate the `vncr_tlb` for EL2 TLBI instructions when > the guest hypervisor has `E2H=0` or `TGE=0`. - There is no guest provided VNCR when E2H=0 - A TLBI that targets the EL2&0 translation regime must have TGE==1 M. -- Jazz isn't dead. It just smells funny.