From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 779FD3E00BD; Wed, 8 Jul 2026 20:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783542882; cv=none; b=Di1mqWoiLRZeNH3bh97qyMZtTVEUYMgYZc6Rov9w+JJ0SE0Y5V/at9Q9yihVRDp4IHjcnd/H1Zzj8fa3ZdtuEAX08jI8wefWzBqQ4tCc+Vv+3g/stq26pzCjaBEnAQIAmqfh8XgxhnBSPZ9utkvLMZ3iOe5SKBrhTixATKIkV7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783542882; c=relaxed/simple; bh=3v+6WJABaaO66B/xl+FmF/glWoWCQWj5sfHWj7p866k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=LwlLDYiQylTeWkl1l6JiJ/SYMMcRryEJQYDkj6lq+iIXZlC/AEcAJ0Xos3jglIGVuaXoM3G/0NEumFX37QDzJZORNBFge9tj2ZESescXgSq4gP90KKDESWY9grsXVgp0NXi6hBVqRmd9dNOEw/BCBxFSPWLN2e2oDCDaoip0kng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KBWaMMj7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KBWaMMj7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 409811F000E9; Wed, 8 Jul 2026 20:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783542881; bh=XV21Gvu/Emr9nQ/q86judRNj/QbZCrZ1m+LE1leOgZo=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=KBWaMMj7fzOLrPcoUgRkEtUqRrOJt9n/xdiqN+Vs1q483RrbzeqFzVIrn8qMV348q fzALagUxxo9GHkkXN5K0/pDuyT5lcQFCVrkB3TakI/fH+yX9o21lm17cG/w9mcHlZt oOe4IwVYpbdQ7YFJViRdEjACSmNZ7bCvgRqE44efYSbmZ/P80pUYjPSalQk74K4UGs q1YlQWzgYxg2l/Bqj4QTlBIMbTxy/KKKjGg1H5q7buDTYhJYNVZ+fvvvrIQPf0vACG w9E8v6hcqzE35uRohSqIVauWdUc6/brHFDi4/JJnpbWlnb2h8H6ZQU4FGa9vyFJjCE 1BJealh9MtrdA== From: Thomas Gleixner To: Michal =?utf-8?Q?Such=C3=A1nek?= Cc: LKML , Peter Zijlstra , Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Kees Cook , Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Mark Rutland , Jinjie Ruan , Andy Lutomirski , Oleg Nesterov , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool In-Reply-To: References: <20260707181957.433213175@kernel.org> <20260707190254.338083894@kernel.org> Date: Wed, 08 Jul 2026 22:34:38 +0200 Message-ID: <87se5tqkyp.ffs@fw13> Precedence: bulk X-Mailing-List: linux-openrisc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Jul 08 2026 at 17:52, Michal Such=C3=A1nek wrote: > On Tue, Jul 07, 2026 at 09:06:48PM +0200, Thomas Gleixner wrote: >> In preparation of converting the return value of >> syscall_enter_from_user_mode[_work]() bool, rework trace_syscall_enter()= to >>=20 >> - update the syscall number via a pointer argument >>=20 >> - Return True if the syscall number is !=3D -1, False otherwise > > This does not achieve the goal of the initial RFC: To detangle the > return value of syscall_enter_from_user_mode from the syscall number. As I explained to you before: Your RFC broke the implicit assumption of tracing, which is way worse than having this oddity. > This still conflates them, making it impossible to tell if the syscall > was rejected or syscall number was -1 to start with. Now also obfuscated > by performing the check deeper inside the common code. That's where it belongs. It's a problem to solve within the given semantics of trace_syscall_enter() and not a problem to be worked around at the call sites if you want to have consolidated semantics. >> The only difference is that this also returns False, when the syscall >> number was already -1 to begin with, but there is not much which can be >> done about that. As the architecture has to preset the return value to >> -ENOSYS anyway, that results in the correct return value for such an >> invalid syscall. > > That's not possible to do for architectures where the syscall number and > the syscall return value are in the same register. > > You suggested that it is possible to not write the return value into an > actual register but use an additional field for that, and have the exit > code write the register. > > However, that's not what is documented, nor what is currently done. Just because S390 screwed up their ABI and then on top of that failed to do what _every_ other architecture in the kernel does, i.e. having a result storage which is preset to -ENOSYS does not mean that S390 did the right thing just because it was not documented. Kernel documentation is known to be incomplete and I fixed it up in the last patch as you might have noticed. Just for the record. Presetting the return value to -ENOSYS has been practice for three decades. I couldn't be bothered to do a full search in the history trees to figure out the exact point, but as of 2.1.9, which was released in Nov. 1996, this is definitely the case. So don't tell me that because S390 missed the train when it was added to mainline in 2007 (, i.e. 11 years _after_ this "undocumented" rule= was established that now 20 years later the world has to revolve around S390 and your personal idea of "clear and intelligible": > While this is an improvement in some respects the goal to have clear and > intelligible API around the generic entry is not acheived. I'm honestly not sure whether I should laugh or cry. You are completely missing the point: 1) The set in stone rule is that if the entry code returns -1L as the syscall number then the architecture code has to skip the syscall invocation _and_ is not supposed to change the return value. 2) There is no guarantee and never has been that any of the involved mechanisms (ptrace, seccomp, tracing) will change the return value when it sets the syscall number to -1L. Quite the contrary there has been a long time (30 years at least) expectation that the return value has been preset to -ENOSYS. 3) It's trivial as demonstrated to make ptrace and seccomp more comprehensible but that does not invalidate #2 4) Due to the historical integration of tracing (+probes/BPF) there is an implicit assumption that the return code is preset to -ENOSYS. See #2 5) There is an obvious ambiguity between the initial syscall number being -1 and the change of syscall number to -1 in the case of tracing, but that's not unique to tracing: If e.g. seccomp() observes the handed in syscall number to be -1 and tells in the return code to skip the syscall, then it can rightfully assume that the return code will be -ENOSYS and has no obligation to set it explicitly. See #2 Q: Is it perfect? A: No Q: Can it be made perfect? A: No, because you can't change history and established practice. Just for illustration. Changing the logic in trace_syscall_enter() to: --- a/kernel/entry/syscall-common.c +++ b/kernel/entry/syscall-common.c @@ -9,13 +9,15 @@ =20 bool trace_syscall_enter(struct pt_regs *regs, long *syscall) { + long orig_syscall =3D *syscall; + trace_sys_enter(regs, *syscall); /* * Probes or BPF hooks in the tracepoint may have changed the * system call number. Reread it. */ *syscall =3D syscall_get_nr(current, regs); - return *syscall !=3D -1L; + return *syscall =3D=3D orig_syscall || *syscall !=3D -1L; } =20 void trace_syscall_exit(struct pt_regs *regs, long ret) does not make #2 magically go away. It's still the same problem whether you like it or not. Thanks, tglx --- Ignorance is bliss -- Thomas Gray, 1742 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 450EDC43458 for ; Wed, 8 Jul 2026 20:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wIHaXJAW10klqph/WTCbheZlRIyJ1Y+Ayl9/dPriis8=; b=R3ndhWVdrs+y2h HA7gE+bUXQAkvwnzN9MkqEByNzBAroTDSZcaD1kHbKbexZX7IlkuIeldCdSL9CIt6av17k9dF7EX5 /zm9geSVBZMfboPORP4rZVN7B6DHC4NL37I3gkAOiHml/JhEVfliPqKN78vE+r1te0WorTZA55Ifd OjgexGWVkgTpXDtAyfRM/hzNRj6RmPCoKvqdb9IAeXVmHE1BfRx1mmMrT4Tjzmpdml3VoqiZs3/SM N31R//RMiqQ2QTMggKNPgptbWHGJQHxa6HzVSZdGUQlkT3vLcCDJLkeiVoM9zGfTpVxl9LVOV1QRt U1vvsDLrxCTF632oW3DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whYyh-00000000Mwp-47BZ; Wed, 08 Jul 2026 20:34:43 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whYyf-00000000MwV-2xqE; Wed, 08 Jul 2026 20:34:41 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 30CC740113; Wed, 8 Jul 2026 20:34:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 409811F000E9; Wed, 8 Jul 2026 20:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783542881; bh=XV21Gvu/Emr9nQ/q86judRNj/QbZCrZ1m+LE1leOgZo=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=KBWaMMj7fzOLrPcoUgRkEtUqRrOJt9n/xdiqN+Vs1q483RrbzeqFzVIrn8qMV348q fzALagUxxo9GHkkXN5K0/pDuyT5lcQFCVrkB3TakI/fH+yX9o21lm17cG/w9mcHlZt oOe4IwVYpbdQ7YFJViRdEjACSmNZ7bCvgRqE44efYSbmZ/P80pUYjPSalQk74K4UGs q1YlQWzgYxg2l/Bqj4QTlBIMbTxy/KKKjGg1H5q7buDTYhJYNVZ+fvvvrIQPf0vACG w9E8v6hcqzE35uRohSqIVauWdUc6/brHFDi4/JJnpbWlnb2h8H6ZQU4FGa9vyFJjCE 1BJealh9MtrdA== From: Thomas Gleixner To: Michal =?utf-8?Q?Such=C3=A1nek?= Cc: LKML , Peter Zijlstra , Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Kees Cook , Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Mark Rutland , Jinjie Ruan , Andy Lutomirski , Oleg Nesterov , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool In-Reply-To: References: <20260707181957.433213175@kernel.org> <20260707190254.338083894@kernel.org> Date: Wed, 08 Jul 2026 22:34:38 +0200 Message-ID: <87se5tqkyp.ffs@fw13> MIME-Version: 1.0 X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMDggMjAyNiBhdCAxNzo1MiwgTWljaGFsIFN1Y2jDoW5layB3cm90ZToKPiBP biBUdWUsIEp1bCAwNywgMjAyNiBhdCAwOTowNjo0OFBNICswMjAwLCBUaG9tYXMgR2xlaXhuZXIg d3JvdGU6Cj4+IEluIHByZXBhcmF0aW9uIG9mIGNvbnZlcnRpbmcgdGhlIHJldHVybiB2YWx1ZSBv Zgo+PiBzeXNjYWxsX2VudGVyX2Zyb21fdXNlcl9tb2RlW193b3JrXSgpIGJvb2wsIHJld29yayB0 cmFjZV9zeXNjYWxsX2VudGVyKCkgdG8KPj4gCj4+ICAtIHVwZGF0ZSB0aGUgc3lzY2FsbCBudW1i ZXIgdmlhIGEgcG9pbnRlciBhcmd1bWVudAo+PiAKPj4gIC0gUmV0dXJuIFRydWUgaWYgdGhlIHN5 c2NhbGwgbnVtYmVyIGlzICE9IC0xLCBGYWxzZSBvdGhlcndpc2UKPgo+IFRoaXMgZG9lcyBub3Qg YWNoaWV2ZSB0aGUgZ29hbCBvZiB0aGUgaW5pdGlhbCBSRkM6IFRvIGRldGFuZ2xlIHRoZQo+IHJl dHVybiB2YWx1ZSBvZiBzeXNjYWxsX2VudGVyX2Zyb21fdXNlcl9tb2RlIGZyb20gdGhlIHN5c2Nh bGwgbnVtYmVyLgoKQXMgSSBleHBsYWluZWQgdG8geW91IGJlZm9yZTogWW91ciBSRkMgYnJva2Ug dGhlIGltcGxpY2l0IGFzc3VtcHRpb24gb2YKdHJhY2luZywgd2hpY2ggaXMgd2F5IHdvcnNlIHRo YW4gaGF2aW5nIHRoaXMgb2RkaXR5LgoKPiBUaGlzIHN0aWxsIGNvbmZsYXRlcyB0aGVtLCBtYWtp bmcgaXQgaW1wb3NzaWJsZSB0byB0ZWxsIGlmIHRoZSBzeXNjYWxsCj4gd2FzIHJlamVjdGVkIG9y IHN5c2NhbGwgbnVtYmVyIHdhcyAtMSB0byBzdGFydCB3aXRoLiBOb3cgYWxzbyBvYmZ1c2NhdGVk Cj4gYnkgcGVyZm9ybWluZyB0aGUgY2hlY2sgZGVlcGVyIGluc2lkZSB0aGUgY29tbW9uIGNvZGUu CgpUaGF0J3Mgd2hlcmUgaXQgYmVsb25ncy4gSXQncyBhIHByb2JsZW0gdG8gc29sdmUgd2l0aGlu IHRoZSBnaXZlbgpzZW1hbnRpY3Mgb2YgdHJhY2Vfc3lzY2FsbF9lbnRlcigpIGFuZCBub3QgYSBw cm9ibGVtIHRvIGJlIHdvcmtlZCBhcm91bmQKYXQgdGhlIGNhbGwgc2l0ZXMgaWYgeW91IHdhbnQg dG8gaGF2ZSBjb25zb2xpZGF0ZWQgc2VtYW50aWNzLgoKPj4gVGhlIG9ubHkgZGlmZmVyZW5jZSBp cyB0aGF0IHRoaXMgYWxzbyByZXR1cm5zIEZhbHNlLCB3aGVuIHRoZSBzeXNjYWxsCj4+IG51bWJl ciB3YXMgYWxyZWFkeSAtMSB0byBiZWdpbiB3aXRoLCBidXQgdGhlcmUgaXMgbm90IG11Y2ggd2hp Y2ggY2FuIGJlCj4+IGRvbmUgYWJvdXQgdGhhdC4gQXMgdGhlIGFyY2hpdGVjdHVyZSBoYXMgdG8g cHJlc2V0IHRoZSByZXR1cm4gdmFsdWUgdG8KPj4gLUVOT1NZUyBhbnl3YXksIHRoYXQgcmVzdWx0 cyBpbiB0aGUgY29ycmVjdCByZXR1cm4gdmFsdWUgZm9yIHN1Y2ggYW4KPj4gaW52YWxpZCBzeXNj YWxsLgo+Cj4gVGhhdCdzIG5vdCBwb3NzaWJsZSB0byBkbyBmb3IgYXJjaGl0ZWN0dXJlcyB3aGVy ZSB0aGUgc3lzY2FsbCBudW1iZXIgYW5kCj4gdGhlIHN5c2NhbGwgcmV0dXJuIHZhbHVlIGFyZSBp biB0aGUgc2FtZSByZWdpc3Rlci4KPgo+IFlvdSBzdWdnZXN0ZWQgdGhhdCBpdCBpcyBwb3NzaWJs ZSB0byBub3Qgd3JpdGUgdGhlIHJldHVybiB2YWx1ZSBpbnRvIGFuCj4gYWN0dWFsIHJlZ2lzdGVy IGJ1dCB1c2UgYW4gYWRkaXRpb25hbCBmaWVsZCBmb3IgdGhhdCwgYW5kIGhhdmUgdGhlIGV4aXQK PiBjb2RlIHdyaXRlIHRoZSByZWdpc3Rlci4KPgo+IEhvd2V2ZXIsIHRoYXQncyBub3Qgd2hhdCBp cyBkb2N1bWVudGVkLCBub3Igd2hhdCBpcyBjdXJyZW50bHkgZG9uZS4KCkp1c3QgYmVjYXVzZSBT MzkwIHNjcmV3ZWQgdXAgdGhlaXIgQUJJIGFuZCB0aGVuIG9uIHRvcCBvZiB0aGF0IGZhaWxlZCB0 bwpkbyB3aGF0IF9ldmVyeV8gb3RoZXIgYXJjaGl0ZWN0dXJlIGluIHRoZSBrZXJuZWwgZG9lcywg aS5lLiBoYXZpbmcgYQpyZXN1bHQgc3RvcmFnZSB3aGljaCBpcyBwcmVzZXQgdG8gLUVOT1NZUyBk b2VzIG5vdCBtZWFuIHRoYXQgUzM5MCBkaWQKdGhlIHJpZ2h0IHRoaW5nIGp1c3QgYmVjYXVzZSBp dCB3YXMgbm90IGRvY3VtZW50ZWQuIEtlcm5lbCBkb2N1bWVudGF0aW9uCmlzIGtub3duIHRvIGJl IGluY29tcGxldGUgYW5kIEkgZml4ZWQgaXQgdXAgaW4gdGhlIGxhc3QgcGF0Y2ggYXMgeW91Cm1p Z2h0IGhhdmUgbm90aWNlZC4KCkp1c3QgZm9yIHRoZSByZWNvcmQuIFByZXNldHRpbmcgdGhlIHJl dHVybiB2YWx1ZSB0byAtRU5PU1lTIGhhcyBiZWVuCnByYWN0aWNlIGZvciB0aHJlZSBkZWNhZGVz LiBJIGNvdWxkbid0IGJlIGJvdGhlcmVkIHRvIGRvIGEgZnVsbCBzZWFyY2gKaW4gdGhlIGhpc3Rv cnkgdHJlZXMgdG8gZmlndXJlIG91dCB0aGUgZXhhY3QgcG9pbnQsIGJ1dCBhcyBvZiAyLjEuOSwK d2hpY2ggd2FzIHJlbGVhc2VkIGluIE5vdi4gMTk5NiwgdGhpcyBpcyBkZWZpbml0ZWx5IHRoZSBj YXNlLgoKU28gZG9uJ3QgdGVsbCBtZSB0aGF0IGJlY2F1c2UgUzM5MCBtaXNzZWQgdGhlIHRyYWlu IHdoZW4gaXQgd2FzCmFkZGVkIHRvIG1haW5saW5lIGluIDIwMDcgKCwgaS5lLiAxMSB5ZWFycyBf YWZ0ZXJfIHRoaXMgInVuZG9jdW1lbnRlZCIgcnVsZSB3YXMKZXN0YWJsaXNoZWQgdGhhdCBub3cg MjAgeWVhcnMgbGF0ZXIgdGhlIHdvcmxkIGhhcyB0byByZXZvbHZlIGFyb3VuZCBTMzkwCmFuZCB5 b3VyIHBlcnNvbmFsIGlkZWEgb2YgImNsZWFyIGFuZCBpbnRlbGxpZ2libGUiOgoKPiBXaGlsZSB0 aGlzIGlzIGFuIGltcHJvdmVtZW50IGluIHNvbWUgcmVzcGVjdHMgdGhlIGdvYWwgdG8gaGF2ZSBj bGVhciBhbmQKPiBpbnRlbGxpZ2libGUgQVBJIGFyb3VuZCB0aGUgZ2VuZXJpYyBlbnRyeSBpcyBu b3QgYWNoZWl2ZWQuCgpJJ20gaG9uZXN0bHkgbm90IHN1cmUgd2hldGhlciBJIHNob3VsZCBsYXVn aCBvciBjcnkuCgpZb3UgYXJlIGNvbXBsZXRlbHkgbWlzc2luZyB0aGUgcG9pbnQ6CgogIDEpIFRo ZSBzZXQgaW4gc3RvbmUgcnVsZSBpcyB0aGF0IGlmIHRoZSBlbnRyeSBjb2RlIHJldHVybnMgLTFM IGFzIHRoZQogICAgIHN5c2NhbGwgbnVtYmVyIHRoZW4gdGhlIGFyY2hpdGVjdHVyZSBjb2RlIGhh cyB0byBza2lwIHRoZSBzeXNjYWxsCiAgICAgaW52b2NhdGlvbiBfYW5kXyBpcyBub3Qgc3VwcG9z ZWQgdG8gY2hhbmdlIHRoZSByZXR1cm4gdmFsdWUuCgogIDIpIFRoZXJlIGlzIG5vIGd1YXJhbnRl ZSBhbmQgbmV2ZXIgaGFzIGJlZW4gdGhhdCBhbnkgb2YgdGhlIGludm9sdmVkCiAgICAgbWVjaGFu aXNtcyAocHRyYWNlLCBzZWNjb21wLCB0cmFjaW5nKSB3aWxsIGNoYW5nZSB0aGUgcmV0dXJuIHZh bHVlCiAgICAgd2hlbiBpdCBzZXRzIHRoZSBzeXNjYWxsIG51bWJlciB0byAtMUwuCgogICAgIFF1 aXRlIHRoZSBjb250cmFyeSB0aGVyZSBoYXMgYmVlbiBhIGxvbmcgdGltZSAoMzAgeWVhcnMgYXQg bGVhc3QpCiAgICAgZXhwZWN0YXRpb24gdGhhdCB0aGUgcmV0dXJuIHZhbHVlIGhhcyBiZWVuIHBy ZXNldCB0byAtRU5PU1lTLgoKICAzKSBJdCdzIHRyaXZpYWwgYXMgZGVtb25zdHJhdGVkIHRvIG1h a2UgcHRyYWNlIGFuZCBzZWNjb21wIG1vcmUKICAgICBjb21wcmVoZW5zaWJsZSBidXQgdGhhdCBk b2VzIG5vdCBpbnZhbGlkYXRlICMyCgogIDQpIER1ZSB0byB0aGUgaGlzdG9yaWNhbCBpbnRlZ3Jh dGlvbiBvZiB0cmFjaW5nICgrcHJvYmVzL0JQRikgdGhlcmUgaXMKICAgICBhbiBpbXBsaWNpdCBh c3N1bXB0aW9uIHRoYXQgdGhlIHJldHVybiBjb2RlIGlzIHByZXNldCB0byAtRU5PU1lTLgogICAg IFNlZSAjMgoKICA1KSBUaGVyZSBpcyBhbiBvYnZpb3VzIGFtYmlndWl0eSBiZXR3ZWVuIHRoZSBp bml0aWFsIHN5c2NhbGwgbnVtYmVyCiAgICAgYmVpbmcgLTEgYW5kIHRoZSBjaGFuZ2Ugb2Ygc3lz Y2FsbCBudW1iZXIgdG8gLTEgaW4gdGhlIGNhc2Ugb2YKICAgICB0cmFjaW5nLCBidXQgdGhhdCdz IG5vdCB1bmlxdWUgdG8gdHJhY2luZzoKCiAgICAgSWYgZS5nLiBzZWNjb21wKCkgb2JzZXJ2ZXMg dGhlIGhhbmRlZCBpbiBzeXNjYWxsIG51bWJlciB0byBiZSAtMQogICAgIGFuZCB0ZWxscyBpbiB0 aGUgcmV0dXJuIGNvZGUgdG8gc2tpcCB0aGUgc3lzY2FsbCwgdGhlbiBpdCBjYW4KICAgICByaWdo dGZ1bGx5IGFzc3VtZSB0aGF0IHRoZSByZXR1cm4gY29kZSB3aWxsIGJlIC1FTk9TWVMgYW5kIGhh cyBubwogICAgIG9ibGlnYXRpb24gdG8gc2V0IGl0IGV4cGxpY2l0bHkuIFNlZSAjMgoKUTogSXMg aXQgcGVyZmVjdD8KQTogTm8KClE6IENhbiBpdCBiZSBtYWRlIHBlcmZlY3Q/CkE6IE5vLCBiZWNh dXNlIHlvdSBjYW4ndCBjaGFuZ2UgaGlzdG9yeSBhbmQgZXN0YWJsaXNoZWQgcHJhY3RpY2UuCgpK dXN0IGZvciBpbGx1c3RyYXRpb24uIENoYW5naW5nIHRoZSBsb2dpYyBpbiB0cmFjZV9zeXNjYWxs X2VudGVyKCkgdG86CgotLS0gYS9rZXJuZWwvZW50cnkvc3lzY2FsbC1jb21tb24uYworKysgYi9r ZXJuZWwvZW50cnkvc3lzY2FsbC1jb21tb24uYwpAQCAtOSwxMyArOSwxNSBAQAogCiBib29sIHRy YWNlX3N5c2NhbGxfZW50ZXIoc3RydWN0IHB0X3JlZ3MgKnJlZ3MsIGxvbmcgKnN5c2NhbGwpCiB7 CisJbG9uZyBvcmlnX3N5c2NhbGwgPSAqc3lzY2FsbDsKKwogCXRyYWNlX3N5c19lbnRlcihyZWdz LCAqc3lzY2FsbCk7CiAJLyoKIAkgKiBQcm9iZXMgb3IgQlBGIGhvb2tzIGluIHRoZSB0cmFjZXBv aW50IG1heSBoYXZlIGNoYW5nZWQgdGhlCiAJICogc3lzdGVtIGNhbGwgbnVtYmVyLiBSZXJlYWQg aXQuCiAJICovCiAJKnN5c2NhbGwgPSBzeXNjYWxsX2dldF9ucihjdXJyZW50LCByZWdzKTsKLQly ZXR1cm4gKnN5c2NhbGwgIT0gLTFMOworCXJldHVybiAqc3lzY2FsbCA9PSBvcmlnX3N5c2NhbGwg fHwgKnN5c2NhbGwgIT0gLTFMOwogfQogCiB2b2lkIHRyYWNlX3N5c2NhbGxfZXhpdChzdHJ1Y3Qg cHRfcmVncyAqcmVncywgbG9uZyByZXQpCgpkb2VzIG5vdCBtYWtlICMyIG1hZ2ljYWxseSBnbyBh d2F5LiBJdCdzIHN0aWxsIHRoZSBzYW1lIHByb2JsZW0gd2hldGhlcgp5b3UgbGlrZSBpdCBvciBu b3QuCgpUaGFua3MsCgogICAgICAgIHRnbHgKLS0tCiAgICAgICAgSWdub3JhbmNlIGlzIGJsaXNz IC0tICBUaG9tYXMgR3JheSwgMTc0MgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtc25wcy1hcmMgbWFpbGluZyBsaXN0CmxpbnV4LXNucHMtYXJj QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1zbnBzLWFyYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B79CEC43458 for ; Wed, 8 Jul 2026 20:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KpnYQbo/2Lzwin04n9L632eZby+lLCU4L5zm+5WD1vA=; b=Fkl6LRUx4iO/tt PQRdzKli4hdFEj2XCEqXm7kNBzcY/GwcCu6TYWI/8Z9OVoBIy8iRCEuYqpo3wSONmNrrBaBWXlIWb sHdyyE6LU37cLCibVkU+a5VlonGZD4lwpUm0mB3i4gAgIHmO3PVFCn0pVq9Gab53hB7xE7Tk1iKOW JfIS710gYOTvdh7EYhUn8ss/Ch8ZKq0v3QvlIFf9008HaLg8hmhwNMGp7rn+qqMq0LVSu/venpbZS NL/2rU5oIM2Xq9wRDiFQhsTTER07RmlGjJbHqXPAwemJJ4hZo0K6uZLEzPNuidRKlMw3JrhKPa6cD L1KxwaJ1IiDfOj22VcLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whYyh-00000000Mwl-3ngl; Wed, 08 Jul 2026 20:34:43 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whYyf-00000000MwV-2xqE; Wed, 08 Jul 2026 20:34:41 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 30CC740113; Wed, 8 Jul 2026 20:34:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 409811F000E9; Wed, 8 Jul 2026 20:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783542881; bh=XV21Gvu/Emr9nQ/q86judRNj/QbZCrZ1m+LE1leOgZo=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=KBWaMMj7fzOLrPcoUgRkEtUqRrOJt9n/xdiqN+Vs1q483RrbzeqFzVIrn8qMV348q fzALagUxxo9GHkkXN5K0/pDuyT5lcQFCVrkB3TakI/fH+yX9o21lm17cG/w9mcHlZt oOe4IwVYpbdQ7YFJViRdEjACSmNZ7bCvgRqE44efYSbmZ/P80pUYjPSalQk74K4UGs q1YlQWzgYxg2l/Bqj4QTlBIMbTxy/KKKjGg1H5q7buDTYhJYNVZ+fvvvrIQPf0vACG w9E8v6hcqzE35uRohSqIVauWdUc6/brHFDi4/JJnpbWlnb2h8H6ZQU4FGa9vyFJjCE 1BJealh9MtrdA== From: Thomas Gleixner To: Michal =?utf-8?Q?Such=C3=A1nek?= Cc: LKML , Peter Zijlstra , Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Kees Cook , Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Mark Rutland , Jinjie Ruan , Andy Lutomirski , Oleg Nesterov , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool In-Reply-To: References: <20260707181957.433213175@kernel.org> <20260707190254.338083894@kernel.org> Date: Wed, 08 Jul 2026 22:34:38 +0200 Message-ID: <87se5tqkyp.ffs@fw13> MIME-Version: 1.0 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMDggMjAyNiBhdCAxNzo1MiwgTWljaGFsIFN1Y2jDoW5layB3cm90ZToKPiBP biBUdWUsIEp1bCAwNywgMjAyNiBhdCAwOTowNjo0OFBNICswMjAwLCBUaG9tYXMgR2xlaXhuZXIg d3JvdGU6Cj4+IEluIHByZXBhcmF0aW9uIG9mIGNvbnZlcnRpbmcgdGhlIHJldHVybiB2YWx1ZSBv Zgo+PiBzeXNjYWxsX2VudGVyX2Zyb21fdXNlcl9tb2RlW193b3JrXSgpIGJvb2wsIHJld29yayB0 cmFjZV9zeXNjYWxsX2VudGVyKCkgdG8KPj4gCj4+ICAtIHVwZGF0ZSB0aGUgc3lzY2FsbCBudW1i ZXIgdmlhIGEgcG9pbnRlciBhcmd1bWVudAo+PiAKPj4gIC0gUmV0dXJuIFRydWUgaWYgdGhlIHN5 c2NhbGwgbnVtYmVyIGlzICE9IC0xLCBGYWxzZSBvdGhlcndpc2UKPgo+IFRoaXMgZG9lcyBub3Qg YWNoaWV2ZSB0aGUgZ29hbCBvZiB0aGUgaW5pdGlhbCBSRkM6IFRvIGRldGFuZ2xlIHRoZQo+IHJl dHVybiB2YWx1ZSBvZiBzeXNjYWxsX2VudGVyX2Zyb21fdXNlcl9tb2RlIGZyb20gdGhlIHN5c2Nh bGwgbnVtYmVyLgoKQXMgSSBleHBsYWluZWQgdG8geW91IGJlZm9yZTogWW91ciBSRkMgYnJva2Ug dGhlIGltcGxpY2l0IGFzc3VtcHRpb24gb2YKdHJhY2luZywgd2hpY2ggaXMgd2F5IHdvcnNlIHRo YW4gaGF2aW5nIHRoaXMgb2RkaXR5LgoKPiBUaGlzIHN0aWxsIGNvbmZsYXRlcyB0aGVtLCBtYWtp bmcgaXQgaW1wb3NzaWJsZSB0byB0ZWxsIGlmIHRoZSBzeXNjYWxsCj4gd2FzIHJlamVjdGVkIG9y IHN5c2NhbGwgbnVtYmVyIHdhcyAtMSB0byBzdGFydCB3aXRoLiBOb3cgYWxzbyBvYmZ1c2NhdGVk Cj4gYnkgcGVyZm9ybWluZyB0aGUgY2hlY2sgZGVlcGVyIGluc2lkZSB0aGUgY29tbW9uIGNvZGUu CgpUaGF0J3Mgd2hlcmUgaXQgYmVsb25ncy4gSXQncyBhIHByb2JsZW0gdG8gc29sdmUgd2l0aGlu IHRoZSBnaXZlbgpzZW1hbnRpY3Mgb2YgdHJhY2Vfc3lzY2FsbF9lbnRlcigpIGFuZCBub3QgYSBw cm9ibGVtIHRvIGJlIHdvcmtlZCBhcm91bmQKYXQgdGhlIGNhbGwgc2l0ZXMgaWYgeW91IHdhbnQg dG8gaGF2ZSBjb25zb2xpZGF0ZWQgc2VtYW50aWNzLgoKPj4gVGhlIG9ubHkgZGlmZmVyZW5jZSBp cyB0aGF0IHRoaXMgYWxzbyByZXR1cm5zIEZhbHNlLCB3aGVuIHRoZSBzeXNjYWxsCj4+IG51bWJl ciB3YXMgYWxyZWFkeSAtMSB0byBiZWdpbiB3aXRoLCBidXQgdGhlcmUgaXMgbm90IG11Y2ggd2hp Y2ggY2FuIGJlCj4+IGRvbmUgYWJvdXQgdGhhdC4gQXMgdGhlIGFyY2hpdGVjdHVyZSBoYXMgdG8g cHJlc2V0IHRoZSByZXR1cm4gdmFsdWUgdG8KPj4gLUVOT1NZUyBhbnl3YXksIHRoYXQgcmVzdWx0 cyBpbiB0aGUgY29ycmVjdCByZXR1cm4gdmFsdWUgZm9yIHN1Y2ggYW4KPj4gaW52YWxpZCBzeXNj YWxsLgo+Cj4gVGhhdCdzIG5vdCBwb3NzaWJsZSB0byBkbyBmb3IgYXJjaGl0ZWN0dXJlcyB3aGVy ZSB0aGUgc3lzY2FsbCBudW1iZXIgYW5kCj4gdGhlIHN5c2NhbGwgcmV0dXJuIHZhbHVlIGFyZSBp biB0aGUgc2FtZSByZWdpc3Rlci4KPgo+IFlvdSBzdWdnZXN0ZWQgdGhhdCBpdCBpcyBwb3NzaWJs ZSB0byBub3Qgd3JpdGUgdGhlIHJldHVybiB2YWx1ZSBpbnRvIGFuCj4gYWN0dWFsIHJlZ2lzdGVy IGJ1dCB1c2UgYW4gYWRkaXRpb25hbCBmaWVsZCBmb3IgdGhhdCwgYW5kIGhhdmUgdGhlIGV4aXQK PiBjb2RlIHdyaXRlIHRoZSByZWdpc3Rlci4KPgo+IEhvd2V2ZXIsIHRoYXQncyBub3Qgd2hhdCBp cyBkb2N1bWVudGVkLCBub3Igd2hhdCBpcyBjdXJyZW50bHkgZG9uZS4KCkp1c3QgYmVjYXVzZSBT MzkwIHNjcmV3ZWQgdXAgdGhlaXIgQUJJIGFuZCB0aGVuIG9uIHRvcCBvZiB0aGF0IGZhaWxlZCB0 bwpkbyB3aGF0IF9ldmVyeV8gb3RoZXIgYXJjaGl0ZWN0dXJlIGluIHRoZSBrZXJuZWwgZG9lcywg aS5lLiBoYXZpbmcgYQpyZXN1bHQgc3RvcmFnZSB3aGljaCBpcyBwcmVzZXQgdG8gLUVOT1NZUyBk b2VzIG5vdCBtZWFuIHRoYXQgUzM5MCBkaWQKdGhlIHJpZ2h0IHRoaW5nIGp1c3QgYmVjYXVzZSBp dCB3YXMgbm90IGRvY3VtZW50ZWQuIEtlcm5lbCBkb2N1bWVudGF0aW9uCmlzIGtub3duIHRvIGJl IGluY29tcGxldGUgYW5kIEkgZml4ZWQgaXQgdXAgaW4gdGhlIGxhc3QgcGF0Y2ggYXMgeW91Cm1p Z2h0IGhhdmUgbm90aWNlZC4KCkp1c3QgZm9yIHRoZSByZWNvcmQuIFByZXNldHRpbmcgdGhlIHJl dHVybiB2YWx1ZSB0byAtRU5PU1lTIGhhcyBiZWVuCnByYWN0aWNlIGZvciB0aHJlZSBkZWNhZGVz LiBJIGNvdWxkbid0IGJlIGJvdGhlcmVkIHRvIGRvIGEgZnVsbCBzZWFyY2gKaW4gdGhlIGhpc3Rv cnkgdHJlZXMgdG8gZmlndXJlIG91dCB0aGUgZXhhY3QgcG9pbnQsIGJ1dCBhcyBvZiAyLjEuOSwK d2hpY2ggd2FzIHJlbGVhc2VkIGluIE5vdi4gMTk5NiwgdGhpcyBpcyBkZWZpbml0ZWx5IHRoZSBj YXNlLgoKU28gZG9uJ3QgdGVsbCBtZSB0aGF0IGJlY2F1c2UgUzM5MCBtaXNzZWQgdGhlIHRyYWlu IHdoZW4gaXQgd2FzCmFkZGVkIHRvIG1haW5saW5lIGluIDIwMDcgKCwgaS5lLiAxMSB5ZWFycyBf YWZ0ZXJfIHRoaXMgInVuZG9jdW1lbnRlZCIgcnVsZSB3YXMKZXN0YWJsaXNoZWQgdGhhdCBub3cg MjAgeWVhcnMgbGF0ZXIgdGhlIHdvcmxkIGhhcyB0byByZXZvbHZlIGFyb3VuZCBTMzkwCmFuZCB5 b3VyIHBlcnNvbmFsIGlkZWEgb2YgImNsZWFyIGFuZCBpbnRlbGxpZ2libGUiOgoKPiBXaGlsZSB0 aGlzIGlzIGFuIGltcHJvdmVtZW50IGluIHNvbWUgcmVzcGVjdHMgdGhlIGdvYWwgdG8gaGF2ZSBj bGVhciBhbmQKPiBpbnRlbGxpZ2libGUgQVBJIGFyb3VuZCB0aGUgZ2VuZXJpYyBlbnRyeSBpcyBu b3QgYWNoZWl2ZWQuCgpJJ20gaG9uZXN0bHkgbm90IHN1cmUgd2hldGhlciBJIHNob3VsZCBsYXVn aCBvciBjcnkuCgpZb3UgYXJlIGNvbXBsZXRlbHkgbWlzc2luZyB0aGUgcG9pbnQ6CgogIDEpIFRo ZSBzZXQgaW4gc3RvbmUgcnVsZSBpcyB0aGF0IGlmIHRoZSBlbnRyeSBjb2RlIHJldHVybnMgLTFM IGFzIHRoZQogICAgIHN5c2NhbGwgbnVtYmVyIHRoZW4gdGhlIGFyY2hpdGVjdHVyZSBjb2RlIGhh cyB0byBza2lwIHRoZSBzeXNjYWxsCiAgICAgaW52b2NhdGlvbiBfYW5kXyBpcyBub3Qgc3VwcG9z ZWQgdG8gY2hhbmdlIHRoZSByZXR1cm4gdmFsdWUuCgogIDIpIFRoZXJlIGlzIG5vIGd1YXJhbnRl ZSBhbmQgbmV2ZXIgaGFzIGJlZW4gdGhhdCBhbnkgb2YgdGhlIGludm9sdmVkCiAgICAgbWVjaGFu aXNtcyAocHRyYWNlLCBzZWNjb21wLCB0cmFjaW5nKSB3aWxsIGNoYW5nZSB0aGUgcmV0dXJuIHZh bHVlCiAgICAgd2hlbiBpdCBzZXRzIHRoZSBzeXNjYWxsIG51bWJlciB0byAtMUwuCgogICAgIFF1 aXRlIHRoZSBjb250cmFyeSB0aGVyZSBoYXMgYmVlbiBhIGxvbmcgdGltZSAoMzAgeWVhcnMgYXQg bGVhc3QpCiAgICAgZXhwZWN0YXRpb24gdGhhdCB0aGUgcmV0dXJuIHZhbHVlIGhhcyBiZWVuIHBy ZXNldCB0byAtRU5PU1lTLgoKICAzKSBJdCdzIHRyaXZpYWwgYXMgZGVtb25zdHJhdGVkIHRvIG1h a2UgcHRyYWNlIGFuZCBzZWNjb21wIG1vcmUKICAgICBjb21wcmVoZW5zaWJsZSBidXQgdGhhdCBk b2VzIG5vdCBpbnZhbGlkYXRlICMyCgogIDQpIER1ZSB0byB0aGUgaGlzdG9yaWNhbCBpbnRlZ3Jh dGlvbiBvZiB0cmFjaW5nICgrcHJvYmVzL0JQRikgdGhlcmUgaXMKICAgICBhbiBpbXBsaWNpdCBh c3N1bXB0aW9uIHRoYXQgdGhlIHJldHVybiBjb2RlIGlzIHByZXNldCB0byAtRU5PU1lTLgogICAg IFNlZSAjMgoKICA1KSBUaGVyZSBpcyBhbiBvYnZpb3VzIGFtYmlndWl0eSBiZXR3ZWVuIHRoZSBp bml0aWFsIHN5c2NhbGwgbnVtYmVyCiAgICAgYmVpbmcgLTEgYW5kIHRoZSBjaGFuZ2Ugb2Ygc3lz Y2FsbCBudW1iZXIgdG8gLTEgaW4gdGhlIGNhc2Ugb2YKICAgICB0cmFjaW5nLCBidXQgdGhhdCdz IG5vdCB1bmlxdWUgdG8gdHJhY2luZzoKCiAgICAgSWYgZS5nLiBzZWNjb21wKCkgb2JzZXJ2ZXMg dGhlIGhhbmRlZCBpbiBzeXNjYWxsIG51bWJlciB0byBiZSAtMQogICAgIGFuZCB0ZWxscyBpbiB0 aGUgcmV0dXJuIGNvZGUgdG8gc2tpcCB0aGUgc3lzY2FsbCwgdGhlbiBpdCBjYW4KICAgICByaWdo dGZ1bGx5IGFzc3VtZSB0aGF0IHRoZSByZXR1cm4gY29kZSB3aWxsIGJlIC1FTk9TWVMgYW5kIGhh cyBubwogICAgIG9ibGlnYXRpb24gdG8gc2V0IGl0IGV4cGxpY2l0bHkuIFNlZSAjMgoKUTogSXMg aXQgcGVyZmVjdD8KQTogTm8KClE6IENhbiBpdCBiZSBtYWRlIHBlcmZlY3Q/CkE6IE5vLCBiZWNh dXNlIHlvdSBjYW4ndCBjaGFuZ2UgaGlzdG9yeSBhbmQgZXN0YWJsaXNoZWQgcHJhY3RpY2UuCgpK dXN0IGZvciBpbGx1c3RyYXRpb24uIENoYW5naW5nIHRoZSBsb2dpYyBpbiB0cmFjZV9zeXNjYWxs X2VudGVyKCkgdG86CgotLS0gYS9rZXJuZWwvZW50cnkvc3lzY2FsbC1jb21tb24uYworKysgYi9r ZXJuZWwvZW50cnkvc3lzY2FsbC1jb21tb24uYwpAQCAtOSwxMyArOSwxNSBAQAogCiBib29sIHRy YWNlX3N5c2NhbGxfZW50ZXIoc3RydWN0IHB0X3JlZ3MgKnJlZ3MsIGxvbmcgKnN5c2NhbGwpCiB7 CisJbG9uZyBvcmlnX3N5c2NhbGwgPSAqc3lzY2FsbDsKKwogCXRyYWNlX3N5c19lbnRlcihyZWdz LCAqc3lzY2FsbCk7CiAJLyoKIAkgKiBQcm9iZXMgb3IgQlBGIGhvb2tzIGluIHRoZSB0cmFjZXBv aW50IG1heSBoYXZlIGNoYW5nZWQgdGhlCiAJICogc3lzdGVtIGNhbGwgbnVtYmVyLiBSZXJlYWQg aXQuCiAJICovCiAJKnN5c2NhbGwgPSBzeXNjYWxsX2dldF9ucihjdXJyZW50LCByZWdzKTsKLQly ZXR1cm4gKnN5c2NhbGwgIT0gLTFMOworCXJldHVybiAqc3lzY2FsbCA9PSBvcmlnX3N5c2NhbGwg fHwgKnN5c2NhbGwgIT0gLTFMOwogfQogCiB2b2lkIHRyYWNlX3N5c2NhbGxfZXhpdChzdHJ1Y3Qg cHRfcmVncyAqcmVncywgbG9uZyByZXQpCgpkb2VzIG5vdCBtYWtlICMyIG1hZ2ljYWxseSBnbyBh d2F5LiBJdCdzIHN0aWxsIHRoZSBzYW1lIHByb2JsZW0gd2hldGhlcgp5b3UgbGlrZSBpdCBvciBu b3QuCgpUaGFua3MsCgogICAgICAgIHRnbHgKLS0tCiAgICAgICAgSWdub3JhbmNlIGlzIGJsaXNz IC0tICBUaG9tYXMgR3JheSwgMTc0MgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1yaXNjdgo=