From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29505CD98C6 for ; Thu, 11 Jun 2026 05:21:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cAfjg0mT0JqLgjOBPKdDjikqtGCGQF+LL3F9LM9NQ3M=; b=qsTF3JHGQvViN+ JkVKjYNQQh46Js2A/soTMBRo4y2w1w09poLGE8+OQT5YKrI+6Ayf7ZrGSf4sKgj8nnML19/OqbA3A bM+oknWo84DYQji7sWm1IGFGwbzfEmc9QkH0PtM93BQ9od+Gzrg8i4opZLaWUbYZ6hGdsgRz+b5Cp Y4Rt6Axwy6pL/JWitKb9EYSkO/SefRkvrWv5XnyDQHeagJeOJMwY1UX+k5/GUBE2hDBoyU7qutrFg c7zkvylUJHBfhM9Lsiyv2+N8h5uY/eLx6kL9HfFag5UmA2d0OGHbIKG/xWw/wWfnQKFpqm1CL+47I O6fYV9Sro3HDBYka74TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXXrO-00000008ioj-3A6y; Thu, 11 Jun 2026 05:21:46 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXXrM-00000008ioN-18mP; Thu, 11 Jun 2026 05:21:45 +0000 From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1781155298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pxZrj3HZL3fhz45xiVff8+rxIRxk0wNsp5NDbhPArlI=; b=aQzCTui0vIILvBLiJ6c+wEedWOf1pg+UetUx3mJQd/3OCbhPCyC/7p99cIGbjKgoJbxeMJ RvZqYgQwQFmC5CqTD+p42o+nd8/IV56U9kBsGlgsljW4/EmiHlyE08zJwlpzKtucjsQTH2 rEJEjOzYg4y7RDE+33fQm7bKo99nmPtAfJtfGnHRx8CfIAXiBKPibOszPxJ5R9VMvrAzqv cRKzAmPGIbpXjmJYkNqeuRTchJRuKCXXrSf/oOJdgegFvGyzXK6jp82DFjbqWEtEXJ4e+C Ed5pEg0YR/GG/tIVoc+km7DO9PUvOfGDB+PARYYG7MGDLtyslxaUlED8pLbDSw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1781155298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pxZrj3HZL3fhz45xiVff8+rxIRxk0wNsp5NDbhPArlI=; b=fHWDIlZdzOiLKfXOL42qehPTjVZemfYb8XJAOT676l7OxGd2A/3JPDZzKUvv/Wqp1V95b2 AtIF3KGM8zBcLRBw== To: Charlie Jenkins Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 01/16] riscv: Introduce instruction table generation In-Reply-To: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-1-54b4736a1e77@gmail.com> <878q8m1j9y.fsf@yellow.woof> Date: Thu, 11 Jun 2026 07:21:37 +0200 Message-ID: <87se6tejoe.fsf@yellow.woof> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260610_222144_479110_88492435 X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org Charlie Jenkins writes: > This is a weird one. The Ziclsd extension introduces it for RV32[1]. All > of the data is generated from the riscv-unified-db and because it is in > the Ziclsd extension, c.ld is included for 32-bit in the c.ld > description [2]. Oh :( We probably should amend the base spec to mention that. >> > + compressed_name=${name##c.*} >> ^^^^^^^^^^^^^^^ >> this name is misleading > > That's fair, I can rename it to be something like "compressed_inst"? My issue is that "compressed_name" indicates that it holds the compressed variant of the name. But it actually is empty if the instruction is compressed, otherwise it is the original instruction name. I am not sure what is a better name. Perhaps just inline this to the usage below. Nam -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09413CD98CE for ; Thu, 11 Jun 2026 05:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5KmI7CR3t0g55SHNqG4w02bGIS6kwcrZynsmkjhxiR8=; b=urla8hIDf2dnul kY7CIn3vvoGOjOMjLVCPKakBffURooKzvenzr6bkP3VUijvx2bxtQMPpbqoAuy/4RTmzDtRkcRESg xtko0AqboI8jxcIzpzAD05+sZ3DAymz/vpenXgLUMMl6prLO/fuMCwj+52JTQPzPtJOccTzrSTL0W 9Ff+Nbfb0iTRSNc2qj6yqJUxuGgr+kbVPdi3TLSMx6aVwT+D5KNuW1ls/qYviMSHrxj9n8F9mBp7Q 78X0X/xRNj37HF95WvnGiB8rUwTVxcBswYB8YbPFDAgbTFvkwKHRAU+FjYVnpTCnpfREWnVLflpGv twFTxntC1HsQrvpTFYcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXXrO-00000008ion-3NI9; Thu, 11 Jun 2026 05:21:46 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXXrM-00000008ioN-18mP; Thu, 11 Jun 2026 05:21:45 +0000 From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1781155298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pxZrj3HZL3fhz45xiVff8+rxIRxk0wNsp5NDbhPArlI=; b=aQzCTui0vIILvBLiJ6c+wEedWOf1pg+UetUx3mJQd/3OCbhPCyC/7p99cIGbjKgoJbxeMJ RvZqYgQwQFmC5CqTD+p42o+nd8/IV56U9kBsGlgsljW4/EmiHlyE08zJwlpzKtucjsQTH2 rEJEjOzYg4y7RDE+33fQm7bKo99nmPtAfJtfGnHRx8CfIAXiBKPibOszPxJ5R9VMvrAzqv cRKzAmPGIbpXjmJYkNqeuRTchJRuKCXXrSf/oOJdgegFvGyzXK6jp82DFjbqWEtEXJ4e+C Ed5pEg0YR/GG/tIVoc+km7DO9PUvOfGDB+PARYYG7MGDLtyslxaUlED8pLbDSw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1781155298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pxZrj3HZL3fhz45xiVff8+rxIRxk0wNsp5NDbhPArlI=; b=fHWDIlZdzOiLKfXOL42qehPTjVZemfYb8XJAOT676l7OxGd2A/3JPDZzKUvv/Wqp1V95b2 AtIF3KGM8zBcLRBw== To: Charlie Jenkins Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 01/16] riscv: Introduce instruction table generation In-Reply-To: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-1-54b4736a1e77@gmail.com> <878q8m1j9y.fsf@yellow.woof> Date: Thu, 11 Jun 2026 07:21:37 +0200 Message-ID: <87se6tejoe.fsf@yellow.woof> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260610_222144_479110_88492435 X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Charlie Jenkins writes: > This is a weird one. The Ziclsd extension introduces it for RV32[1]. All > of the data is generated from the riscv-unified-db and because it is in > the Ziclsd extension, c.ld is included for 32-bit in the c.ld > description [2]. Oh :( We probably should amend the base spec to mention that. >> > + compressed_name=${name##c.*} >> ^^^^^^^^^^^^^^^ >> this name is misleading > > That's fair, I can rename it to be something like "compressed_inst"? My issue is that "compressed_name" indicates that it holds the compressed variant of the name. But it actually is empty if the instruction is compressed, otherwise it is the original instruction name. I am not sure what is a better name. Perhaps just inline this to the usage below. Nam _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E420A34CFAB; Thu, 11 Jun 2026 05:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781155306; cv=none; b=gAq9g7qaqfheFHAIIIJs5W8vMzsFBck3ZUSHppJQFTP2czJIa9X/4n6HsOuz0Rbcp5rP2JjDOVQYcFW+6NWX+yPT03rX+ka+pBksIsjCpMYvIN9EjkMghddU6qVl5++KtJ8NknehVXLNrGaOWTZ8lhsYt9RcBwwb6D73MhVGyeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781155306; c=relaxed/simple; bh=i/JsgUYCntCG1YQqZsG70gRHrs+EAW6ILhqG6XZySuQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WGQp3RBLpotG5lITER82ALXAbv6a+oqQ95C8MuiSj7FH/nFko4l/gDW4MxC7BedE9ElYLkBFsSASQ/nhqbmtXb9jixyfQM4+um4kE2Oh+mrf7YegQp+niutQIafadH1njRAdoPz5wM+Ftld3f6uMdei9KJdoKaLWh1s6f8TEOt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=aQzCTui0; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=fHWDIlZd; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="aQzCTui0"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="fHWDIlZd" From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1781155298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pxZrj3HZL3fhz45xiVff8+rxIRxk0wNsp5NDbhPArlI=; b=aQzCTui0vIILvBLiJ6c+wEedWOf1pg+UetUx3mJQd/3OCbhPCyC/7p99cIGbjKgoJbxeMJ RvZqYgQwQFmC5CqTD+p42o+nd8/IV56U9kBsGlgsljW4/EmiHlyE08zJwlpzKtucjsQTH2 rEJEjOzYg4y7RDE+33fQm7bKo99nmPtAfJtfGnHRx8CfIAXiBKPibOszPxJ5R9VMvrAzqv cRKzAmPGIbpXjmJYkNqeuRTchJRuKCXXrSf/oOJdgegFvGyzXK6jp82DFjbqWEtEXJ4e+C Ed5pEg0YR/GG/tIVoc+km7DO9PUvOfGDB+PARYYG7MGDLtyslxaUlED8pLbDSw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1781155298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pxZrj3HZL3fhz45xiVff8+rxIRxk0wNsp5NDbhPArlI=; b=fHWDIlZdzOiLKfXOL42qehPTjVZemfYb8XJAOT676l7OxGd2A/3JPDZzKUvv/Wqp1V95b2 AtIF3KGM8zBcLRBw== To: Charlie Jenkins Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 01/16] riscv: Introduce instruction table generation In-Reply-To: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-1-54b4736a1e77@gmail.com> <878q8m1j9y.fsf@yellow.woof> Date: Thu, 11 Jun 2026 07:21:37 +0200 Message-ID: <87se6tejoe.fsf@yellow.woof> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Charlie Jenkins writes: > This is a weird one. The Ziclsd extension introduces it for RV32[1]. All > of the data is generated from the riscv-unified-db and because it is in > the Ziclsd extension, c.ld is included for 32-bit in the c.ld > description [2]. Oh :( We probably should amend the base spec to mention that. >> > + compressed_name=${name##c.*} >> ^^^^^^^^^^^^^^^ >> this name is misleading > > That's fair, I can rename it to be something like "compressed_inst"? My issue is that "compressed_name" indicates that it holds the compressed variant of the name. But it actually is empty if the instruction is compressed, otherwise it is the original instruction name. I am not sure what is a better name. Perhaps just inline this to the usage below. Nam