From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74CF23AFCEB; Thu, 28 May 2026 09:09:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779959393; cv=none; b=C5aQ0gQP6KecnzFHrQM7tCVqo6NnIArc46Y0usxr484XiAC8+putviUkUFzLTzAXA9Ctf2DDg20e3SnO33rj4aqoQT1Z/dDjV9X1VauWQy0As+rnsLDG+DbRP7RsSmTD4lY/PtfyM8FOqGj0L+mdtvBuJweD/SiDuR/k7zqR3rc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779959393; c=relaxed/simple; bh=zQP0c+jgi886i4XR5PYV8viZkX45ujM6jT1H8LAhalQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=hJvvIVQYrX1Zra/jX6j82LN8WHkOJnDZrX+cDhcdJR6nKw0uQDMO+L3re5C9xoszbg1hvcobgxevwvQHdHxdQJpNgnV1D8zd4oVdCJAMmaZy+oUkmdoCTHzhD0n8mGbwH9vm/fJwgRyHNzTd7RyuEGJHgfMIRZ8fv2W/HukZAMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=JbpICHl6; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="JbpICHl6" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 7A8DDC62445; Thu, 28 May 2026 09:09:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4EE8760495; Thu, 28 May 2026 09:09:49 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id AB12A10888CB6; Thu, 28 May 2026 11:09:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1779959388; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=BZ7YWBPJ73LaBuaYlU4y3harXsDdWT2FPUtyurIEQtI=; b=JbpICHl6Nv927vwgUexKS/+76lFTSRksmGdqfNyprlDOkbC/8IbCvnZbFusWMZeBVDhU6h Pnl7JPuEp2YEvkypY1BsE5qi+UO4KBck2P6tsi+PK6Y44xnf6VELH6dlg/s5QkENfYqH5d /FdLte0sUItMcL4g2AK6bTvx64RiH8FpUmyrZUzUgNmfpa3cJI1QJX3UFfYBnaoAm2w/Lx kbZqYUHct2NjQPXWP4DIlkUPUZaELr/6mjin88ag16WPr33VKAPBplIGJtVyDJD8Y/QnOQ /h8aeoUSa5GxIeZIuq9Ka9PJOiMVMi+jyZ3RJ5n8l/i85lCtD7pIbWJhu2SRag== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 10/13] spi: cadence-quadspi: enable PHY for direct reads and indirect writes In-Reply-To: <20260527175527.2247679-11-s-k6@ti.com> (Santhosh Kumar K.'s message of "Wed, 27 May 2026 23:25:24 +0530") References: <20260527175527.2247679-1-s-k6@ti.com> <20260527175527.2247679-11-s-k6@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Thu, 28 May 2026 11:09:44 +0200 Message-ID: <87se7bgasn.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 27/05/2026 at 23:25:24 +0530, Santhosh Kumar K wrote: > After PHY tuning completes, data transfers still use the default > read-capture path. The PHY pipeline must be activated around each > eligible transfer to benefit from the calibrated delay settings. > > Add cqspi_phy_enable() to toggle PHY mode. Enabling sets the calibrated > read-capture delay, asserts PHY_EN and PHY_PIPELINE, and decrements the > dummy cycle count by one since the PHY pipeline absorbs that latency. > Disabling reverses all three. Returns cqspi_wait_idle() so callers can > abort if the controller stalls on enable; disable is best-effort. > > Split cqspi_direct_read_execute() so PHY-eligible reads run DMA over the > 16-byte-aligned middle section with PHY active, while unaligned head and > tail bytes are transferred without PHY. PHY is used when use_phy is set, > the transfer exceeds 16 bytes, and the frequency matches the tuned rate. > cqspi_memcpy_fromio() handles small and non-DMA-able transfers, with > special handling for 8D-8D-8D to ensure 2-byte-aligned I/O accesses. > > For indirect writes, PHY is enabled for transfers of at least 1 KB kiB :-) > where the setup overhead is amortized. > > Signed-off-by: Santhosh Kumar K > --- > drivers/spi/spi-cadence-quadspi.c | 181 ++++++++++++++++++++++++++++-- > 1 file changed, 171 insertions(+), 10 deletions(-) > > diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-= quadspi.c > index 72208d376305..80e7c572ab80 100644 > --- a/drivers/spi/spi-cadence-quadspi.c > +++ b/drivers/spi/spi-cadence-quadspi.c > @@ -564,6 +564,61 @@ static void cqspi_readdata_capture(struct cqspi_st *= cqspi, const bool bypass, > writel(reg, reg_base + CQSPI_REG_READCAPTURE); > } >=20=20 > +static int cqspi_phy_enable(struct cqspi_flash_pdata *f_pdata, bool > enable) I'm fine with the logic, just the naming is very "TI" specific here. Can we name the helper "cqspi_tune_phy(f_pdata, enable)"? [...] > static int cqspi_exec_flash_cmd(struct cqspi_st *cqspi, unsigned int reg) > { > void __iomem *reg_base =3D cqspi->iobase; > @@ -1191,6 +1246,7 @@ static int cqspi_indirect_write_execute(struct cqsp= i_flash_pdata *f_pdata, > void __iomem *reg_base =3D cqspi->iobase; > unsigned int remaining =3D n_tx; > unsigned int write_bytes; > + bool use_phy_write; > int ret; >=20=20 > if (!refcount_read(&cqspi->refcount)) > @@ -1226,6 +1282,15 @@ static int cqspi_indirect_write_execute(struct cqs= pi_flash_pdata *f_pdata, > if (cqspi->apb_ahb_hazard) > readl(reg_base + CQSPI_REG_INDIRECTWR); >=20=20 > + /* Use PHY only for large writes where setup overhead is amortized */ > + use_phy_write =3D n_tx >=3D SZ_1K && f_pdata->use_phy; Maybe also "f_pdata->use_tuned_phy? > + if (use_phy_write) { > + ret =3D cqspi_phy_enable(f_pdata, true); > + if (ret) > + goto failwr; > + } > + > while (remaining > 0) { > size_t write_words, mod_bytes; >=20=20 > @@ -1266,6 +1331,9 @@ static int cqspi_indirect_write_execute(struct cqsp= i_flash_pdata *f_pdata, > goto failwr; > } >=20=20 > + if (use_phy_write) > + cqspi_phy_enable(f_pdata, false); > + > /* Disable interrupt. */ > writel(0, reg_base + CQSPI_REG_IRQMASK); >=20=20 > @@ -1277,6 +1345,9 @@ static int cqspi_indirect_write_execute(struct cqsp= i_flash_pdata *f_pdata, > return 0; >=20=20 > failwr: > + if (use_phy_write) > + cqspi_phy_enable(f_pdata, false); > + > /* Disable interrupt. */ > writel(0, reg_base + CQSPI_REG_IRQMASK); >=20=20 > @@ -1448,8 +1519,15 @@ static void cqspi_rx_dma_callback(void *param) > complete(&cqspi->rx_dma_complete); > } >=20=20 > -static int cqspi_direct_read_execute(struct cqspi_flash_pdata *f_pdata, > - u_char *buf, loff_t from, size_t len) > +static bool cqspi_use_phy(struct cqspi_flash_pdata *f_pdata, > + const struct spi_mem_op *op) > +{ > + return f_pdata->use_phy && op->data.nbytes > 16 && Why is the check looking for 16 here, and 1kiB above? > + op->max_freq =3D=3D f_pdata->max_clk_rate; > +} > + > +static int cqspi_direct_read_dma(struct cqspi_flash_pdata *f_pdata, u_ch= ar *buf, > + loff_t from, size_t len) > { > struct cqspi_st *cqspi =3D f_pdata->cqspi; > struct device *dev =3D &cqspi->pdev->dev; > @@ -1461,19 +1539,14 @@ static int cqspi_direct_read_execute(struct cqspi= _flash_pdata *f_pdata, > dma_addr_t dma_dst; > struct device *ddev; >=20=20 > - if (!cqspi->rx_chan || !virt_addr_valid(buf)) { > - memcpy_fromio(buf, cqspi->ahb_base + from, len); > - return 0; > - } This (and changes below) don't seem to be directly related to the PHY addition, could we have those changes done in a separated patch, before introducing PHY tuning use? > - > ddev =3D cqspi->rx_chan->device->dev; > dma_dst =3D dma_map_single(ddev, buf, len, DMA_FROM_DEVICE); > if (dma_mapping_error(ddev, dma_dst)) { > dev_err(dev, "dma mapping failed\n"); > return -ENOMEM; > } > - tx =3D dmaengine_prep_dma_memcpy(cqspi->rx_chan, dma_dst, dma_src, > - len, flags); > + tx =3D dmaengine_prep_dma_memcpy(cqspi->rx_chan, dma_dst, dma_src, len, > + flags); Not related to the change, isn't it? > if (!tx) { > dev_err(dev, "device_prep_dma_memcpy error\n"); > ret =3D -EIO; > @@ -1507,6 +1580,94 @@ static int cqspi_direct_read_execute(struct cqspi_= flash_pdata *f_pdata, > return ret; > } >=20=20 [...] > static ssize_t cqspi_read(struct cqspi_flash_pdata *f_pdata, > const struct spi_mem_op *op) > { > @@ -1524,7 +1685,7 @@ static ssize_t cqspi_read(struct cqspi_flash_pdata = *f_pdata, >=20=20 > if ((cqspi->use_direct_mode && ((from + len) <=3D cqspi->ahb_size)) || > (cqspi->ddata && cqspi->ddata->quirks & CQSPI_NO_INDIRECT_MODE)) > - return cqspi_direct_read_execute(f_pdata, buf, from, len); > + return cqspi_direct_read_execute(f_pdata, op); This change could also be done in a different commit. >=20=20 > if (cqspi->use_dma_read && ddata && ddata->indirect_read_dma && > virt_addr_valid(buf) && ((dma_align & CQSPI_DMA_UNALIGN) =3D=3D 0)) Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8634ACD5BD5 for ; Thu, 28 May 2026 09:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=57S733s7+I+MlEqz+9wrijOE1g1g6Nx5sxn/+y94icM=; b=vQD60m/zNehx/+ 2fNt1oYttvoRGHJ7+EecfDMwi5WHTgp1rhrjLJ7nMoxBfuX2xhAmbhWJ7R4mJZTri1aovbFu4XZZP RpBWQ9gOCJOfTJcP9P9wK72SdXOCi4gqunlmRlu6O4NuXn1zl0CKi/YeN6HSXAhyh1ApGcZs1Ecn1 jvvKAqLJZlBGHURXdB8Z/oWIqnhCzuUetDpcfUlNAHooeGDr/yZiepzcvdga9BT7YYnTmkpbZ9x0Y 76o/5CPvtndvNHVYR2oTjx4+DeAf7O/lKRgT/In17cUOCNxNO6hJ/+65caJTq72Zt0xJITyeXifCl uNR578Yh5H0WRtnECITg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSWkW-00000005TNa-0L04; Thu, 28 May 2026 09:09:56 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSWkS-00000005TMx-0KCq for linux-mtd@lists.infradead.org; Thu, 28 May 2026 09:09:55 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 7E9B94E42D77; Thu, 28 May 2026 09:09:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4EE8760495; Thu, 28 May 2026 09:09:49 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id AB12A10888CB6; Thu, 28 May 2026 11:09:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1779959388; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=BZ7YWBPJ73LaBuaYlU4y3harXsDdWT2FPUtyurIEQtI=; b=JbpICHl6Nv927vwgUexKS/+76lFTSRksmGdqfNyprlDOkbC/8IbCvnZbFusWMZeBVDhU6h Pnl7JPuEp2YEvkypY1BsE5qi+UO4KBck2P6tsi+PK6Y44xnf6VELH6dlg/s5QkENfYqH5d /FdLte0sUItMcL4g2AK6bTvx64RiH8FpUmyrZUzUgNmfpa3cJI1QJX3UFfYBnaoAm2w/Lx kbZqYUHct2NjQPXWP4DIlkUPUZaELr/6mjin88ag16WPr33VKAPBplIGJtVyDJD8Y/QnOQ /h8aeoUSa5GxIeZIuq9Ka9PJOiMVMi+jyZ3RJ5n8l/i85lCtD7pIbWJhu2SRag== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 10/13] spi: cadence-quadspi: enable PHY for direct reads and indirect writes In-Reply-To: <20260527175527.2247679-11-s-k6@ti.com> (Santhosh Kumar K.'s message of "Wed, 27 May 2026 23:25:24 +0530") References: <20260527175527.2247679-1-s-k6@ti.com> <20260527175527.2247679-11-s-k6@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Thu, 28 May 2026 11:09:44 +0200 Message-ID: <87se7bgasn.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260528_020952_382379_EF77F092 X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gMjcvMDUvMjAyNiBhdCAyMzoyNToyNCArMDUzMCwgU2FudGhvc2ggS3VtYXIgSyA8cy1rNkB0 aS5jb20+IHdyb3RlOgoKPiBBZnRlciBQSFkgdHVuaW5nIGNvbXBsZXRlcywgZGF0YSB0cmFuc2Zl cnMgc3RpbGwgdXNlIHRoZSBkZWZhdWx0Cj4gcmVhZC1jYXB0dXJlIHBhdGguIFRoZSBQSFkgcGlw ZWxpbmUgbXVzdCBiZSBhY3RpdmF0ZWQgYXJvdW5kIGVhY2gKPiBlbGlnaWJsZSB0cmFuc2ZlciB0 byBiZW5lZml0IGZyb20gdGhlIGNhbGlicmF0ZWQgZGVsYXkgc2V0dGluZ3MuCj4KPiBBZGQgY3Fz cGlfcGh5X2VuYWJsZSgpIHRvIHRvZ2dsZSBQSFkgbW9kZS4gRW5hYmxpbmcgc2V0cyB0aGUgY2Fs aWJyYXRlZAo+IHJlYWQtY2FwdHVyZSBkZWxheSwgYXNzZXJ0cyBQSFlfRU4gYW5kIFBIWV9QSVBF TElORSwgYW5kIGRlY3JlbWVudHMgdGhlCj4gZHVtbXkgY3ljbGUgY291bnQgYnkgb25lIHNpbmNl IHRoZSBQSFkgcGlwZWxpbmUgYWJzb3JicyB0aGF0IGxhdGVuY3kuCj4gRGlzYWJsaW5nIHJldmVy c2VzIGFsbCB0aHJlZS4gUmV0dXJucyBjcXNwaV93YWl0X2lkbGUoKSBzbyBjYWxsZXJzIGNhbgo+ IGFib3J0IGlmIHRoZSBjb250cm9sbGVyIHN0YWxscyBvbiBlbmFibGU7IGRpc2FibGUgaXMgYmVz dC1lZmZvcnQuCj4KPiBTcGxpdCBjcXNwaV9kaXJlY3RfcmVhZF9leGVjdXRlKCkgc28gUEhZLWVs aWdpYmxlIHJlYWRzIHJ1biBETUEgb3ZlciB0aGUKPiAxNi1ieXRlLWFsaWduZWQgbWlkZGxlIHNl Y3Rpb24gd2l0aCBQSFkgYWN0aXZlLCB3aGlsZSB1bmFsaWduZWQgaGVhZCBhbmQKPiB0YWlsIGJ5 dGVzIGFyZSB0cmFuc2ZlcnJlZCB3aXRob3V0IFBIWS4gUEhZIGlzIHVzZWQgd2hlbiB1c2VfcGh5 IGlzIHNldCwKPiB0aGUgdHJhbnNmZXIgZXhjZWVkcyAxNiBieXRlcywgYW5kIHRoZSBmcmVxdWVu Y3kgbWF0Y2hlcyB0aGUgdHVuZWQgcmF0ZS4KPiBjcXNwaV9tZW1jcHlfZnJvbWlvKCkgaGFuZGxl cyBzbWFsbCBhbmQgbm9uLURNQS1hYmxlIHRyYW5zZmVycywgd2l0aAo+IHNwZWNpYWwgaGFuZGxp bmcgZm9yIDhELThELThEIHRvIGVuc3VyZSAyLWJ5dGUtYWxpZ25lZCBJL08gYWNjZXNzZXMuCj4K PiBGb3IgaW5kaXJlY3Qgd3JpdGVzLCBQSFkgaXMgZW5hYmxlZCBmb3IgdHJhbnNmZXJzIG9mIGF0 IGxlYXN0IDEgS0IKCmtpQiA6LSkKCj4gd2hlcmUgdGhlIHNldHVwIG92ZXJoZWFkIGlzIGFtb3J0 aXplZC4KPgo+IFNpZ25lZC1vZmYtYnk6IFNhbnRob3NoIEt1bWFyIEsgPHMtazZAdGkuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL3NwaS9zcGktY2FkZW5jZS1xdWFkc3BpLmMgfCAxODEgKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNzEgaW5zZXJ0aW9ucygr KSwgMTAgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zcGkvc3BpLWNhZGVu Y2UtcXVhZHNwaS5jIGIvZHJpdmVycy9zcGkvc3BpLWNhZGVuY2UtcXVhZHNwaS5jCj4gaW5kZXgg NzIyMDhkMzc2MzA1Li44MGU3YzU3MmFiODAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9zcGkvc3Bp LWNhZGVuY2UtcXVhZHNwaS5jCj4gKysrIGIvZHJpdmVycy9zcGkvc3BpLWNhZGVuY2UtcXVhZHNw aS5jCj4gQEAgLTU2NCw2ICs1NjQsNjEgQEAgc3RhdGljIHZvaWQgY3FzcGlfcmVhZGRhdGFfY2Fw dHVyZShzdHJ1Y3QgY3FzcGlfc3QgKmNxc3BpLCBjb25zdCBib29sIGJ5cGFzcywKPiAgCXdyaXRl bChyZWcsIHJlZ19iYXNlICsgQ1FTUElfUkVHX1JFQURDQVBUVVJFKTsKPiAgfQo+ICAKPiArc3Rh dGljIGludCBjcXNwaV9waHlfZW5hYmxlKHN0cnVjdCBjcXNwaV9mbGFzaF9wZGF0YSAqZl9wZGF0 YSwgYm9vbAo+IGVuYWJsZSkKCkknbSBmaW5lIHdpdGggdGhlIGxvZ2ljLCBqdXN0IHRoZSBuYW1p bmcgaXMgdmVyeSAiVEkiIHNwZWNpZmljIGhlcmUuIENhbgp3ZSBuYW1lIHRoZSBoZWxwZXIgImNx c3BpX3R1bmVfcGh5KGZfcGRhdGEsIGVuYWJsZSkiPwoKWy4uLl0KCj4gIHN0YXRpYyBpbnQgY3Fz cGlfZXhlY19mbGFzaF9jbWQoc3RydWN0IGNxc3BpX3N0ICpjcXNwaSwgdW5zaWduZWQgaW50IHJl ZykKPiAgewo+ICAJdm9pZCBfX2lvbWVtICpyZWdfYmFzZSA9IGNxc3BpLT5pb2Jhc2U7Cj4gQEAg LTExOTEsNiArMTI0Niw3IEBAIHN0YXRpYyBpbnQgY3FzcGlfaW5kaXJlY3Rfd3JpdGVfZXhlY3V0 ZShzdHJ1Y3QgY3FzcGlfZmxhc2hfcGRhdGEgKmZfcGRhdGEsCj4gIAl2b2lkIF9faW9tZW0gKnJl Z19iYXNlID0gY3FzcGktPmlvYmFzZTsKPiAgCXVuc2lnbmVkIGludCByZW1haW5pbmcgPSBuX3R4 Owo+ICAJdW5zaWduZWQgaW50IHdyaXRlX2J5dGVzOwo+ICsJYm9vbCB1c2VfcGh5X3dyaXRlOwo+ ICAJaW50IHJldDsKPiAgCj4gIAlpZiAoIXJlZmNvdW50X3JlYWQoJmNxc3BpLT5yZWZjb3VudCkp Cj4gQEAgLTEyMjYsNiArMTI4MiwxNSBAQCBzdGF0aWMgaW50IGNxc3BpX2luZGlyZWN0X3dyaXRl X2V4ZWN1dGUoc3RydWN0IGNxc3BpX2ZsYXNoX3BkYXRhICpmX3BkYXRhLAo+ICAJaWYgKGNxc3Bp LT5hcGJfYWhiX2hhemFyZCkKPiAgCQlyZWFkbChyZWdfYmFzZSArIENRU1BJX1JFR19JTkRJUkVD VFdSKTsKPiAgCj4gKwkvKiBVc2UgUEhZIG9ubHkgZm9yIGxhcmdlIHdyaXRlcyB3aGVyZSBzZXR1 cCBvdmVyaGVhZCBpcyBhbW9ydGl6ZWQgKi8KPiArCXVzZV9waHlfd3JpdGUgPSBuX3R4ID49IFNa XzFLICYmIGZfcGRhdGEtPnVzZV9waHk7CgpNYXliZSBhbHNvICJmX3BkYXRhLT51c2VfdHVuZWRf cGh5PwoKPiArCWlmICh1c2VfcGh5X3dyaXRlKSB7Cj4gKwkJcmV0ID0gY3FzcGlfcGh5X2VuYWJs ZShmX3BkYXRhLCB0cnVlKTsKPiArCQlpZiAocmV0KQo+ICsJCQlnb3RvIGZhaWx3cjsKPiArCX0K PiArCj4gIAl3aGlsZSAocmVtYWluaW5nID4gMCkgewo+ICAJCXNpemVfdCB3cml0ZV93b3Jkcywg bW9kX2J5dGVzOwo+ICAKPiBAQCAtMTI2Niw2ICsxMzMxLDkgQEAgc3RhdGljIGludCBjcXNwaV9p bmRpcmVjdF93cml0ZV9leGVjdXRlKHN0cnVjdCBjcXNwaV9mbGFzaF9wZGF0YSAqZl9wZGF0YSwK PiAgCQlnb3RvIGZhaWx3cjsKPiAgCX0KPiAgCj4gKwlpZiAodXNlX3BoeV93cml0ZSkKPiArCQlj cXNwaV9waHlfZW5hYmxlKGZfcGRhdGEsIGZhbHNlKTsKPiArCj4gIAkvKiBEaXNhYmxlIGludGVy cnVwdC4gKi8KPiAgCXdyaXRlbCgwLCByZWdfYmFzZSArIENRU1BJX1JFR19JUlFNQVNLKTsKPiAg Cj4gQEAgLTEyNzcsNiArMTM0NSw5IEBAIHN0YXRpYyBpbnQgY3FzcGlfaW5kaXJlY3Rfd3JpdGVf ZXhlY3V0ZShzdHJ1Y3QgY3FzcGlfZmxhc2hfcGRhdGEgKmZfcGRhdGEsCj4gIAlyZXR1cm4gMDsK PiAgCj4gIGZhaWx3cjoKPiArCWlmICh1c2VfcGh5X3dyaXRlKQo+ICsJCWNxc3BpX3BoeV9lbmFi bGUoZl9wZGF0YSwgZmFsc2UpOwo+ICsKPiAgCS8qIERpc2FibGUgaW50ZXJydXB0LiAqLwo+ICAJ d3JpdGVsKDAsIHJlZ19iYXNlICsgQ1FTUElfUkVHX0lSUU1BU0spOwo+ICAKPiBAQCAtMTQ0OCw4 ICsxNTE5LDE1IEBAIHN0YXRpYyB2b2lkIGNxc3BpX3J4X2RtYV9jYWxsYmFjayh2b2lkICpwYXJh bSkKPiAgCWNvbXBsZXRlKCZjcXNwaS0+cnhfZG1hX2NvbXBsZXRlKTsKPiAgfQo+ICAKPiAtc3Rh dGljIGludCBjcXNwaV9kaXJlY3RfcmVhZF9leGVjdXRlKHN0cnVjdCBjcXNwaV9mbGFzaF9wZGF0 YSAqZl9wZGF0YSwKPiAtCQkJCSAgICAgdV9jaGFyICpidWYsIGxvZmZfdCBmcm9tLCBzaXplX3Qg bGVuKQo+ICtzdGF0aWMgYm9vbCBjcXNwaV91c2VfcGh5KHN0cnVjdCBjcXNwaV9mbGFzaF9wZGF0 YSAqZl9wZGF0YSwKPiArCQkJICBjb25zdCBzdHJ1Y3Qgc3BpX21lbV9vcCAqb3ApCj4gK3sKPiAr CXJldHVybiBmX3BkYXRhLT51c2VfcGh5ICYmIG9wLT5kYXRhLm5ieXRlcyA+IDE2ICYmCgpXaHkg aXMgdGhlIGNoZWNrIGxvb2tpbmcgZm9yIDE2IGhlcmUsIGFuZCAxa2lCIGFib3ZlPwoKPiArCSAg ICAgICBvcC0+bWF4X2ZyZXEgPT0gZl9wZGF0YS0+bWF4X2Nsa19yYXRlOwo+ICt9Cj4gKwo+ICtz dGF0aWMgaW50IGNxc3BpX2RpcmVjdF9yZWFkX2RtYShzdHJ1Y3QgY3FzcGlfZmxhc2hfcGRhdGEg KmZfcGRhdGEsIHVfY2hhciAqYnVmLAo+ICsJCQkJIGxvZmZfdCBmcm9tLCBzaXplX3QgbGVuKQo+ ICB7Cj4gIAlzdHJ1Y3QgY3FzcGlfc3QgKmNxc3BpID0gZl9wZGF0YS0+Y3FzcGk7Cj4gIAlzdHJ1 Y3QgZGV2aWNlICpkZXYgPSAmY3FzcGktPnBkZXYtPmRldjsKPiBAQCAtMTQ2MSwxOSArMTUzOSwx NCBAQCBzdGF0aWMgaW50IGNxc3BpX2RpcmVjdF9yZWFkX2V4ZWN1dGUoc3RydWN0IGNxc3BpX2Zs YXNoX3BkYXRhICpmX3BkYXRhLAo+ICAJZG1hX2FkZHJfdCBkbWFfZHN0Owo+ICAJc3RydWN0IGRl dmljZSAqZGRldjsKPiAgCj4gLQlpZiAoIWNxc3BpLT5yeF9jaGFuIHx8ICF2aXJ0X2FkZHJfdmFs aWQoYnVmKSkgewo+IC0JCW1lbWNweV9mcm9taW8oYnVmLCBjcXNwaS0+YWhiX2Jhc2UgKyBmcm9t LCBsZW4pOwo+IC0JCXJldHVybiAwOwo+IC0JfQoKVGhpcyAoYW5kIGNoYW5nZXMgYmVsb3cpIGRv bid0IHNlZW0gdG8gYmUgZGlyZWN0bHkgcmVsYXRlZCB0byB0aGUgUEhZCmFkZGl0aW9uLCBjb3Vs ZCB3ZSBoYXZlIHRob3NlIGNoYW5nZXMgZG9uZSBpbiBhIHNlcGFyYXRlZCBwYXRjaCwgYmVmb3Jl CmludHJvZHVjaW5nIFBIWSB0dW5pbmcgdXNlPwoKPiAtCj4gIAlkZGV2ID0gY3FzcGktPnJ4X2No YW4tPmRldmljZS0+ZGV2Owo+ICAJZG1hX2RzdCA9IGRtYV9tYXBfc2luZ2xlKGRkZXYsIGJ1Ziwg bGVuLCBETUFfRlJPTV9ERVZJQ0UpOwo+ICAJaWYgKGRtYV9tYXBwaW5nX2Vycm9yKGRkZXYsIGRt YV9kc3QpKSB7Cj4gIAkJZGV2X2VycihkZXYsICJkbWEgbWFwcGluZyBmYWlsZWRcbiIpOwo+ICAJ CXJldHVybiAtRU5PTUVNOwo+ICAJfQo+IC0JdHggPSBkbWFlbmdpbmVfcHJlcF9kbWFfbWVtY3B5 KGNxc3BpLT5yeF9jaGFuLCBkbWFfZHN0LCBkbWFfc3JjLAo+IC0JCQkJICAgICAgIGxlbiwgZmxh Z3MpOwo+ICsJdHggPSBkbWFlbmdpbmVfcHJlcF9kbWFfbWVtY3B5KGNxc3BpLT5yeF9jaGFuLCBk bWFfZHN0LCBkbWFfc3JjLCBsZW4sCj4gKwkJCQkgICAgICAgZmxhZ3MpOwoKTm90IHJlbGF0ZWQg dG8gdGhlIGNoYW5nZSwgaXNuJ3QgaXQ/Cgo+ICAJaWYgKCF0eCkgewo+ICAJCWRldl9lcnIoZGV2 LCAiZGV2aWNlX3ByZXBfZG1hX21lbWNweSBlcnJvclxuIik7Cj4gIAkJcmV0ID0gLUVJTzsKPiBA QCAtMTUwNyw2ICsxNTgwLDk0IEBAIHN0YXRpYyBpbnQgY3FzcGlfZGlyZWN0X3JlYWRfZXhlY3V0 ZShzdHJ1Y3QgY3FzcGlfZmxhc2hfcGRhdGEgKmZfcGRhdGEsCj4gIAlyZXR1cm4gcmV0Owo+ICB9 Cj4gIAoKWy4uLl0KCj4gIHN0YXRpYyBzc2l6ZV90IGNxc3BpX3JlYWQoc3RydWN0IGNxc3BpX2Zs YXNoX3BkYXRhICpmX3BkYXRhLAo+ICAJCQkgIGNvbnN0IHN0cnVjdCBzcGlfbWVtX29wICpvcCkK PiAgewo+IEBAIC0xNTI0LDcgKzE2ODUsNyBAQCBzdGF0aWMgc3NpemVfdCBjcXNwaV9yZWFkKHN0 cnVjdCBjcXNwaV9mbGFzaF9wZGF0YSAqZl9wZGF0YSwKPiAgCj4gIAlpZiAoKGNxc3BpLT51c2Vf ZGlyZWN0X21vZGUgJiYgKChmcm9tICsgbGVuKSA8PSBjcXNwaS0+YWhiX3NpemUpKSB8fAo+ICAJ ICAgIChjcXNwaS0+ZGRhdGEgJiYgY3FzcGktPmRkYXRhLT5xdWlya3MgJiBDUVNQSV9OT19JTkRJ UkVDVF9NT0RFKSkKPiAtCQlyZXR1cm4gY3FzcGlfZGlyZWN0X3JlYWRfZXhlY3V0ZShmX3BkYXRh LCBidWYsIGZyb20sIGxlbik7Cj4gKwkJcmV0dXJuIGNxc3BpX2RpcmVjdF9yZWFkX2V4ZWN1dGUo Zl9wZGF0YSwgb3ApOwoKVGhpcyBjaGFuZ2UgY291bGQgYWxzbyBiZSBkb25lIGluIGEgZGlmZmVy ZW50IGNvbW1pdC4KCj4gIAo+ICAJaWYgKGNxc3BpLT51c2VfZG1hX3JlYWQgJiYgZGRhdGEgJiYg ZGRhdGEtPmluZGlyZWN0X3JlYWRfZG1hICYmCj4gIAkgICAgdmlydF9hZGRyX3ZhbGlkKGJ1Zikg JiYgKChkbWFfYWxpZ24gJiBDUVNQSV9ETUFfVU5BTElHTikgPT0gMCkpCgpUaGFua3MsCk1pcXXD qGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg==