From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AD7CCD4851 for ; Tue, 19 May 2026 10:58:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wPI9h-00081p-Vy; Tue, 19 May 2026 06:58:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wPI9T-0007y0-Lh for qemu-arm@nongnu.org; Tue, 19 May 2026 06:58:20 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wPI9R-00016l-QE for qemu-arm@nongnu.org; Tue, 19 May 2026 06:58:19 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso28785065e9.2 for ; Tue, 19 May 2026 03:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779188295; x=1779793095; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=th+7m4e1V2ZxPwz3Px/qnbJ7ANB0j47Cvdm2V2sKVJ8=; b=DOkIzr5QX7JbZFD7ImfIBdowVwEcYpRVzpfxDYp3WRwWTLo5ZdeZlVMTHY2WxmHy/i ZfXXxC8jcQ4hE7woiwJrRbJdiNdKIBsHocX+gfIZ0M1LensK4A2S7I461DFdAc5ht3TG 1g5MIiXBdYbG5ily1b7+CegHKKn0Yba3uMBjQN+uacVhw1UTVM3iOwLPeN0JOXVostLm WGuE64ypImggCyV3MK6D9i1jaWlcFaixDl8DA7NirJvsb/BVknsrdpTVD1GswEi1EiOg g8nhQp9rv/6h+auzsiBm+OdfFHMIeQbR9Dmwp/7IK1h9sREwvzL/h7rRsmF38i6Fuxh9 L25w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779188295; x=1779793095; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=th+7m4e1V2ZxPwz3Px/qnbJ7ANB0j47Cvdm2V2sKVJ8=; b=ru3JvI4OMFKjbubVMvq7eHjgpDOhezZhgsmmC5d4huOQS9FrjR2EQHur/rO+d2GCBb BCZ+QlLW+eLPolJzrIJjUh8wRK4K/PL6PJrGXLHTtz25fmlX0CZULztjJpkiVG6757yo NIr0itGkkbYc4IQrK7e18vZYItP9oAoCSqzgOQZZqLtkVHESw10XehUkyAI4IxVcPuLL vVfmztb2E1WK3lRIObGPcZPwoX47+wEiukHbiwq7m6lq6AhUkifz2vgabRTo8ZvCeWbU JhAcnhzJ0OOj3H8dwJD2Me8SsD4FFJVPRKVHy80OScaBDCY+6x7sGYYsA5OOhMrag1Ew 4Dfw== X-Forwarded-Encrypted: i=1; AFNElJ8BsYuSPD3X+W4GrXTK37QyLRjvzrmwk37mModF4MdgTkpH86hDVq1fq/wjRAc/t6z7AlyVLZvsBw==@nongnu.org X-Gm-Message-State: AOJu0YzbdP53jUp1RZfqZxk7z6KGcKn/ZYHH1GQWfNJAC6VamMPkZMdq 36VwUllP5fmkdtXpoaeIyjOLZC/6rLHYyTABKTLpiKw1BG1xoZrbrMz5DIF+ZAnWkC8= X-Gm-Gg: Acq92OFcCZMlQboZv5Cvxd5UAVj3lVqk5+NmWMivMtDPQpuRgm+f5MHroCFb03Me67b 4qKAWZFYw9OOyDzjqaVvPKI/YyRoyh3uNkvX8jzYJuz1QgxLx/rS1CDMpeSLlZwgM/Tg/mI3rHO agPbaGiL2H4QEjl2HM9WJhXPm/nxqtxCA2xD0KbZMNO+gQDnrU/4nGbMEsPbP043AP43HOZTRbr JAtfpNhjwP/PeUcZHZouSlsod+5/SZ36M88ehOweoNuJCsEcU0XQwk7YhvXJi28xzKARCC0TAnB 9yc6ihtxA0lmwEYwR17xdUx+fj9SkCzPZYveAYFwE2LXDvB66bqR8xNVbzYEUQDOXny+dbPnryl XWxs5RSnpF8PpOg2AFFgSRycTqs3geXIvFimOAZTmvP9WJBB3vADEUrLd8eZYyfIiaVXhDo04zv 3MBqD8KzLTLCWiQctB2h99Lvs= X-Received: by 2002:a05:600c:4fd4:b0:48a:581c:ead with SMTP id 5b1f17b1804b1-48fe60ed7b7mr265377945e9.10.1779188295032; Tue, 19 May 2026 03:58:15 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe537c516sm344405225e9.13.2026.05.19.03.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 03:58:14 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id A646C5F81D; Tue, 19 May 2026 11:58:13 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Lucas Amaral Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, dmitry.osipenko@collabora.com, marcandre.lureau@redhat.com, visitorckw@gmail.com Subject: Re: [PATCH v5 4/4] virtio-gpu: advertise VIRTIO_GPU_F_BLOB_ALIGNMENT In-Reply-To: <20260317182049.33848-5-lucaaamaral@gmail.com> (Lucas Amaral's message of "Tue, 17 Mar 2026 15:20:49 -0300") References: <20260317182049.33848-1-lucaaamaral@gmail.com> <20260317182049.33848-5-lucaaamaral@gmail.com> User-Agent: mu4e 1.14.1; emacs 30.1 Date: Tue, 19 May 2026 11:58:13 +0100 Message-ID: <87se7nbr96.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Lucas Amaral writes: > Set blob_alignment to the host page size so the guest kernel can > align blob BAR offsets accordingly, avoiding alignment mismatches > with the VMM's memory mapping API (e.g., hv_vm_map on macOS). > > Guest-side kernel support (drm_mm alignment) is pending upstream > Linux merge. > > Signed-off-by: Lucas Amaral > --- > hw/display/virtio-gpu.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c > index de7a86a7..44ae5034 100644 > --- a/hw/display/virtio-gpu.c > +++ b/hw/display/virtio-gpu.c > @@ -1532,6 +1532,14 @@ void virtio_gpu_device_realize(DeviceState *qdev, = Error **errp) > #endif > } >=20=20 > + /* > + * TODO: guest-side F_BLOB_ALIGNMENT support pending upstream Linux = merge > + * (Sergio Lopez's patches, Nov 2025). Until merged, the guest won't > + * negotiate this feature. The host advertises it per OASIS virtio s= pec. > + */ > + g->parent_obj.virtio_config.blob_alignment =3D > + cpu_to_le32(qemu_real_host_page_size()); > + Is it merged yet? > if (!virtio_gpu_base_device_realize(qdev, > virtio_gpu_handle_ctrl_cb, > virtio_gpu_handle_cursor_cb, --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro