Re: [PATCH v1] tests/qtest/migration: Fix A-B file build

[Fabiano Rosas <farosas@suse.de>]

Peter Xu <peterx@redhat.com> writes:

> On Wed, Apr 29, 2026 at 08:10:25PM -0300, Fabiano Rosas wrote:
>> diff --git a/tests/qtest/migration/bootfile.h b/tests/qtest/migration/bootfile.h
>> index 96e784b163..0ce5b34433 100644
>> --- a/tests/qtest/migration/bootfile.h
>> +++ b/tests/qtest/migration/bootfile.h
>> @@ -8,6 +8,15 @@
>>  #ifndef BOOTFILE_H
>>  #define BOOTFILE_H
>>  
>> +/*
>> + * This file is included from qtest, but also from the assembly code
>> + * that generates the header file containing the guest workload. Don't
>> + * expose the function declarations and non-standard types to it.
>> + */
>> +#ifdef __ASSEMBLER__
>> +#define MIGRATION_GUEST_CODE
>> +#endif
>
> Just to mention: this triggers a checkpatch warning (I only notice this
> when running checkpatch locally; CI is fine with warnings), which seems to
> be false positive.
>
> But still, I wonder whether we need this at all. IIUC we can also put those
> into a separate smaller header and include that here, then use that one for
> arch a-b-bios builds.
>
> Even if it will work, we can leave it for later.
>

I have a bunch of patches adding code into bootfile.c and consequently
bootfile.h for the stress.c and hugepages work I told you about. We can
discuss the header structure when I send them, if you don't mind.

>> +
>>  /* Common */
>>  #define TEST_MEM_PAGE_SIZE 4096
>>  
>> @@ -33,8 +42,10 @@
>>   */
>>  #define ARM_TEST_MAX_KERNEL_SIZE (512 * 1024)
>>  
>> +#ifndef MIGRATION_GUEST_CODE
>>  void bootfile_delete(void);
>>  char *bootfile_create(const char *arch, const char *dir, bool suspend_me);
>>  char *bootfile_get(void);
>> +#endif