From: Fabiano Rosas <farosas@suse.de>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: Alexander Mikhalitsyn <alexander@mihalicyn.com>,
peterx@redhat.com, Juraj Marcin <jmarcin@redhat.com>,
Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>
Subject: Re: [PATCH RFC v2 03/11] vmstate: Do not set size for VMS_ARRAY_OF_POINTER
Date: Fri, 27 Mar 2026 09:20:49 -0300 [thread overview]
Message-ID: <87se9lihum.fsf@suse.de> (raw)
In-Reply-To: <20260326210532.379027-4-peterx@redhat.com>
Peter Xu <peterx@redhat.com> writes:
> When VMS_ARRAY_OF_POINTER is specified, it means the vmstate field is an
> array of pointers.
>
> The size of the element is not relevant to whatever it is stored inside: it
> is always the host pointer size.
>
> Let's reserve the "size" field in this case for future use, update
> vmstate_size() so as to make it still work for array of pointers properly.
>
> When at this, provide rich documentation on how size / size_offset works in
> vmstate.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> Reviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2026-03-27 12:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 21:05 [PATCH RFC v2 00/11] vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC Peter Xu
2026-03-26 21:05 ` [PATCH RFC v2 01/11] vmstate: Pass in struct itself for VMSTATE_ARRAY_OF_POINTER Peter Xu
2026-03-27 12:19 ` Fabiano Rosas
2026-04-01 13:29 ` Philippe Mathieu-Daudé
2026-03-26 21:05 ` [PATCH RFC v2 02/11] vmstate: Pass in struct itself for VMSTATE_VARRAY_OF_POINTER_UINT32 Peter Xu
2026-03-27 12:19 ` Fabiano Rosas
2026-04-01 13:30 ` Philippe Mathieu-Daudé
2026-03-26 21:05 ` [PATCH RFC v2 03/11] vmstate: Do not set size for VMS_ARRAY_OF_POINTER Peter Xu
2026-03-27 12:20 ` Fabiano Rosas [this message]
2026-04-01 13:30 ` Philippe Mathieu-Daudé
2026-03-26 21:05 ` [PATCH RFC v2 04/11] vmstate: Update max_elems early and check field compressable once Peter Xu
2026-03-27 12:26 ` Fabiano Rosas
2026-04-01 13:17 ` Alexander Mikhalitsyn
2026-03-26 21:05 ` [PATCH RFC v2 05/11] vmstate: Rename VMS_NULLPTR_MARKER to VMS_MARKER_PTR_NULL Peter Xu
2026-03-27 12:27 ` Fabiano Rosas
2026-04-01 13:30 ` Philippe Mathieu-Daudé
2026-03-26 21:05 ` [PATCH RFC v2 06/11] vmstate: Introduce vmstate_save_field_with_vmdesc() Peter Xu
2026-03-27 12:27 ` Fabiano Rosas
2026-03-26 21:05 ` [PATCH RFC v2 07/11] vmstate: Allow vmstate_info_nullptr to emit non-NULL markers Peter Xu
2026-03-27 12:29 ` Fabiano Rosas
2026-04-01 13:19 ` Alexander Mikhalitsyn
2026-03-26 21:05 ` [PATCH RFC v2 08/11] vmstate: Implement load of ptr marker in vmstate core Peter Xu
2026-03-27 12:30 ` Fabiano Rosas
2026-04-01 13:21 ` Alexander Mikhalitsyn
2026-03-26 21:05 ` [PATCH RFC v2 09/11] vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC Peter Xu
2026-03-27 13:12 ` Fabiano Rosas
2026-03-27 14:15 ` Peter Xu
2026-03-27 14:18 ` Fabiano Rosas
2026-04-01 13:28 ` Alexander Mikhalitsyn
2026-03-26 21:05 ` [PATCH RFC v2 10/11] vmstate: Stop checking size for nullptr compression Peter Xu
2026-04-01 13:30 ` Alexander Mikhalitsyn
2026-03-26 21:05 ` [PATCH RFC v2 11/11] tests/unit/test-vmstate: add tests for VMS_ARRAY_OF_POINTER_AUTO_ALLOC Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87se9lihum.fsf@suse.de \
--to=farosas@suse.de \
--cc=aleksandr.mikhalitsyn@futurfusion.io \
--cc=alexander@mihalicyn.com \
--cc=jmarcin@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.