From: Luis Henriques <luis@igalia.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Amir Goldstein <amir73il@gmail.com>,
Bernd Schubert <bschubert@ddn.com>,
Bernd Schubert <bernd@bsbernd.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Horst Birthelmer <hbirthelmer@ddn.com>,
Joanne Koong <joannelkoong@gmail.com>,
Kevin Chen <kchen@ddn.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Harvey <mharvey@jumptrading.com>,
kernel-dev@igalia.com
Subject: Re: [RFC PATCH v3 1/8] fuse: simplify fuse_lookup_name() interface
Date: Sat, 28 Feb 2026 14:42:24 +0000 [thread overview]
Message-ID: <87sealx73j.fsf@wotan.olymp> (raw)
In-Reply-To: <CAJfpeguuLfaqG_JBapk9weWbkht=uuvzMfAPhXNmynxb4S6g2Q@mail.gmail.com> (Miklos Szeredi's message of "Fri, 27 Feb 2026 16:46:43 +0100")
On Fri, Feb 27 2026, Miklos Szeredi wrote:
> On Wed, 25 Feb 2026 at 12:25, Luis Henriques <luis@igalia.com> wrote:
>
>> @@ -570,30 +571,34 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name
>> attr_version = fuse_get_attr_version(fm->fc);
>> evict_ctr = fuse_get_evict_ctr(fm->fc);
>>
>> - fuse_lookup_init(fm->fc, &args, nodeid, name, outarg);
>> + fuse_lookup_init(fm->fc, &args, nodeid, name, &outarg);
>> err = fuse_simple_request(fm, &args);
>> /* Zero nodeid is same as -ENOENT, but with valid timeout */
>> - if (err || !outarg->nodeid)
>> + if (err || !outarg.nodeid)
>> goto out_put_forget;
>
> And now the timeout is skipped for the !outarg.nodeid case...
Oops, yeah I missed that. I'll fix it for the next iteration, thanks!
Cheers,
--
Luís
next prev parent reply other threads:[~2026-02-28 14:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 11:24 [RFC PATCH v3 0/8] fuse: LOOKUP_HANDLE operation Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 1/8] fuse: simplify fuse_lookup_name() interface Luis Henriques
2026-02-27 15:46 ` Miklos Szeredi
2026-02-28 14:42 ` Luis Henriques [this message]
2026-02-25 11:24 ` [RFC PATCH v3 2/8] fuse: export extend_arg() and factor out fuse_ext_size() Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 3/8] fuse: store index of the variable length argument Luis Henriques
2026-02-27 15:41 ` Miklos Szeredi
2026-02-28 14:50 ` Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 4/8] fuse: drop unnecessary argument from fuse_lookup_init() Luis Henriques
2026-02-27 15:57 ` Miklos Szeredi
2026-02-25 11:24 ` [RFC PATCH v3 5/8] fuse: extract helper functions from fuse_do_statx() Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 6/8] fuse: implementation of lookup_handle+statx compound operation Luis Henriques
2026-02-25 18:06 ` Amir Goldstein
2026-02-26 9:54 ` Luis Henriques
2026-02-26 10:08 ` Amir Goldstein
2026-02-26 10:29 ` Miklos Szeredi
2026-02-26 15:06 ` Luis Henriques
2026-02-26 15:44 ` Miklos Szeredi
2026-02-26 16:17 ` Luis Henriques
2026-02-26 10:33 ` Luis Henriques
2026-04-07 17:43 ` Joanne Koong
2026-04-07 21:20 ` Luis Henriques
2026-04-07 23:06 ` Joanne Koong
2026-04-07 23:24 ` Joanne Koong
2026-04-07 23:38 ` Joanne Koong
2026-04-08 10:22 ` Luis Henriques
2026-04-08 15:15 ` Joanne Koong
2026-04-08 10:16 ` Luis Henriques
2026-04-08 15:05 ` Joanne Koong
2026-04-09 10:46 ` Luis Henriques
2026-04-09 2:27 ` Jingbo Xu
2026-04-09 11:10 ` Luis Henriques
2026-04-10 2:18 ` Jingbo Xu
2026-04-09 14:03 ` Amir Goldstein
2026-04-10 2:17 ` Jingbo Xu
2026-02-25 11:24 ` [RFC PATCH v3 7/8] fuse: export fuse_open_args_fill() helper function Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 8/8] fuse: implementation of mkobj_handle+statx+open compound operation Luis Henriques
2026-02-25 15:08 ` Horst Birthelmer
2026-02-25 17:26 ` Luis Henriques
2026-02-25 15:14 ` [RFC PATCH v3 0/8] fuse: LOOKUP_HANDLE operation Horst Birthelmer
2026-02-25 17:06 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sealx73j.fsf@wotan.olymp \
--to=luis@igalia.com \
--cc=amir73il@gmail.com \
--cc=bernd@bsbernd.com \
--cc=bschubert@ddn.com \
--cc=djwong@kernel.org \
--cc=hbirthelmer@ddn.com \
--cc=joannelkoong@gmail.com \
--cc=kchen@ddn.com \
--cc=kernel-dev@igalia.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mharvey@jumptrading.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.