Re: [PATCH 5/5] json-parser: add location to JSON parsing errors

[Markus Armbruster <armbru@redhat.com>]

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 2/10/26 10:21, Markus Armbruster wrote:
>>> - *
>>> - * 0) make errors meaningful again
>> 
>> The errors weren't meaningless, just bad.  The "again" is kind of funny,
>> considering it's the initial commit.
>> 
>> I agree with removing the line, but i wonder what exactly improved
>> beyond line and column ("geometry information").
>
> I think it's more of a reference to the error recovery.  There's only so 
> many ways to report errors for a grammar as simple as JSON.

Point!

> But just for kicks I looked at the very first implementation and the 
> current state, and diff-ed the errors.  These are the differences:
>
> renamed:
> "expected separator in dict" -> "expected ',' or '}'"
> "expected separator in list" -> "expected ',' or ']'"
> "missing : in object pair" -> "expected ':'"
>
> removed (merged with "expecting value" or "premature end of input"):
> "Missing value in dict"
>
> split (out of just "expecting value"):
> "invalid interpolation '%s'"

Improvements.

> new errors:
> "can't interpolate into string"
> "%.*s is not a valid Unicode character"
> "duplicate key"
> "invalid UTF-8 sequence in string"
> "premature end of input"

Bug fixes :)

Thanks!

> So I don't know if they're "meaningful again", but there were some 
> changes over the years and the current set seems good enough to me!

Yes.  And further improvement, if desired, wouldn't be this series' job
anyway.