All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linux-doc@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Changbin Du <changbin.du@huawei.com>
Subject: Re: [PATCH v3] Rework the jobserver open logic
Date: Tue, 20 Jan 2026 16:09:12 -0700	[thread overview]
Message-ID: <87sebzhofb.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260117113632.18b19b4f@foz.lan>

Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:

> Em Fri, 16 Jan 2026 10:39:19 -0700
> Jonathan Corbet <corbet@lwn.net> escreveu:
>
>> -        self.is_open = True
>> +            except (IOError, OSError):
>> +                warn('Unable to reopen jobserver read-side pipe')
>
> I would add {repr(e)} here, to allow debugging what error was raised:
>
> 	warn(f"Unable to reopen jobserver read-side pipe: {repr(e)}")
>
> (or pass it via args, as the logic below)

OK, I've made those changes; now I think I'll just apply this, hopefully
it's good enough now.

Thanks,

jon

      parent reply	other threads:[~2026-01-20 23:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 17:39 [PATCH v3] Rework the jobserver open logic Jonathan Corbet
2026-01-17 10:36 ` Mauro Carvalho Chehab
2026-01-17 10:44   ` Mauro Carvalho Chehab
2026-01-20 23:09   ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sebzhofb.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=changbin.du@huawei.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.