From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BDECD185DB for ; Thu, 8 Jan 2026 11:36:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdoIU-0002iA-2g; Thu, 08 Jan 2026 06:35:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdoIO-0002a8-AH for qemu-devel@nongnu.org; Thu, 08 Jan 2026 06:35:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdoIM-000726-GM for qemu-devel@nongnu.org; Thu, 08 Jan 2026 06:35:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767872113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T0T4/P9Vmt0ixVlZfh9YF06TN+5S57ocpG7Jk+R82AY=; b=B3SclH+lILgGl7neCSmZQn76NczCtlqeyVVdvBJRADPYs2W8XdZuCvBkjZL98TkTxLKHVN sXxycUFJfUMz9JIhuzkuAmoyrU9pYzta0gljleeY3les7p5/xnUYzrhZZyfB7kBxNsLbIP MKYO2mN9VRi8+p6EWxKGnz+RI+7Qf2U= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-Cc6d2SgAOGuaZcshGwGRgQ-1; Thu, 08 Jan 2026 06:35:12 -0500 X-MC-Unique: Cc6d2SgAOGuaZcshGwGRgQ-1 X-Mimecast-MFC-AGG-ID: Cc6d2SgAOGuaZcshGwGRgQ_1767872111 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AD60F18003FD; Thu, 8 Jan 2026 11:35:10 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.32]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 35CE630002D1; Thu, 8 Jan 2026 11:35:10 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id BE0C821E6937; Thu, 08 Jan 2026 12:35:07 +0100 (CET) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: Bin Guo , qemu-devel@nongnu.org, pbonzini@redhat.com, philmd@linaro.org Subject: Re: [PATCH] monitor: disable "info kvm" if !KVM In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Thu, 8 Jan 2026 09:46:04 +0000") References: <20260107094020.21819-1-guobin@linux.alibaba.com> <87tswwbkoo.fsf@pond.sub.org> Date: Thu, 08 Jan 2026 12:35:07 +0100 Message-ID: <87secg8hhw.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Thu, Jan 08, 2026 at 08:57:59AM +0100, Markus Armbruster wrote: >> Bin Guo writes: >>=20 >> > Daniel P. Berrang=C3=A9 wrote on Mon, 5 Jan 2026 10:37:16 +0000: >> > >> >> Missing commit message explaining why we should do this ? >> > >> > The reason for submitting this patch is that the newly supported=20 >> > 'info accelerators' command can provide a more comprehensive view >> > of the accelerator's status. >>=20 >> Should we deprecate "info kvm"? > > Conceptually it is certainly redundant, and for HMP we offer no long > term stability promise. Is the benefiting of deprecating and then > removing it, worth the inconvenience we'll cause ? > > Perhaps the more important Q first is whether we should deprecate > query-kvm in QMP ? Yes. "info kvm" is a thin wrapper around query-kvm. We should either keep both or neither. What should management applications use, query-kvm or query-accelerators? If our answer is query-accelerators, we should guide them by deprecating query-kvm now. This doesn't mean we must delete it as soon as the deprecation grace period ends. If our answer is "we don't care", we can keep query-kvm. If our answer is query-kvm, adding query-accelerators was a mistake. But I don't think it is.