From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, csander@purestorage.com
Subject: Re: [PATCH liburing v2 2/4] test/bind-listen.t: Use ephemeral port
Date: Tue, 02 Dec 2025 18:37:22 -0500 [thread overview]
Message-ID: <87sedsh2vh.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <b8d9117f-7875-4b12-a747-5ee80eb5e1e3@kernel.dk> (Jens Axboe's message of "Wed, 26 Nov 2025 13:49:47 -0700")
Jens Axboe <axboe@kernel.dk> writes:
> On 11/25/25 2:27 PM, Gabriel Krisman Bertazi wrote:
>> This test fails if port 8000 is already in use by something else. Now
>> that we have getsockname with direct file descriptors, use an ephemeral
>> port instead.
>
> How is this going to work on older kernels? Probably retain the old
> behavior, even if kind of shitty, on old kernels. Otherwise anything
> pre 6.19 will now not run the bind-listen test at all.
Do you have a suggestion on how to check getsockname without doing the
whole socket setup just to probe, considering this is a uring_cmd?
Perhaps checking a feature that was merged at the same time?
If not, I'll come with something and send the v4 early tomorrow so you
can cut the new version still this week.
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2025-12-02 23:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 21:27 [PATCH liburing v2 0/4] liburing: getsockname support Gabriel Krisman Bertazi
2025-11-25 21:27 ` [PATCH liburing v2 1/4] liburing: Introduce getsockname operation Gabriel Krisman Bertazi
2025-11-25 21:27 ` [PATCH liburing v2 2/4] test/bind-listen.t: Use ephemeral port Gabriel Krisman Bertazi
2025-11-26 20:49 ` Jens Axboe
2025-12-02 23:37 ` Gabriel Krisman Bertazi [this message]
2025-12-03 2:49 ` Jens Axboe
2025-11-25 21:27 ` [PATCH liburing v2 3/4] bind-listen.t: Add tests for getsockname Gabriel Krisman Bertazi
2025-11-26 20:58 ` Jens Axboe
2025-11-25 21:27 ` [PATCH liburing v2 4/4] man/io_uring_prep_getsockname.3: Add man page Gabriel Krisman Bertazi
2025-11-26 20:54 ` Jens Axboe
2025-12-02 15:16 ` [PATCH liburing v2 0/4] liburing: getsockname support Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2025-11-20 22:13 Gabriel Krisman Bertazi
2025-11-20 22:13 ` [PATCH liburing v2 2/4] test/bind-listen.t: Use ephemeral port Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sedsh2vh.fsf@mailhost.krisman.be \
--to=krisman@suse.de \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.