From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8007334DB47; Tue, 18 Nov 2025 16:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.79.88.28 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763483898; cv=none; b=eHHnbSpXbKCMye80jmubEe49/9KP7Pl+8BL8bhUhOaQT9YXSDZpjJ28cIv7zRH+QC/DiIWwNizmjWd4tLB2UP/qO1b/Ai5/isLqJMzOX067w9OW3wtjC6nWC+q6JXnKNYaReQbA66fyf1FvdQKL/lNNcbt0AtvOO/eAgxCJQ5+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763483898; c=relaxed/simple; bh=UfkrHVio+Czb+hNRlOF8S3mEHz7UJpwxt5CAozAtf5U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Mv631mTx8A0R9B0xJd8h/wGznqaAqDGg1aEdRgXe51Wz5Nh/HAQt1/I2lY4aCNSFB8bypX6QBywpl3m0rU7G515EERmsNuPfjjC9RJ6zBePWMJoCZH9hqs+XH2FsQsFoa/gnNeoYLAAK4Zt/GI9qdr5H560mT1R8ZYdM4vWb6uM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net; spf=pass smtp.mailfrom=lwn.net; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b=Xs9LYbGd; arc=none smtp.client-ip=45.79.88.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lwn.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b="Xs9LYbGd" DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net A2B0240C3E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1763483896; bh=4DSR+e5zgphjkdqy1n3flsSBWx54VvMwDl5bi6C9QUg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Xs9LYbGdMAjA6L7s8EFxtA0g8bw9rWJC0l9r2iiObUTHOalpZw+hc8iPu4Qd14oZF 9mM8xxHEEkFXhQw3hA/WD4chNw10BH2tUbFtt7oRP2qUev1VDlYMyD4N+hIvDYKY/k QdqmnBCMOZjFH21N0x2y4F1DEYBoQ7fqTCGiXMbcOxgM5rs3xAG3Q46IDFKwmKeSNU cNC0xqYUwN6Wz1GJp0UXLRFJsxhtr+pqYxo7CFdBiHtqs4BTV21RmCfRDZZRS4cG/u ATB+hL3/el2pV+zHdOVPVO2FEUZmRg4HDmQfJg5FYgA9nE+FUpthzP+XyF4qTSrrtJ zM3lhEKgqktYA== Received: from localhost (unknown [IPv6:2601:280:4600:2da9::1fe]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id A2B0240C3E; Tue, 18 Nov 2025 16:38:16 +0000 (UTC) From: Jonathan Corbet To: Mauro Carvalho Chehab , Miguel Ojeda Cc: Mauro Carvalho Chehab , Linux Doc Mailing List , Alex Gaynor , Alice Ryhl , Andreas Hindborg , Benno Lossin , =?utf-8?Q?Bj?= =?utf-8?Q?=C3=B6rn?= Roy Baron , Boqun Feng , Danilo Krummrich , Gary Guo , Mauro Carvalho Chehab , Miguel Ojeda , Trevor Gross , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH 1/1] docs: makefile: move rustdoc check to the build wrapper In-Reply-To: References: Date: Tue, 18 Nov 2025 09:38:15 -0700 Message-ID: <87seeb47pk.fsf@trenco.lwn.net> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mauro Carvalho Chehab writes: > On Mon, Nov 17, 2025 at 10:20:46AM +0100, Miguel Ojeda wrote: >> On Mon, Nov 17, 2025 at 10:13=E2=80=AFAM Mauro Carvalho Chehab >> wrote: >> > >> > The makefile logic to detect if rust is enabled is not working >> > the way it was expected. Move it to be inside the wrapper >> > script. >>=20 >> Hmm... Could the commit explain a bit why this didn't work and why now i= t does? > > I don't know exactly why this was not working. I would feel a lot better if we knew what the real problem is before applying fixes for it. Otherwise something seems certain to come and bite us at some point. Thanks, jon