From: Thomas Gleixner <tglx@linutronix.de>
To: Ma Ke <make24@iscas.ac.cn>, maz@kernel.org, shawn.guo@linaro.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Ma Ke <make24@iscas.ac.cn>,
stable@vger.kernel.org
Subject: Re: [PATCH] irqchip: Fix error handling in qcom_mpm_init
Date: Sun, 16 Nov 2025 19:16:28 +0100 [thread overview]
Message-ID: <87seed972b.ffs@tglx> (raw)
In-Reply-To: <20251116081602.28926-1-make24@iscas.ac.cn>
On Sun, Nov 16 2025 at 16:16, Ma Ke wrote:
> of_find_device_by_node() increments the reference count but it's never
> decremented, preventing proper device cleanup. Add put_device()
> properly to ensure references released before function return.
>
> Found by code review.
By whom? You sent 7 patches today which touch random parts of the
kernel:
[PATCH] irqchip: Fix error handling in qcom_mpm_init
[PATCH] phy: HiSilicon: Fix error handling in hi3670_pcie_get_resources_from_pcie
[PATCH] ASoC: codecs: wcd937x: Fix error handling in wcd937x codec driver
[PATCH] ASoC: codecs: Fix error handling in pm4125 audio codec driver
[PATCH] powerpc/warp: Fix error handling in pika_dtm_thread
[PATCH] USB: Fix error handling in gadget driver
[PATCH] USB: ohci-nxp: Fix error handling in ohci-hcd-nxp driver
and in all of them you claim to have found them by code review.
Why do I have doubts especially when I look at your email address?
Thanks,
tglx
next prev parent reply other threads:[~2025-11-16 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 8:16 [PATCH] irqchip: Fix error handling in qcom_mpm_init Ma Ke
2025-11-16 10:34 ` Thomas Gleixner
2025-11-16 18:16 ` Thomas Gleixner [this message]
2025-11-17 0:47 ` Ma Ke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seed972b.ffs@tglx \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=maz@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.